Skip to content

Commit 23bd58d

Browse files
committed
fix tests
1 parent c983708 commit 23bd58d

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

src/client/common/application/commands.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ export interface ICommandNameArgumentTypeMapping extends ICommandNameWithoutArgu
8787
['jupyter.opennotebook']: [undefined | Uri, undefined | CommandSource];
8888
['jupyter.runallcells']: [Uri];
8989
['extension.open']: [string];
90-
['workbench.action.openIssueReporter']: [{ extensionId: string; issueBody: string }];
90+
['workbench.action.openIssueReporter']: [{ extensionId: string; issueBody: string; extensionData?: string }];
9191
[Commands.GetSelectedInterpreterPath]: [{ workspaceFolder: string } | string[]];
9292
[Commands.TriggerEnvironmentSelection]: [undefined | Uri];
9393
[Commands.Start_Native_REPL]: [undefined | Uri];

src/test/common/application/commands/reportIssueCommand.unit.test.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -126,17 +126,17 @@ suite('Report Issue Command', () => {
126126
);
127127
const expectedData = fs.readFileSync(userDataTemplatePath, 'utf8');
128128

129-
const args: [string, { extensionId: string; issueBody: string; data: string }] = capture<
129+
const args: [string, { extensionId: string; issueBody: string; extensionData: string }] = capture<
130130
AllCommands,
131-
{ extensionId: string; issueBody: string; data: string }
131+
{ extensionId: string; issueBody: string; extensionData: string }
132132
>(cmdManager.executeCommand).last();
133133

134134
verify(cmdManager.registerCommand(Commands.ReportIssue, anything(), anything())).once();
135135
verify(cmdManager.executeCommand('workbench.action.openIssueReporter', anything())).once();
136136
expect(args[0]).to.be.equal('workbench.action.openIssueReporter');
137-
const { issueBody, data } = args[1];
137+
const { issueBody, extensionData } = args[1];
138138
expect(issueBody).to.be.equal(expectedIssueBody);
139-
expect(data).to.be.equal(expectedData);
139+
expect(extensionData).to.be.equal(expectedData);
140140
});
141141

142142
test('Test if issue body is filled when only including settings which are explicitly set', async () => {
@@ -167,16 +167,16 @@ suite('Report Issue Command', () => {
167167
);
168168
const expectedData = fs.readFileSync(userDataTemplatePath, 'utf8');
169169

170-
const args: [string, { extensionId: string; issueBody: string; data: string }] = capture<
170+
const args: [string, { extensionId: string; issueBody: string; extensionData: string }] = capture<
171171
AllCommands,
172-
{ extensionId: string; issueBody: string; data: string }
172+
{ extensionId: string; issueBody: string; extensionData: string }
173173
>(cmdManager.executeCommand).last();
174174

175175
verify(cmdManager.executeCommand('workbench.action.openIssueReporter', anything())).once();
176176
expect(args[0]).to.be.equal('workbench.action.openIssueReporter');
177-
const { issueBody, data } = args[1];
177+
const { issueBody, extensionData } = args[1];
178178
expect(issueBody).to.be.equal(expectedIssueBody);
179-
expect(data).to.be.equal(expectedData);
179+
expect(extensionData).to.be.equal(expectedData);
180180
});
181181
test('Should send telemetry event when run Report Issue Command', async () => {
182182
const sendTelemetryStub = sinon.stub(Telemetry, 'sendTelemetryEvent');

0 commit comments

Comments
 (0)