Skip to content

Commit d265189

Browse files
Copilotdmichon-msft
andcommitted
fix: address code review - correct confusing test comment
Co-authored-by: dmichon-msft <26827560+dmichon-msft@users.noreply.github.com>
1 parent 95d0931 commit d265189

1 file changed

Lines changed: 3 additions & 7 deletions

File tree

libraries/rush-lib/src/logic/pnpm/test/PnpmShrinkwrapFile.test.ts

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -412,13 +412,9 @@ snapshots:
412412
expect(rootIntegrityMap1).toBeDefined();
413413
expect(rootIntegrityMap2).toBeDefined();
414414

415-
// The root importer should have different integrity because the linked workspace
416-
// package's dependencies changed
417-
const rootIntegrity1 = rootIntegrityMap1!.get('.');
418-
const rootIntegrity2 = rootIntegrityMap2!.get('.');
419-
420-
// The self-hash of '.' changes because the importer object itself doesn't change
421-
// (it still references link:projects/my-lib), but the workspace lib's hash should differ
415+
// The self-hash of '.' does NOT change because the root importer object itself is identical
416+
// in both cases (it still references link:projects/my-lib). However, the workspace lib's
417+
// integrity hash should differ because its lodash dependency resolved to a different version.
422418
const libIntegrity1 = rootIntegrityMap1!.get('projects/my-lib');
423419
const libIntegrity2 = rootIntegrityMap2!.get('projects/my-lib');
424420

0 commit comments

Comments
 (0)