From 63f1ce36215953f30ece2f12d04c48efee12b347 Mon Sep 17 00:00:00 2001 From: Elvis Pranskevichus Date: Thu, 13 Mar 2025 14:56:42 -0700 Subject: [PATCH] Populate `name` in virtualenvwrapper envs virtualenvwrapper environments are named, expose the name appropriately. --- crates/pet-virtualenvwrapper/src/lib.rs | 3 +++ crates/pet/tests/ci_test.rs | 1 + 2 files changed, 4 insertions(+) diff --git a/crates/pet-virtualenvwrapper/src/lib.rs b/crates/pet-virtualenvwrapper/src/lib.rs index 4d4a5dce..a76f8262 100644 --- a/crates/pet-virtualenvwrapper/src/lib.rs +++ b/crates/pet-virtualenvwrapper/src/lib.rs @@ -49,12 +49,15 @@ impl Locator for VirtualEnvWrapper { }, }; let mut symlinks = vec![]; + let mut name = None; if let Some(ref prefix) = env.prefix { symlinks.append(&mut find_executables(prefix)); + name = prefix.file_name().and_then(|f| f.to_str()); } Some( PythonEnvironmentBuilder::new(Some(PythonEnvironmentKind::VirtualEnvWrapper)) + .name(name.map(String::from)) .executable(Some(env.executable.clone())) .version(version) .prefix(env.prefix.clone()) diff --git a/crates/pet/tests/ci_test.rs b/crates/pet/tests/ci_test.rs index 306afa75..4891e14d 100644 --- a/crates/pet/tests/ci_test.rs +++ b/crates/pet/tests/ci_test.rs @@ -161,6 +161,7 @@ fn check_if_virtualenvwrapper_exists() { |env| env.kind == Some(PythonEnvironmentKind::VirtualEnvWrapper) && env.executable.is_some() && env.prefix.is_some() + && env.name == Some("venv_wrapper_env1".to_string()) && env .executable .clone()