Skip to content

Commit aa63684

Browse files
committed
Discriminate browsers for selector test
1 parent d03400a commit aa63684

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

tests/async/test_selectors_misc.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414

1515
import pytest
1616

17+
from playwright._impl._browser import Browser
1718
from playwright._impl._errors import Error
1819
from playwright._impl._selectors import Selectors
1920
from playwright.async_api import Page
@@ -60,6 +61,7 @@ async def test_should_work_with_internal_and(page: Page) -> None:
6061

6162
async def test_should_throw_already_registered_error_when_registering(
6263
selectors: Selectors,
64+
browser: Browser,
6365
) -> None:
6466
create_tag_selector = """
6567
() => ({
@@ -71,9 +73,10 @@ async def test_should_throw_already_registered_error_when_registering(
7173
}
7274
})
7375
"""
74-
await selectors.register("alreadyRegistered", create_tag_selector)
76+
name = f"alreadyRegistered-{browser.browser_type.name}"
77+
await selectors.register(name, create_tag_selector)
7578
with pytest.raises(
7679
Error,
77-
match='Selectors.register: "alreadyRegistered" selector engine has been already registered',
80+
match=f'Selectors.register: "{name}" selector engine has been already registered',
7881
):
79-
await selectors.register("alreadyRegistered", create_tag_selector)
82+
await selectors.register(name, create_tag_selector)

0 commit comments

Comments
 (0)