Add browser_type assertions

Author: agg23

playwright/_impl/_browser.py

@@ -106,10 +106,8 @@ def _did_create_context(self, context: BrowserContext) -> None:
 
     def _setup_browser_context(self, context: BrowserContext) -> None:
         context._tracing._traces_dir = self._traces_dir
-        if self._browser_type:
-            self._browser_type._playwright.selectors._contexts_for_selectors.add(
-                context
-            )
+        assert self._browser_type is not None
+        self._browser_type._playwright.selectors._contexts_for_selectors.add(context)
 
     def _on_close(self) -> None:
         self._is_connected = False
@@ -121,10 +119,7 @@ def contexts(self) -> List[BrowserContext]:
 
     @property
     def browser_type(self) -> "BrowserType":
-        if not self._browser_type:
-            raise RuntimeError(
-                "_browser_type is not set. Make sure _connect_to_browser_type() is called on initialization."
-            )
+        assert self._browser_type is not None
         return self._browser_type
 
     def is_connected(self) -> bool:
@@ -170,8 +165,8 @@ async def new_context(
         clientCertificates: List[ClientCertificate] = None,
     ) -> BrowserContext:
         params = locals_to_params(locals())
-        if self._browser_type:
-            await self._browser_type._prepare_browser_context_params(params)
+        assert self._browser_type is not None
+        await self._browser_type._prepare_browser_context_params(params)
 
         channel = await self._channel.send("newContext", params)
         context = cast(BrowserContext, from_channel(channel))

playwright/_impl/_browser_context.py

@@ -570,9 +570,9 @@ def _on_close(self) -> None:
         if self._browser:
             if self in self._browser._contexts:
                 self._browser._contexts.remove(self)
+            assert self._browser._browser_type is not None
             if (
-                self._browser._browser_type
-                and self
+                self
                 in self._browser._browser_type._playwright.selectors._contexts_for_selectors
             ):
                 self._browser._browser_type._playwright.selectors._contexts_for_selectors.remove(