Fixed context options and video tests

Author: agg23

playwright/_impl/_browser_context.py

@@ -116,7 +116,7 @@ def __init__(
         self._bindings: Dict[str, Any] = {}
         self._timeout_settings = TimeoutSettings(None)
         self._owner_page: Optional[Page] = None
-        self._options: Dict[str, Any] = {}
+        self._options: Dict[str, Any] = initializer.get("options", {})
         self._background_pages: Set[Page] = set()
         self._service_workers: Set[Worker] = set()
         self._tracing = cast(Tracing, from_channel(initializer["tracing"]))
@@ -302,15 +302,6 @@ def pages(self) -> List[Page]:
     def browser(self) -> Optional["Browser"]:
         return self._browser
 
-    def _set_options(self, context_options: Dict, browser_options: Dict) -> None:
-        self._options = context_options
-        if self._options.get("recordHar"):
-            self._har_recorders[""] = {
-                "path": self._options["recordHar"]["path"],
-                "content": self._options["recordHar"].get("content"),
-            }
-        self._tracing._traces_dir = browser_options.get("tracesDir")
-
     async def _initialize_har_from_options(self, options: Dict) -> None:
         record_har_path = options.get("recordHarPath")
         if not record_har_path:

playwright/_impl/_browser_type.py

@@ -95,7 +95,9 @@ async def launch(
         browser = cast(
             Browser, from_channel(await self._channel.send("launch", params))
         )
-        browser._connect_to_browser_type(self, str(tracesDir))
+        browser._connect_to_browser_type(
+            self, str(tracesDir) if tracesDir is not None else None
+        )
         return browser
 
     async def launch_persistent_context(
@@ -163,7 +165,9 @@ async def launch_persistent_context(
             Browser,
             from_channel(result["browser"]),
         )
-        browser._connect_to_browser_type(self, str(tracesDir))
+        browser._connect_to_browser_type(
+            self, str(tracesDir) if tracesDir is not None else None
+        )
         context = cast(BrowserContext, from_channel(result["context"]))
         await context._initialize_har_from_options(
             {