Fix Chromium tracing tests

Author: agg23

playwright/_impl/_assertions.py

@@ -138,7 +138,7 @@ async def to_have_url(
         ignoreCase: bool = None,
     ) -> None:
         __tracebackhide__ = True
-        base_url = self._actual_page.context.base_url
+        base_url = self._actual_page.context._base_url
         if isinstance(urlOrRegExp, str) and base_url:
             urlOrRegExp = urljoin(base_url, urlOrRegExp)
         expected_text = to_expected_text_values([urlOrRegExp], ignoreCase=ignoreCase)

playwright/_impl/_frame.py

@@ -224,7 +224,7 @@ def predicate(event: Any) -> bool:
                 return True
             waiter.log(f'  navigated to "{event["url"]}"')
             return url_matches(
-                cast("Page", self._page)._browser_context.base_url,
+                cast("Page", self._page)._browser_context._base_url,
                 event["url"],
                 url,
             )
@@ -257,7 +257,7 @@ async def wait_for_url(
         timeout: float = None,
     ) -> None:
         assert self._page
-        if url_matches(self._page._browser_context.base_url, self.url, url):
+        if url_matches(self._page._browser_context._base_url, self.url, url):
             await self._wait_for_load_state_impl(state=waitUntil, timeout=timeout)
             return
         async with self.expect_navigation(

playwright/_impl/_page.py

@@ -388,7 +388,7 @@ def frame(self, name: str = None, url: URLMatch = None) -> Optional[Frame]:
         for frame in self._frames:
             if name and frame.name == name:
                 return frame
-            if url and url_matches(self._browser_context.base_url, frame.url, url):
+            if url and url_matches(self._browser_context._base_url, frame.url, url):
                 return frame
 
         return None
@@ -680,7 +680,7 @@ async def route(
         self._routes.insert(
             0,
             RouteHandler(
-                self._browser_context.base_url,
+                self._browser_context._base_url,
                 url,
                 handler,
                 True if self._dispatcher_fiber else False,
@@ -722,7 +722,7 @@ async def route_web_socket(
     ) -> None:
         self._web_socket_routes.insert(
             0,
-            WebSocketRouteHandler(self._browser_context.base_url, url, handler),
+            WebSocketRouteHandler(self._browser_context._base_url, url, handler),
         )
         await self._update_web_socket_interception_patterns()
 
@@ -1268,7 +1268,7 @@ def expect_request(
         def my_predicate(request: Request) -> bool:
             if not callable(urlOrPredicate):
                 return url_matches(
-                    self._browser_context.base_url,
+                    self._browser_context._base_url,
                     request.url,
                     urlOrPredicate,
                 )
@@ -1300,7 +1300,7 @@ def expect_response(
         def my_predicate(request: Response) -> bool:
             if not callable(urlOrPredicate):
                 return url_matches(
-                    self._browser_context.base_url,
+                    self._browser_context._base_url,
                     request.url,
                     urlOrPredicate,
                 )

tests/async/test_chromium_tracing.py

@@ -44,6 +44,13 @@ async def test_should_create_directories_as_needed(
     assert os.path.getsize(output_file) > 0
 
 
+async def rafraf(target: Page, count: int = 1) -> None:
+    for _ in range(count):
+        await target.evaluate(
+            "async () => await new Promise(f => window.requestAnimationFrame(() => window.requestAnimationFrame(f)));"
+        )
+
+
 @pytest.mark.only_browser("chromium")
 async def test_should_run_with_custom_categories_if_provided(
     browser: Browser, page: Page, tmp_path: Path
@@ -54,6 +61,7 @@ async def test_should_run_with_custom_categories_if_provided(
         path=output_file,
         categories=["disabled-by-default-cc.debug"],
     )
+    await rafraf(page)
     await browser.stop_tracing()
     with open(output_file, mode="r") as of:
         trace_json = json.load(of)