Skip to content

Commit 196f0da

Browse files
committed
Some PR changes
1 parent 4efaa3a commit 196f0da

File tree

4 files changed

+11
-9
lines changed

4 files changed

+11
-9
lines changed

tests/async/test_accessibility.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@
2020

2121

2222
async def test_accessibility_should_work(
23-
page: Page, is_firefox: bool, is_chromium: bool
23+
page: Page, is_firefox: bool, is_chromium: bool, is_webkit: bool
2424
) -> None:
25-
if not is_firefox and not is_chromium and sys.platform == "darwin":
25+
if is_webkit and sys.platform == "darwin":
2626
pytest.skip("Test disabled on WebKit on macOS")
2727
await page.set_content(
2828
"""<head>

tests/async/test_fetch_global.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -534,9 +534,9 @@ async def test_should_follow_max_redirects(
534534
def _handle_request(req: TestServerRequest) -> None:
535535
nonlocal redirect_count
536536
redirect_count += 1
537-
req.setResponseCode(301),
538-
req.setHeader("Location", server.EMPTY_PAGE),
539-
req.finish(),
537+
req.setResponseCode(301)
538+
req.setHeader("Location", server.EMPTY_PAGE)
539+
req.finish()
540540

541541
server.set_route("/empty.html", _handle_request)
542542
request = await playwright.request.new_context(max_redirects=1)

tests/sync/test_accessibility.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,10 @@
2121

2222

2323
def test_accessibility_should_work(
24-
page: Page, is_firefox: bool, is_chromium: bool
24+
page: Page, is_firefox: bool, is_chromium: bool, is_webkit: bool
2525
) -> None:
26+
if is_webkit and sys.platform == "darwin":
27+
pytest.skip("Test disabled on WebKit on macOS")
2628
page.set_content(
2729
"""<head>
2830
<title>Accessibility Test</title>

tests/sync/test_fetch_global.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -369,9 +369,9 @@ def test_should_follow_max_redirects(playwright: Playwright, server: Server) ->
369369
def _handle_request(req: TestServerRequest) -> None:
370370
nonlocal redirect_count
371371
redirect_count += 1
372-
req.setResponseCode(301),
373-
req.setHeader("Location", server.EMPTY_PAGE),
374-
req.finish(),
372+
req.setResponseCode(301)
373+
req.setHeader("Location", server.EMPTY_PAGE)
374+
req.finish()
375375

376376
server.set_route("/empty.html", _handle_request)
377377
request = playwright.request.new_context(max_redirects=1)

0 commit comments

Comments
 (0)