From f7ced0f6d53c7c3b6010d5a54aeb66b81a4e8d71 Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Fri, 31 Oct 2025 09:54:58 -0700 Subject: [PATCH] chore: remove background pages implementation --- .../microsoft/playwright/impl/BrowserContextImpl.java | 10 +--------- .../java/com/microsoft/playwright/impl/PageImpl.java | 1 - 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/playwright/src/main/java/com/microsoft/playwright/impl/BrowserContextImpl.java b/playwright/src/main/java/com/microsoft/playwright/impl/BrowserContextImpl.java index 4edc31fc..3437cc33 100644 --- a/playwright/src/main/java/com/microsoft/playwright/impl/BrowserContextImpl.java +++ b/playwright/src/main/java/com/microsoft/playwright/impl/BrowserContextImpl.java @@ -46,7 +46,6 @@ class BrowserContextImpl extends ChannelOwner implements BrowserContext { private final APIRequestContextImpl request; private final ClockImpl clock; final List pages = new ArrayList<>(); - final List backgroundPages = new ArrayList<>(); final Router routes = new Router(); final WebSocketRouter webSocketRoutes = new WebSocketRouter(); @@ -81,7 +80,6 @@ static class HarRecorder { } enum EventType { - BACKGROUNDPAGE, CLOSE, CONSOLE, DIALOG, @@ -133,12 +131,10 @@ String effectiveCloseReason() { @Override public void onBackgroundPage(Consumer handler) { - listeners.add(EventType.BACKGROUNDPAGE, handler); } @Override public void offBackgroundPage(Consumer handler) { - listeners.remove(EventType.BACKGROUNDPAGE, handler); } @Override @@ -340,7 +336,7 @@ public void addInitScript(Path path) { @Override public List backgroundPages() { - return new ArrayList<>(backgroundPages); + return Collections.emptyList(); } @Override @@ -719,10 +715,6 @@ protected void handleEvent(String event, JsonObject params) { if (page.opener() != null && !page.opener().isClosed()) { page.opener().notifyPopup(page); } - } else if ("backgroundPage".equals(event)) { - PageImpl page = connection.getExistingObject(params.getAsJsonObject("page").get("guid").getAsString()); - backgroundPages.add(page); - listeners.notify(EventType.BACKGROUNDPAGE, page); } else if ("bindingCall".equals(event)) { BindingCall bindingCall = connection.getExistingObject(params.getAsJsonObject("binding").get("guid").getAsString()); BindingCallback binding = bindings.get(bindingCall.name()); diff --git a/playwright/src/main/java/com/microsoft/playwright/impl/PageImpl.java b/playwright/src/main/java/com/microsoft/playwright/impl/PageImpl.java index de73ffae..29dfb9d0 100644 --- a/playwright/src/main/java/com/microsoft/playwright/impl/PageImpl.java +++ b/playwright/src/main/java/com/microsoft/playwright/impl/PageImpl.java @@ -237,7 +237,6 @@ void notifyPopup(PageImpl popup) { void didClose() { isClosed = true; browserContext.pages.remove(this); - browserContext.backgroundPages.remove(this); listeners.notify(EventType.CLOSE, this); }