From f13bc6ec4a8502ad9fec78a3676b2110f86a2876 Mon Sep 17 00:00:00 2001 From: Max Schmitt Date: Mon, 10 Feb 2025 13:47:16 +0100 Subject: [PATCH 1/4] chore: auto update example pw version in pom --- examples/pom.xml | 3 ++- scripts/set_maven_version.sh | 13 +++++++++---- 2 files changed, 11 insertions(+), 5 deletions(-) diff --git a/examples/pom.xml b/examples/pom.xml index 42aacfdd3..a2e4f2827 100644 --- a/examples/pom.xml +++ b/examples/pom.xml @@ -10,12 +10,13 @@ Playwright Client Examples UTF-8 + 1.49.0 com.microsoft.playwright playwright - 1.41.0 + ${playwright-version} diff --git a/scripts/set_maven_version.sh b/scripts/set_maven_version.sh index 946b316ad..e7eb71ee7 100755 --- a/scripts/set_maven_version.sh +++ b/scripts/set_maven_version.sh @@ -20,7 +20,12 @@ POM_FILES=( examples/pom.xml ) -for name in ${POM_FILES[*]}; -do - mvn versions:set -D generateBackupPoms=false -D newVersion=$VERSION -f $name -done +node -e "$(cat < parseInt(part, 10)); + parts[1]--; + const previousMajorVersion = parts.join('.'); + fs.writeFileSync('examples/pom.xml', fs.readFileSync('examples/pom.xml', 'utf8') + .replace(/.*<\/playwright-version>/, '' + previousMajorVersion + '') + ); +EOF +)" $VERSION From 464963839ffe1df583d0ec26a5c21889d5396603 Mon Sep 17 00:00:00 2001 From: Max Schmitt Date: Tue, 11 Feb 2025 12:37:49 +0100 Subject: [PATCH 2/4] review feedback --- examples/pom.xml | 4 ++-- scripts/set_maven_version.sh | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/examples/pom.xml b/examples/pom.xml index a2e4f2827..7dfb7dc6f 100644 --- a/examples/pom.xml +++ b/examples/pom.xml @@ -10,13 +10,13 @@ Playwright Client Examples UTF-8 - 1.49.0 + 1.49.0 com.microsoft.playwright playwright - ${playwright-version} + ${playwright.version} diff --git a/scripts/set_maven_version.sh b/scripts/set_maven_version.sh index e7eb71ee7..d1dd62615 100755 --- a/scripts/set_maven_version.sh +++ b/scripts/set_maven_version.sh @@ -21,11 +21,11 @@ POM_FILES=( ) node -e "$(cat < parseInt(part, 10)); + const parts = process.argv[1].split('-')[0].split('.').map(part => parseInt(part, 10)); parts[1]--; const previousMajorVersion = parts.join('.'); fs.writeFileSync('examples/pom.xml', fs.readFileSync('examples/pom.xml', 'utf8') - .replace(/.*<\/playwright-version>/, '' + previousMajorVersion + '') + .replace(/.*<\/playwright\.version>/, '' + previousMajorVersion + '') ); EOF )" $VERSION From ec48e0e7cd8b44c0b3366a64385e99e661142865 Mon Sep 17 00:00:00 2001 From: Max Schmitt Date: Tue, 11 Feb 2025 23:28:12 +0100 Subject: [PATCH 3/4] move to roll_driver --- scripts/roll_driver.sh | 12 +++++++++++- scripts/set_maven_version.sh | 10 ---------- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/scripts/roll_driver.sh b/scripts/roll_driver.sh index 2c47c3aff..243bdebd4 100755 --- a/scripts/roll_driver.sh +++ b/scripts/roll_driver.sh @@ -24,4 +24,14 @@ else fi; ./generate_api.sh -./update_readme.sh \ No newline at end of file +./update_readme.sh + +node -e "$(cat < parseInt(part, 10)); + minorVersion[1]--; + const previousMajorVersion = majorVersion + '.' + minorVersion + '.0'; + fs.writeFileSync('../examples/pom.xml', fs.readFileSync('../examples/pom.xml', 'utf8') + .replace(/.*<\/playwright\.version>/, '' + previousMajorVersion + '') + ); +EOF +)" $NEW_VERSION diff --git a/scripts/set_maven_version.sh b/scripts/set_maven_version.sh index d1dd62615..bec4ce882 100755 --- a/scripts/set_maven_version.sh +++ b/scripts/set_maven_version.sh @@ -19,13 +19,3 @@ POM_FILES=( tools/*/pom.xml examples/pom.xml ) - -node -e "$(cat < parseInt(part, 10)); - parts[1]--; - const previousMajorVersion = parts.join('.'); - fs.writeFileSync('examples/pom.xml', fs.readFileSync('examples/pom.xml', 'utf8') - .replace(/.*<\/playwright\.version>/, '' + previousMajorVersion + '') - ); -EOF -)" $VERSION From 96c007f36717456dd012ad0642053031ec31c14e Mon Sep 17 00:00:00 2001 From: Max Schmitt Date: Tue, 11 Feb 2025 23:28:54 +0100 Subject: [PATCH 4/4] Automate Maven version update in script --- scripts/set_maven_version.sh | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/scripts/set_maven_version.sh b/scripts/set_maven_version.sh index bec4ce882..946b316ad 100755 --- a/scripts/set_maven_version.sh +++ b/scripts/set_maven_version.sh @@ -19,3 +19,8 @@ POM_FILES=( tools/*/pom.xml examples/pom.xml ) + +for name in ${POM_FILES[*]}; +do + mvn versions:set -D generateBackupPoms=false -D newVersion=$VERSION -f $name +done