Skip to content

Serialization packages: CHANGELOG.md and LICENSE files are saving to the root site-packages dir #406

@Pete-rePete

Description

@Pete-rePete

Description

As the title says, CHANGELOG.md and LICENSE files are saving to the root site-packages dir. If you install all the serialization packages, these 2 files get overwritten a few times. Then when uninstalling (or running poetry update for that matter) you quickly run into FileNotFoundError errors and poetry telling you Cannot install microsoft-kiota-serialization-text or any of the other ones.

Proposed Solution

  • For license, you don't even need to include it in the include, it gets detected automatically and is included within the package. (here are the files that get included automatically).
  • For changelog you'd need to do a clever hack like this if you really, really want to include it in the python package. I'd recommend just not including changelog in the python package, I can't conceive a reason why the functional code would need it

I made a PR here

Contextual information

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    Status

    Done ✔️

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions