Merge pull request #483 from microsoft/fix/optional-type

fix: optional type definition for on before event in parse node

Author: baywet

packages/abstractions/kiota_abstractions/serialization/parse_node.py

@@ -177,7 +177,7 @@ def get_bytes_value(self) -> Optional[bytes]:
 
     @property
     @abstractmethod
-    def on_before_assign_field_values(self) -> Callable[[Parsable], None]:
+    def on_before_assign_field_values(self) -> Optional[Callable[[Parsable], None]]:
         """Gets the callback called before the node is deserialized.
 
         Returns:

packages/serialization/form/kiota_serialization_form/form_parse_node.py

@@ -330,8 +330,10 @@ def try_get_anything(self, value: Any) -> Any:
 
     def _create_new_node(self, node: Any) -> FormParseNode:
         new_node: FormParseNode = FormParseNode(node)
-        new_node.on_before_assign_field_values = self.on_before_assign_field_values
-        new_node.on_after_assign_field_values = self.on_after_assign_field_values
+        if self.on_before_assign_field_values:
+            new_node.on_before_assign_field_values = self.on_before_assign_field_values
+        if self.on_after_assign_field_values:
+            new_node.on_after_assign_field_values = self.on_after_assign_field_values
         return new_node
 
     def _get_fields(self, raw_value: str) -> dict[str, str]:

packages/serialization/json/kiota_serialization_json/json_parse_node.py

@@ -348,6 +348,8 @@ def try_get_anything(self, value: Any) -> Any:
 
     def _create_new_node(self, node: Any) -> JsonParseNode:
         new_node: JsonParseNode = JsonParseNode(node)
-        new_node.on_before_assign_field_values = self.on_before_assign_field_values
-        new_node.on_after_assign_field_values = self.on_after_assign_field_values
+        if self.on_before_assign_field_values:
+            new_node.on_before_assign_field_values = self.on_before_assign_field_values
+        if self.on_after_assign_field_values:
+            new_node.on_after_assign_field_values = self.on_after_assign_field_values
         return new_node