Merge pull request #252 from microsoft/add-more-remote-flow-sources

PS: Add flow sources from `System.Net.WebClient`

Author: MathiasVP

…s/Microsoft.PowerShell.Utility.model.yml …rameworks/Microsoft.PowerShell.model.ymlpowershell/ql/lib/semmle/code/powershell/frameworks/Microsoft.PowerShell.Utility.model.yml renamed to powershell/ql/lib/semmle/code/powershell/frameworks/Microsoft.PowerShell.model.yml powershell/ql/lib/semmle/code/powershell/frameworks/Microsoft.PowerShell.Utility.model.yml renamed to powershell/ql/lib/semmle/code/powershell/frameworks/Microsoft.PowerShell.model.yml

@@ -1,4 +1,10 @@
 extensions:
+  - addsTo:
+      pack: microsoft/powershell-all
+      extensible: summaryModel
+    data:
+    - ["system.management.automation.language.codegeneration!", "Method[escapesinglequotedstringcontent]", "Argument[0]", "ReturnValue", "taint"]
+
   - addsTo:
       pack: microsoft/powershell-all
       extensible: sinkModel

powershell/ql/lib/semmle/code/powershell/frameworks/Microsoft.Win32.RegistryKey.model.yml

@@ -0,0 +1,18 @@
+extensions:
+  - addsTo:
+      pack: microsoft/powershell-all
+      extensible: sourceModel
+    data:
+      - ["system.net.sockets.tcpclient", "Method[getstream].ReturnValue", "remote"]
+      - ["system.net.sockets.udpclient", "Method[endreceive].ReturnValue", "remote"]
+      - ["system.net.sockets.udpclient", "Method[receive].ReturnValue", "remote"]
+      - ["system.net.sockets.udpclient", "Method[receiveasync].ReturnValue", "remote"]
+      - ["system.net.webclient", "Method[downloaddata].ReturnValue", "remote"]
+      - ["system.net.webclient", "Method[downloaddataasync].ReturnValue", "remote"]
+      - ["system.net.webclient", "Method[downloaddatataskasync].ReturnValue", "remote"]
+      - ["system.net.webclient", "Method[downloadfile].ReturnValue", "remote"]
+      - ["system.net.webclient", "Method[downloadfileasync].ReturnValue", "remote"]
+      - ["system.net.webclient", "Method[downloadfiletaskasync].ReturnValue", "remote"]
+      - ["system.net.webclient", "Method[downloadstring].ReturnValue", "remote"]
+      - ["system.net.webclient", "Method[downloadstringasync].ReturnValue", "remote"]
+      - ["system.net.webclient", "Method[downloadstringtaskasync].ReturnValue", "remote"]

powershell/ql/lib/semmle/code/powershell/frameworks/System.Management.Automation.Language.model.yml

@@ -1 +1 @@
-| test.ps1:1:1:18:0 | [synth] pipeline | Unexpected result: type="command line argument" |
+| test.ps1:1:1:20:93 | [synth] pipeline | Unexpected result: type="command line argument" |

…s/System.Management.Automation.model.yml …l/frameworks/System.Management.model.ymlpowershell/ql/lib/semmle/code/powershell/frameworks/System.Management.Automation.model.yml renamed to powershell/ql/lib/semmle/code/powershell/frameworks/System.Management.model.yml powershell/ql/lib/semmle/code/powershell/frameworks/System.Management.Automation.model.yml renamed to powershell/ql/lib/semmle/code/powershell/frameworks/System.Management.model.yml

@@ -15,3 +15,6 @@ $remoteEndpoint2 = $null
 $data2 = $udpClient.Receive([ref]$remoteEndpoint2) # $ type="remote flow source"
 
 $receiveTask = $udpClient.ReceiveAsync() # $ type="remote flow source"
+
+$webclient = [System.Net.WebClient]::new()
+$data = $webclient.DownloadData("https://example.com/data.txt") # $ type="remote flow source"