added lint to samples

Author: eavanvalkenburg

python/.pre-commit-config.yaml

@@ -2,7 +2,6 @@ files: ^python/
 fail_fast: true
 repos:
   - repo: https://github.com/pre-commit/pre-commit-hooks
-    alias: pre-commit-hooks
     rev: v5.0.0
     hooks:
       - id: check-toml
@@ -29,31 +28,27 @@ repos:
         types: ["python"]
         exclude: ^python/packages/lab/cookiecutter-agent-framework-lab/
   - repo: https://github.com/asottile/pyupgrade
-    alias: pyupgrade
     rev: v3.20.0
     hooks:
       - id: pyupgrade
         name: Upgrade Python syntax
         args: [--py310-plus]
         exclude: ^python/packages/lab/cookiecutter-agent-framework-lab/
   - repo: local
-    alias: poe-pre-commit-check
     hooks:
       - id: poe-check
         name: Run checks through Poe
         entry: uv --directory ./python run poe pre-commit-check
         language: system
         files: ^python/
   - repo: https://github.com/PyCQA/bandit
-    alias: bandit
     rev: 1.8.5
     hooks:
       - id: bandit
         name: Bandit Security Checks
         args: ["-c", "python/pyproject.toml"]
         additional_dependencies: ["bandit[toml]"]
   - repo: https://github.com/astral-sh/uv-pre-commit
-    alias: uv-lock
     # uv version.
     rev: 0.7.18
     hooks:

python/pyproject.toml

@@ -225,6 +225,7 @@ test = "python run_tasks_in_packages_if_exists.py test"
 fmt = "python run_tasks_in_packages_if_exists.py fmt"
 format.ref = "fmt"
 lint = "python run_tasks_in_packages_if_exists.py lint"
+samples-lint = "ruff check samples --fix --exclude samples/autogen-migration,samples/semantic-kernel-migration --ignore E501,ASYNC,B901,TD002"
 pyright = "python run_tasks_in_packages_if_exists.py pyright"
 mypy = "python run_tasks_in_packages_if_exists.py mypy"
 samples-syntax = "pyright -p pyrightconfig.samples.json --warnings"
@@ -239,7 +240,7 @@ build-meta = "python -m flit build"
 build = ["build-packages", "build-meta"]
 publish = "uv publish"
 # combined checks
-check = ["fmt", "lint", "pyright", "mypy", "samples-syntax", "test", "markdown-code-lint"]
+check = ["fmt", "lint", "pyright", "mypy", "samples-lint", "samples-syntax", "test", "markdown-code-lint"]
 
 [tool.poe.tasks.all-tests-cov]
 cmd = """
@@ -325,6 +326,7 @@ sequence = [
     { ref = "lint" },
     { ref = "pre-commit-pyright ${files}" },
     { ref = "pre-commit-markdown-code-lint ${files}" },
+    { ref = "samples-lint" },
     { ref = "samples-syntax" }
 ]
 args = [{ name = "files", default = ".", positional = true, multiple = true }]

python/samples/autogen-migration/orchestrations/01_round_robin_group_chat.py

@@ -56,7 +56,7 @@ async def run_autogen() -> None:
 async def run_agent_framework() -> None:
     """Agent Framework's SequentialBuilder for sequential agent orchestration."""
     from agent_framework.openai import OpenAIChatClient
-    from agent_framework_orchestrations import SequentialBuilder
+    from agent_framework.orchestrations import SequentialBuilder
 
     client = OpenAIChatClient(model_id="gpt-4.1-mini")
 

python/samples/concepts/response_stream.py

@@ -237,7 +237,7 @@ async def cleanup_hook() -> None:
     )
 
     print("Starting iteration (cleanup happens after):")
-    async for update in stream4:
+    async for _update in stream4:
         pass  # Just consume the stream
     print(f"Cleanup was performed: {cleanup_performed['value']}")
 

python/samples/demos/chatkit-integration/app.py

@@ -281,7 +281,7 @@ async def _update_thread_title(
 
             title_prompt = [
                 ChatMessage(
-                    role=Role.USER,
+                    role="user",
                     text=(
                         f"Generate a very short, concise title (max 40 characters) for a conversation "
                         f"that starts with:\n\n{conversation_context}\n\n"
@@ -457,7 +457,7 @@ async def action(
             weather_data: WeatherData | None = None
 
             # Create an agent message asking about the weather
-            agent_messages = [ChatMessage(role=Role.USER, text=f"What's the weather in {city_label}?")]
+            agent_messages = [ChatMessage(role="user", text=f"What's the weather in {city_label}?")]
 
             logger.debug(f"Processing weather query: {agent_messages[0].text}")
 
@@ -562,7 +562,7 @@ async def chatkit_endpoint(request: Request):
 
 
 @app.post("/upload/{attachment_id}")
-async def upload_file(attachment_id: str, file: UploadFile = File(...)):
+async def upload_file(attachment_id: str, file: Annotated[UploadFile, File()]):
     """Handle file upload for two-phase upload.
 
     The client POSTs the file bytes here after creating the attachment

python/samples/demos/hosted_agents/agents_in_workflow/main.py

@@ -1,7 +1,7 @@
 # Copyright (c) Microsoft. All rights reserved.
 
-from agent_framework_orchestrations import ConcurrentBuilder
 from agent_framework.azure import AzureOpenAIChatClient
+from agent_framework_orchestrations import ConcurrentBuilder
 from azure.ai.agentserver.agentframework import from_agent_framework
 from azure.identity import DefaultAzureCredential  # pyright: ignore[reportUnknownVariableType]
 

python/samples/demos/workflow_evaluation/_tools.py

@@ -21,7 +21,7 @@ def search_hotels(
     guests: Annotated[int, Field(description="Number of guests.")] = 2,
 ) -> str:
     """Search for available hotels based on location and dates.
-    
+
     Returns:
         JSON string containing search results with hotel details including name, rating,
         price, distance to landmarks, amenities, and availability.
@@ -88,7 +88,7 @@ def get_hotel_details(
     hotel_name: Annotated[str, Field(description="Name of the hotel to get details for.")],
 ) -> str:
     """Get detailed information about a specific hotel.
-    
+
     Returns:
         JSON string containing detailed hotel information including description,
         check-in/out times, cancellation policy, reviews, and nearby attractions.
@@ -167,7 +167,7 @@ def search_flights(
     passengers: Annotated[int, Field(description="Number of passengers.")] = 1,
 ) -> str:
     """Search for available flights between two locations.
-    
+
     Returns:
         JSON string containing flight search results with details including flight numbers,
         airlines, departure/arrival times, prices, durations, and baggage allowances.
@@ -289,7 +289,7 @@ def get_flight_details(
     flight_number: Annotated[str, Field(description="Flight number (e.g., 'AF007' or 'DL264').")],
 ) -> str:
     """Get detailed information about a specific flight.
-    
+
     Returns:
         JSON string containing detailed flight information including airline, aircraft type,
         departure/arrival airports and times, gates, terminals, duration, and amenities.
@@ -331,7 +331,7 @@ def search_activities(
     category: Annotated[str | None, Field(description="Activity category (e.g., 'Sightseeing', 'Culture', 'Culinary').")] = None,
 ) -> str:
     """Search for available activities and attractions at a destination.
-    
+
     Returns:
         JSON string containing activity search results with details including name, category,
         duration, price, rating, description, availability, and booking requirements.
@@ -440,10 +440,7 @@ def search_activities(
             }
         ]
 
-        if category:
-            activities = [act for act in all_activities if act["category"] == category]
-        else:
-            activities = all_activities
+        activities = [act for act in all_activities if act["category"] == category] if category else all_activities
     else:
         activities = [
             {
@@ -473,7 +470,7 @@ def get_activity_details(
     activity_name: Annotated[str, Field(description="Name of the activity to get details for.")],
 ) -> str:
     """Get detailed information about a specific activity.
-    
+
     Returns:
         JSON string containing detailed activity information including description, duration,
         price, included items, meeting point, what to bring, cancellation policy, and reviews.
@@ -552,7 +549,7 @@ def confirm_booking(
     customer_info: Annotated[dict, Field(description="Customer information including name and email.")],
 ) -> str:
     """Confirm a booking reservation.
-    
+
     Returns:
         JSON string containing confirmation details including confirmation number,
         booking status, customer information, and next steps.
@@ -587,9 +584,9 @@ def check_hotel_availability(
     rooms: Annotated[int, Field(description="Number of rooms needed.")] = 1,
 ) -> str:
     """Check availability for hotel rooms.
-    
+
     Sample Date format: "December 15, 2025"
-    
+
     Returns:
         JSON string containing availability status, available rooms count, price per night,
         and last checked timestamp.
@@ -621,9 +618,9 @@ def check_flight_availability(
     passengers: Annotated[int, Field(description="Number of passengers.")] = 1,
 ) -> str:
     """Check availability for flight seats.
-    
+
     Sample Date format: "December 15, 2025"
-    
+
     Returns:
         JSON string containing availability status, available seats count, price per passenger,
         and last checked timestamp.
@@ -654,9 +651,9 @@ def check_activity_availability(
     participants: Annotated[int, Field(description="Number of participants.")] = 1,
 ) -> str:
     """Check availability for activity bookings.
-    
+
     Sample Date format: "December 16, 2025"
-    
+
     Returns:
         JSON string containing availability status, available spots count, price per person,
         and last checked timestamp.
@@ -688,7 +685,7 @@ def process_payment(
     booking_reference: Annotated[str, Field(description="Booking reference number for the payment.")],
 ) -> str:
     """Process payment for a booking.
-    
+
     Returns:
         JSON string containing payment result with transaction ID, status, amount, currency,
         payment method details, and receipt URL.
@@ -718,7 +715,7 @@ def validate_payment_method(
     payment_method: Annotated[dict, Field(description="Payment method to validate (type, number, expiry, cvv).")],
 ) -> str:
     """Validate payment method details.
-    
+
     Returns:
         JSON string containing validation result with is_valid flag, payment method type,
         validation messages, supported currencies, and processing fee information.

python/samples/demos/workflow_evaluation/create_workflow.py

@@ -154,19 +154,19 @@ async def run_workflow_with_response_tracking(query: str, chat_client: AzureAICl
     """
     if chat_client is None:
         try:
-            # Create AIProjectClient with the correct API version for V2 prompt agents
-            project_client = AIProjectClient(
-                endpoint=os.environ["AZURE_AI_PROJECT_ENDPOINT"],
-                credential=credential,
-                api_version="2025-11-15-preview",
-            )
-
-            async with (
-                DefaultAzureCredential() as credential,
-                project_client,
-                AzureAIClient(project_client=project_client, credential=credential) as client,
-            ):
-                return await _run_workflow_with_client(query, client)
+            async with DefaultAzureCredential() as credential:
+                # Create AIProjectClient with the correct API version for V2 prompt agents
+                project_client = AIProjectClient(
+                    endpoint=os.environ["AZURE_AI_PROJECT_ENDPOINT"],
+                    credential=credential,
+                    api_version="2025-11-15-preview",
+                )
+
+                async with (
+                    project_client,
+                    AzureAIClient(project_client=project_client, credential=credential) as client,
+                ):
+                    return await _run_workflow_with_client(query, client)
         except Exception as e:
             print(f"Error during workflow execution: {e}")
             raise
@@ -370,27 +370,36 @@ async def _process_workflow_events(events, conversation_ids, response_ids):
 
 def _track_agent_ids(event, agent, response_ids, conversation_ids):
     """Track agent response and conversation IDs - supporting multiple responses per agent."""
-    if isinstance(event.data, AgentResponseUpdate):
+    if (
+        isinstance(event.data, AgentResponseUpdate)
+        and hasattr(event.data, "raw_representation")
+        and event.data.raw_representation
+    ):
         # Check for conversation_id and response_id from raw_representation
         # V2 API stores conversation_id directly on raw_representation (ChatResponseUpdate)
-        if hasattr(event.data, "raw_representation") and event.data.raw_representation:
-            raw = event.data.raw_representation
-
-            # Try conversation_id directly on raw representation
-            if hasattr(raw, "conversation_id") and raw.conversation_id:  # type: ignore[union-attr]
+        raw = event.data.raw_representation
+
+        # Try conversation_id directly on raw representation
+        if (
+            hasattr(raw, "conversation_id")
+            and raw.conversation_id  # type: ignore[union-attr]
+            and raw.conversation_id not in conversation_ids[agent]  # type: ignore[union-attr]
+        ):
+            # Only add if not already in the list
+            conversation_ids[agent].append(raw.conversation_id)  # type: ignore[union-attr]
+
+        # Extract response_id from the OpenAI event (available from first event)
+        if hasattr(raw, "raw_representation") and raw.raw_representation:  # type: ignore[union-attr]
+            openai_event = raw.raw_representation  # type: ignore[union-attr]
+
+            # Check if event has response object with id
+            if (
+                hasattr(openai_event, "response")
+                and hasattr(openai_event.response, "id")
+                and openai_event.response.id not in response_ids[agent]
+            ):
                 # Only add if not already in the list
-                if raw.conversation_id not in conversation_ids[agent]:  # type: ignore[union-attr]
-                    conversation_ids[agent].append(raw.conversation_id)  # type: ignore[union-attr]
-
-            # Extract response_id from the OpenAI event (available from first event)
-            if hasattr(raw, "raw_representation") and raw.raw_representation:  # type: ignore[union-attr]
-                openai_event = raw.raw_representation  # type: ignore[union-attr]
-
-                # Check if event has response object with id
-                if hasattr(openai_event, "response") and hasattr(openai_event.response, "id"):
-                    # Only add if not already in the list
-                    if openai_event.response.id not in response_ids[agent]:
-                        response_ids[agent].append(openai_event.response.id)
+                response_ids[agent].append(openai_event.response.id)
 
 
 async def create_and_run_workflow():

python/samples/demos/workflow_evaluation/run_evaluation.py

@@ -29,7 +29,7 @@ def print_section(title: str):
 
 async def run_workflow():
     """Execute the multi-agent travel planning workflow.
-    
+
     Returns:
         Dictionary containing workflow data with agent response IDs
     """

python/samples/getting_started/agents/anthropic/anthropic_advanced.py

@@ -2,7 +2,7 @@
 
 import asyncio
 
-from agent_framework import Content, HostedMCPTool, HostedWebSearchTool
+from agent_framework import HostedMCPTool, HostedWebSearchTool
 from agent_framework.anthropic import AnthropicChatOptions, AnthropicClient
 
 """