From ffa395b6e499a97fd224e18ad1037bcfca03e299 Mon Sep 17 00:00:00 2001
From: Ryoichi Iwaida <42270443+riwaida@users.noreply.github.com>
Date: Tue, 6 Aug 2024 14:50:57 +0900
Subject: [PATCH] Update ntdisp.c

Replace IoCreateDevice to IoCreateDeviceSecure. Documentation of IoCreateDevice mentions as follows. This sample is creating a named device object, and it is not specified security descriptor in the INF file. Thus, it should use IoCreateDeviceSecure.
---------------------------
IoCreateDevice can only be used to create an unnamed device object, or a named device object for which a security descriptor is set by an INF file. Otherwise, drivers must use IoCreateDeviceSecure to create named device objects.
---------------------------
---
 network/ndis/ndisprot/6x/sys/ntdisp.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/network/ndis/ndisprot/6x/sys/ntdisp.c b/network/ndis/ndisprot/6x/sys/ntdisp.c
index 21ceeaebb..934739b33 100644
--- a/network/ndis/ndisprot/6x/sys/ntdisp.c
+++ b/network/ndis/ndisprot/6x/sys/ntdisp.c
@@ -89,12 +89,14 @@ Return Value:
         //
         RtlInitUnicodeString(&ntDeviceName, NT_DEVICE_NAME);
 
-        status = IoCreateDevice (pDriverObject,
+        status = IoCreateDeviceSecure (pDriverObject,
                                  0,
                                  &ntDeviceName,
                                  FILE_DEVICE_NETWORK,
                                  FILE_DEVICE_SECURE_OPEN,
                                  FALSE,
+                                 &SDDL_DEVOBJ_SYS_ALL_ADM_ALL,
+                                 NULL,
                                  &deviceObject);
     
         if (!NT_SUCCESS (status))