fix: use Microsoft-Hyper-V feature name on Windows Client SKUs#638
Open
vagokuln-msft wants to merge 1 commit into
Open
fix: use Microsoft-Hyper-V feature name on Windows Client SKUs#638vagokuln-msft wants to merge 1 commit into
vagokuln-msft wants to merge 1 commit into
Conversation
Add-WindowsFeature (ServerManager) uses the feature name "Hyper-V", while Enable-WindowsOptionalFeature (DISM) requires "Microsoft-Hyper-V". On Windows Client SKUs, Get-WindowsFeature is unavailable so Install-Feature falls through to the DISM path, where "Hyper-V" is an unrecognized name and the feature is silently not enabled. This caused `docker run` to fail with: hcs::CreateComputeSystem: The request is not supported. Fix: check which API is available at the call site in Install-ContainerHost and pass the correct feature name to Install-Feature accordingly: - Server SKUs (Get-WindowsFeature available): pass "Hyper-V" - Client SKUs (DISM path): pass "Microsoft-Hyper-V"
Author
|
@copilot Find the right maintainer to tag to get a sign-off for this PR |
Author
|
@AvrumFeldman this is a small, contained fix (CI green) for the Hyper-V |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add-WindowsFeature (ServerManager) uses the feature name "Hyper-V", while Enable-WindowsOptionalFeature (DISM) requires "Microsoft-Hyper-V". On Windows Client SKUs, Get-WindowsFeature is unavailable so Install-Feature falls through to the DISM path, where "Hyper-V" is an unrecognized name and the feature is silently not enabled.
This caused
docker runto fail with:hcs::CreateComputeSystem: The request is not supported.
Fix: check which API is available at the call site in Install-ContainerHost and pass the correct feature name to Install-Feature accordingly: