fix(61867): fix find-all-refs for constructors involving string literals

Author: a-tarasyuk

src/services/findAllReferences.ts

@@ -1838,13 +1838,13 @@ export namespace Core {
             case SyntaxKind.NoSubstitutionTemplateLiteral:
             case SyntaxKind.StringLiteral: {
                 const str = node as StringLiteralLike;
-                return str.text.length === searchSymbolName.length && (
+                return (
                     isLiteralNameOfPropertyDeclarationOrIndexAccess(str) ||
                     isNameOfModuleDeclaration(node) ||
                     isExpressionOfExternalModuleImportEqualsDeclaration(node) ||
                     (isCallExpression(node.parent) && isBindableObjectDefinePropertyCall(node.parent) && node.parent.arguments[1] === node) ||
                     isImportOrExportSpecifier(node.parent)
-                );
+                ) && str.text.length === searchSymbolName.length;
             }
 
             case SyntaxKind.NumericLiteral:

tests/baselines/reference/findAllRefsConstructor.baseline.jsonc

@@ -0,0 +1,82 @@
+// === findAllReferences ===
+// === lib.d.ts ===
+// --- (line: --) skipped ---
+// 
+// interface Object {
+//     /** The initial value of Object.prototype.constructor is the standard built-in Object constructor. */
+//     <|[|{| isWriteAccess: true |}constructor|]: Function;|>
+// 
+//     /** Returns a string representation of an object. */
+//     toString(): string;
+// --- (line: --) skipped ---
+
+// === /tests/cases/fourslash/findAllRefsConstructor.ts ===
+// class A {
+//   'constructor'() { }
+// }
+// const a = new A()
+// console.log(a.[|constructor|]/*FIND ALL REFS*/)
+
+  // === Definitions ===
+  // === lib.d.ts ===
+  // --- (line: --) skipped ---
+  // 
+  // interface Object {
+  //     /** The initial value of Object.prototype.constructor is the standard built-in Object constructor. */
+  //     <|[|constructor|]: Function;|>
+  // 
+  //     /** Returns a string representation of an object. */
+  //     toString(): string;
+  // --- (line: --) skipped ---
+
+  // === Details ===
+  [
+   {
+    "containerKind": "",
+    "containerName": "",
+    "kind": "property",
+    "name": "(property) Object.constructor: Function",
+    "displayParts": [
+     {
+      "text": "(",
+      "kind": "punctuation"
+     },
+     {
+      "text": "property",
+      "kind": "text"
+     },
+     {
+      "text": ")",
+      "kind": "punctuation"
+     },
+     {
+      "text": " ",
+      "kind": "space"
+     },
+     {
+      "text": "Object",
+      "kind": "localName"
+     },
+     {
+      "text": ".",
+      "kind": "punctuation"
+     },
+     {
+      "text": "constructor",
+      "kind": "propertyName"
+     },
+     {
+      "text": ":",
+      "kind": "punctuation"
+     },
+     {
+      "text": " ",
+      "kind": "space"
+     },
+     {
+      "text": "Function",
+      "kind": "localName"
+     }
+    ]
+   }
+  ]

tests/cases/fourslash/findAllRefsConstructor.ts

@@ -0,0 +1,10 @@
+/// <reference path="fourslash.ts" />
+// @target: esnext
+
+////class A {
+////  'constructor'() { }
+////}
+////const a = new A()
+////console.log(a.constructor/**/)
+
+verify.baselineFindAllReferences('');