Skip to content

Commit e382fea

Browse files
committed
Remove unnecessary timeout running added during wip to ensure catching all updates
1 parent 91a4483 commit e382fea

6 files changed

+0
-62
lines changed

src/testRunner/unittests/tsserver/typeAquisition.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,6 @@ describe("unittests:: tsserver:: typeAquisition:: changes", () => {
8080
host.runPendingInstalls();
8181
host.runQueuedTimeoutCallbacks(); // First project upate after typings are installed
8282
host.runQueuedTimeoutCallbacks(); // Update scheduled after the typings from unresolved imports are discovered again
83-
host.runQueuedTimeoutCallbacks();
8483
disableTypeAcquisition();
8584
host.runQueuedTimeoutCallbacks();
8685
verifyEnabledTypeAcquisition();
@@ -107,7 +106,6 @@ describe("unittests:: tsserver:: typeAquisition:: changes", () => {
107106
disableTypeAcquisition();
108107
host.runQueuedTimeoutCallbacks(); // Update project
109108
host.runPendingInstalls();
110-
host.runQueuedTimeoutCallbacks();
111109
verifyEnabledTypeAcquisition();
112110
baselineTsserverLogs("typeAquisition", "receives update of typings after project changes", session);
113111
});
@@ -120,8 +118,6 @@ describe("unittests:: tsserver:: typeAquisition:: changes", () => {
120118
verifyEnabledTypeAcquisition();
121119
host.runPendingInstalls();
122120
host.runQueuedTimeoutCallbacks();
123-
host.runQueuedTimeoutCallbacks();
124-
host.runQueuedTimeoutCallbacks();
125121
baselineTsserverLogs("typeAquisition", "change after enabling typeAquisition", session);
126122
});
127123

@@ -167,8 +163,6 @@ describe("unittests:: tsserver:: typeAquisition:: changes", () => {
167163
function verifyEnabledTypeAcquisition() {
168164
typeAcquisition(/*enable*/ true);
169165
host.runQueuedTimeoutCallbacks();
170-
host.runQueuedTimeoutCallbacks();
171-
host.runQueuedTimeoutCallbacks();
172166
}
173167

174168
function disableTypeAcquisition() {

tests/baselines/reference/tsserver/typeAquisition/change-after-enabling-typeAquisition.js

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -695,26 +695,10 @@ Projects::
695695
projectStateVersion: 2
696696
projectProgramVersion: 2 *changed*
697697

698-
Before running Timeout callback:: count: 0
699-
700-
After running Timeout callback:: count: 0
701-
702-
Before running Timeout callback:: count: 0
703-
704-
After running Timeout callback:: count: 0
705-
706698
Before running PendingInstalls callback:: count: 0
707699

708700
After running PendingInstalls callback:: count: 0
709701

710702
Before running Timeout callback:: count: 0
711703

712704
After running Timeout callback:: count: 0
713-
714-
Before running Timeout callback:: count: 0
715-
716-
After running Timeout callback:: count: 0
717-
718-
Before running Timeout callback:: count: 0
719-
720-
After running Timeout callback:: count: 0

tests/baselines/reference/tsserver/typeAquisition/changes-to-typeAquisition-when-typing-installer-installs-typing.js

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -776,10 +776,6 @@ Info seq [hh:mm:ss:mss] event:
776776
}
777777
After running Timeout callback:: count: 0
778778
779-
Before running Timeout callback:: count: 0
780-
781-
After running Timeout callback:: count: 0
782-
783779
Info seq [hh:mm:ss:mss] FileWatcher:: Triggered with /users/user/projects/project1/jsconfig.json 1:: WatchInfo: /users/user/projects/project1/jsconfig.json 2000 undefined Project: /users/user/projects/project1/jsconfig.json WatchType: Config file
784780
Info seq [hh:mm:ss:mss] Scheduled: /users/user/projects/project1/jsconfig.json
785781
Info seq [hh:mm:ss:mss] getConfigFileNameForFile:: File: /users/user/projects/project1/app.js ProjectRootPath: undefined:: Result: /users/user/projects/project1/jsconfig.json
@@ -1374,11 +1370,3 @@ ScriptInfos::
13741370
version: Text-1
13751371
containingProjects: 1 *changed*
13761372
/users/user/projects/project1/jsconfig.json *new*
1377-
1378-
Before running Timeout callback:: count: 0
1379-
1380-
After running Timeout callback:: count: 0
1381-
1382-
Before running Timeout callback:: count: 0
1383-
1384-
After running Timeout callback:: count: 0

tests/baselines/reference/tsserver/typeAquisition/changes-to-typeAquisition-with-already-aquired-typing.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1058,11 +1058,3 @@ ScriptInfos::
10581058
version: Text-1
10591059
containingProjects: 1 *changed*
10601060
/users/user/projects/project1/jsconfig.json *new*
1061-
1062-
Before running Timeout callback:: count: 0
1063-
1064-
After running Timeout callback:: count: 0
1065-
1066-
Before running Timeout callback:: count: 0
1067-
1068-
After running Timeout callback:: count: 0

tests/baselines/reference/tsserver/typeAquisition/midway-changes-to-typeAquisition-when-typing-installer-installs-typing.js

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1093,11 +1093,3 @@ ScriptInfos::
10931093
version: Text-1
10941094
containingProjects: 1
10951095
/users/user/projects/project1/jsconfig.json
1096-
1097-
Before running Timeout callback:: count: 0
1098-
1099-
After running Timeout callback:: count: 0
1100-
1101-
Before running Timeout callback:: count: 0
1102-
1103-
After running Timeout callback:: count: 0

tests/baselines/reference/tsserver/typeAquisition/receives-update-of-typings-after-project-changes.js

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -743,10 +743,6 @@ Info seq [hh:mm:ss:mss] event:
743743
}
744744
After running PendingInstalls callback:: count: 0
745745
746-
Before running Timeout callback:: count: 0
747-
748-
After running Timeout callback:: count: 0
749-
750746
Info seq [hh:mm:ss:mss] FileWatcher:: Triggered with /users/user/projects/project1/jsconfig.json 1:: WatchInfo: /users/user/projects/project1/jsconfig.json 2000 undefined Project: /users/user/projects/project1/jsconfig.json WatchType: Config file
751747
Info seq [hh:mm:ss:mss] Scheduled: /users/user/projects/project1/jsconfig.json
752748
Info seq [hh:mm:ss:mss] getConfigFileNameForFile:: File: /users/user/projects/project1/app.js ProjectRootPath: undefined:: Result: /users/user/projects/project1/jsconfig.json
@@ -1089,11 +1085,3 @@ ScriptInfos::
10891085
version: Text-1
10901086
containingProjects: 1
10911087
/users/user/projects/project1/jsconfig.json
1092-
1093-
Before running Timeout callback:: count: 0
1094-
1095-
After running Timeout callback:: count: 0
1096-
1097-
Before running Timeout callback:: count: 0
1098-
1099-
After running Timeout callback:: count: 0

0 commit comments

Comments
 (0)