Merge pull request #2473 from melnikvitaly/main

fix: missing examples when one example is with an empty array.

Author: baywet

src/Microsoft.OpenApi/Models/OpenApiExample.cs

@@ -70,7 +70,10 @@ private void SerializeInternal(IOpenApiWriter writer, OpenApiSpecVersion version
             writer.WriteProperty(OpenApiConstants.Description, Description);
 
             // value
-            writer.WriteOptionalObject(OpenApiConstants.Value, Value, (w, v) => w.WriteAny(v));
+            if (Value is not null)
+            {
+                writer.WriteRequiredObject(OpenApiConstants.Value, Value, (w, v) => w.WriteAny(v));    
+            }
 
             // externalValue
             writer.WriteProperty(OpenApiConstants.ExternalValue, ExternalValue);

src/Microsoft.OpenApi/Models/OpenApiMediaType.cs

@@ -95,7 +95,7 @@ private void SerializeInternal(IOpenApiWriter writer, OpenApiSpecVersion version
             // examples
             if (Examples != null && Examples.Any())
             {
-                SerializeExamples(writer, Examples, callback);
+                writer.WriteOptionalMap(OpenApiConstants.Examples, Examples, callback);
             }
 
             // encoding
@@ -114,33 +114,5 @@ public virtual void SerializeAsV2(IOpenApiWriter writer)
         {
             // Media type does not exist in V2.
         }
-
-        private static void SerializeExamples(IOpenApiWriter writer, IDictionary<string, IOpenApiExample> examples, Action<IOpenApiWriter, IOpenApiSerializable> callback)
-        {
-            /* Special case for writing out empty arrays as valid response examples
-            * Check if there is any example with an empty array as its value and set the flag `hasEmptyArray` to true
-            * */
-            var hasEmptyArray = examples.Values.Any( static example =>
-                example.Value is JsonArray arr && arr.Count == 0
-            );
-
-            if (hasEmptyArray)
-            {
-                writer.WritePropertyName(OpenApiConstants.Examples);
-                writer.WriteStartObject();
-                foreach (var kvp in examples.Where(static kvp => kvp.Value.Value is JsonArray arr && arr.Count == 0))
-                {
-                    writer.WritePropertyName(kvp.Key);
-                    writer.WriteStartObject();
-                    writer.WriteRequiredObject(OpenApiConstants.Value, kvp.Value.Value, (w, v) => w.WriteAny(v));
-                    writer.WriteEndObject();
-                }
-                writer.WriteEndObject();
-            }
-            else
-            {
-                writer.WriteOptionalMap(OpenApiConstants.Examples, examples, callback);
-            }
-        }
     }
 }

test/Microsoft.OpenApi.Readers.Tests/V3Tests/OpenApiMediaTypeTests.cs

@@ -87,7 +87,16 @@ public async Task ParseMediaTypeWithEmptyArrayInExamplesWorks()
   },
   ""examples"": {
     ""Success response - no results"": {
+      ""summary"": ""empty array summary"",
+      ""description"": ""empty array description"",
       ""value"": [ ]
+    },
+    ""Success response - with results"": {
+      ""summary"": ""array summary"",
+      ""description"": ""array description"",
+      ""value"": [ 
+        1
+      ]
     }
   }
 }

test/Microsoft.OpenApi.Readers.Tests/V3Tests/Samples/OpenApiMediaType/examplesWithEmptyArray.json

@@ -12,7 +12,14 @@
   },
   "examples": {
     "Success response - no results": {
+      "summary": "empty array summary",
+      "description": "empty array description",
       "value": []
+    },
+    "Success response - with results": {
+      "summary": "array summary",
+      "description": "array description",
+      "value": [ 1 ]
     }
   }
 }