chore(reader): normalize JsonNode variable casing

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Author: baywet

src/Microsoft.OpenApi/Interfaces/IOpenApiVersionService.cs

@@ -25,18 +25,18 @@ internal interface IOpenApiVersionService
         /// <summary>
         /// Converts a generic JsonNode instance into a strongly typed OpenApiDocument
         /// </summary>
-        /// <param name="JsonNode">JsonNode containing the information to be converted into an OpenAPI Document</param>
+        /// <param name="jsonNode">JsonNode containing the information to be converted into an OpenAPI Document</param>
         /// <param name="location">Location of where the document that is getting loaded is saved</param>
         /// <param name="context">The current parsing context.</param>
         /// <returns>Instance of OpenApiDocument populated with data from JsonNode</returns>
-        OpenApiDocument LoadDocument(JsonNode JsonNode, Uri location, ParsingContext context);
+        OpenApiDocument LoadDocument(JsonNode jsonNode, Uri location, ParsingContext context);
 
         /// <summary>
         /// Gets the description and summary scalar values in a reference object for V3.1 support
         /// </summary>
-        /// <param name="JsonObject">A Json object.</param>
+        /// <param name="jsonObject">A Json object.</param>
         /// <param name="scalarValue">The scalar value we're parsing.</param>
         /// <returns>The resulting node value.</returns>
-        string? GetReferenceScalarValues(JsonObject JsonObject, string scalarValue);
+        string? GetReferenceScalarValues(JsonObject jsonObject, string scalarValue);
     }
 }

src/Microsoft.OpenApi/Models/BaseOpenApiReference.cs

@@ -302,7 +302,7 @@ internal void EnsureHostDocumentIsSet(OpenApiDocument currentDocument)
         /// <param name="key">The key of the property</param>
         /// <returns>The property value</returns>
         protected internal static string? GetPropertyValueFromNode(JsonObject jsonObject, string key) =>
-        jsonObject.TryGetPropertyValue(key, out var JsonNode) && JsonNode is JsonValue valueCast && valueCast.TryGetValue<string>(out var strValue) ? strValue : null;
+        jsonObject.TryGetPropertyValue(key, out var jsonNode) && jsonNode is JsonValue valueCast && valueCast.TryGetValue<string>(out var strValue) ? strValue : null;
         internal virtual void SetMetadataFromJsonObject(JsonObject jsonObject)
         {
             SetAdditional31MetadataFromMapNode(jsonObject);

src/Microsoft.OpenApi/Reader/BaseOpenApiVersionService.cs

@@ -19,7 +19,7 @@ protected BaseOpenApiVersionService(OpenApiDiagnostic diagnostic)
 
     internal abstract Dictionary<Type, Func<JsonNode, OpenApiDocument, ParsingContext, object?>> Loaders { get; }
 
-    public abstract OpenApiDocument LoadDocument(JsonNode JsonNode, Uri location, ParsingContext context);
+    public abstract OpenApiDocument LoadDocument(JsonNode jsonNode, Uri location, ParsingContext context);
 
     public T? LoadElement<T>(JsonNode node, OpenApiDocument doc, ParsingContext context) where T : IOpenApiElement
     {
@@ -29,15 +29,15 @@ protected BaseOpenApiVersionService(OpenApiDiagnostic diagnostic)
         }
         return default;
     }
-    public virtual string? GetReferenceScalarValues(JsonObject JsonObject, string scalarValue)
+    public virtual string? GetReferenceScalarValues(JsonObject jsonObject, string scalarValue)
     {
-        if (JsonObject.Any(static x => !"$ref".Equals(x.Key, StringComparison.OrdinalIgnoreCase)) &&
-            JsonObject
+        if (jsonObject.Any(static x => !"$ref".Equals(x.Key, StringComparison.OrdinalIgnoreCase)) &&
+            jsonObject
             .Where(x => x.Key.Equals(scalarValue))
             .Select(static x => x.Value)
-            .OfType<JsonValue>().FirstOrDefault() is {} JsonNode)
+            .OfType<JsonValue>().FirstOrDefault() is {} jsonNode)
         {
-            return JsonNode.GetScalarValue();
+            return jsonNode.GetScalarValue();
         }
 
         return null;

src/Microsoft.OpenApi/Reader/JsonNodeHelper.cs

@@ -13,12 +13,12 @@ internal static class JsonNodeHelper
     {
         public static JsonObject CheckMapNode(this JsonNode? node, string nodeName, ParsingContext context)
         {
-            if (node is not JsonObject JsonObject)
+            if (node is not JsonObject jsonObject)
             {
                 throw new OpenApiReaderException($"{nodeName} must be a map/object", context);
             }
 
-            return JsonObject;
+            return jsonObject;
         }
 
         public static List<T> CreateList<T>(this JsonNode? node, Func<JsonNode, OpenApiDocument, ParsingContext, T> map, OpenApiDocument hostDocument, ParsingContext context)

src/Microsoft.OpenApi/Reader/ParseNodes/FixedFieldMap.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation. All rights reserved.
+// Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT license.
 
 using System;

src/Microsoft.OpenApi/Reader/ParseNodes/PatternFieldMap.cs

@@ -1,4 +1,4 @@
-// Copyright (c) Microsoft Corporation. All rights reserved.
+// Copyright (c) Microsoft Corporation. All rights reserved.
 // Licensed under the MIT license.
 
 using System;

src/Microsoft.OpenApi/Reader/ParsingContext.cs

@@ -140,17 +140,17 @@ public OpenApiDocument Parse(JsonNode jsonNode, Uri location)
         /// <summary>
         /// Gets the version of the Open API document.
         /// </summary>
-        private static string GetVersion(JsonNode JsonNode)
+        private static string GetVersion(JsonNode jsonNode)
         {
-            var versionNode = new JsonPointer("/openapi").Find(JsonNode);
+            var versionNode = new JsonPointer("/openapi").Find(jsonNode);
 
             if (versionNode is not null)
             {
                 return versionNode.GetScalarValue()?.Replace("\"", string.Empty)
                     ?? throw new OpenApiException("Version node not found.");
             }
 
-            versionNode = new JsonPointer("/swagger").Find(JsonNode);
+            versionNode = new JsonPointer("/swagger").Find(jsonNode);
 
             return versionNode?.GetScalarValue()?.Replace("\"", string.Empty) ?? throw new OpenApiException("Version node not found.");
         }

src/Microsoft.OpenApi/Reader/V2/OpenApiContactDeserializer.cs

@@ -43,10 +43,10 @@ internal static partial class OpenApiV2Deserializer
 
         public static OpenApiContact LoadContact(JsonNode node, OpenApiDocument hostDocument, ParsingContext context)
         {
-            var JsonObject = node as JsonObject;
+            var jsonObject = node as JsonObject;
             var contact = new OpenApiContact();
 
-            ParseMap(JsonObject, contact, _contactFixedFields, _contactPatternFields, hostDocument, context);
+            ParseMap(jsonObject, contact, _contactFixedFields, _contactPatternFields, hostDocument, context);
 
             return contact;
         }

src/Microsoft.OpenApi/Reader/V2/OpenApiDocumentDeserializer.cs

@@ -114,7 +114,7 @@ internal static partial class OpenApiV2Deserializer
             {s => s.StartsWith(OpenApiConstants.ExtensionFieldNamePrefix, StringComparison.OrdinalIgnoreCase), (o, p, n, _, c) => o.AddExtension(p, LoadExtension(p, n, c))}
         };
 
-        private static void MakeServers(IList<OpenApiServer> servers, ParsingContext context, JsonNode JsonNode)
+        private static void MakeServers(IList<OpenApiServer> servers, ParsingContext context, JsonNode jsonNode)
         {
             var host = context.GetFromTempStorage<string>("host");
             var basePath = context.GetFromTempStorage<string>("basePath");
@@ -231,14 +231,14 @@ private static string BuildUrl(string? scheme, string? host, string? basePath)
             return uriBuilder.ToString();
         }
 
-        public static OpenApiDocument LoadOpenApi(JsonNode JsonNode, Uri location, ParsingContext context)
+        public static OpenApiDocument LoadOpenApi(JsonNode jsonNode, Uri location, ParsingContext context)
         {
             var openApiDoc = new OpenApiDocument
             {
                 BaseUri = location
             };
 
-            var openApiNode = JsonNode.CheckMapNode("OpenAPI", context);
+            var openApiNode = jsonNode.CheckMapNode("OpenAPI", context);
 
             ParseMap(openApiNode, openApiDoc, _openApiFixedFields, _openApiPatternFields, openApiDoc, context);
 
@@ -259,7 +259,7 @@ public static OpenApiDocument LoadOpenApi(JsonNode JsonNode, Uri location, Parsi
                 openApiDoc.Servers = [];
             }
 
-            MakeServers(openApiDoc.Servers, context, JsonNode);
+            MakeServers(openApiDoc.Servers, context, jsonNode);
 
             FixRequestBodyReferences(openApiDoc);
 

src/Microsoft.OpenApi/Reader/V2/OpenApiExternalDocsDeserializer.cs

@@ -48,11 +48,11 @@ internal static partial class OpenApiV2Deserializer
 
         public static OpenApiExternalDocs LoadExternalDocs(JsonNode node, OpenApiDocument hostDocument, ParsingContext context)
         {
-            var JsonObject = node.CheckMapNode("externalDocs", context);
+            var jsonObject = node.CheckMapNode("externalDocs", context);
 
             var externalDocs = new OpenApiExternalDocs();
 
-            ParseMap(JsonObject, externalDocs, _externalDocsFixedFields, _externalDocsPatternFields, hostDocument, context);
+            ParseMap(jsonObject, externalDocs, _externalDocsFixedFields, _externalDocsPatternFields, hostDocument, context);
 
             return externalDocs;
         }