chore: removes passing reference to document across workflow

Author: baywet

src/Microsoft.OpenApi.OData.Reader/Common/EdmModelHelper.cs

@@ -23,7 +23,7 @@ internal static class EdmModelHelper
         /// Adds the derived types references together with their base type reference in the OneOf property of an OpenAPI schema.
         /// </summary>
         /// <returns>The OpenAPI schema with the list of derived types references and their base type references set in the OneOf property.</returns>
-        internal static OpenApiSchema GetDerivedTypesReferenceSchema(IEdmStructuredType structuredType, IEdmModel edmModel, OpenApiDocument document)
+        internal static OpenApiSchema GetDerivedTypesReferenceSchema(IEdmStructuredType structuredType, IEdmModel edmModel)
         {
             Utils.CheckArgumentNull(structuredType, nameof(structuredType));
             Utils.CheckArgumentNull(edmModel, nameof(edmModel));
@@ -41,12 +41,12 @@ internal static OpenApiSchema GetDerivedTypesReferenceSchema(IEdmStructuredType
                 OneOf = new List<IOpenApiSchema>()
             };
 
-            var baseTypeSchema = new OpenApiSchemaReference(schemaElement.FullName(), document);
+            var baseTypeSchema = new OpenApiSchemaReference(schemaElement.FullName());
             schema.OneOf.Add(baseTypeSchema);
 
             foreach (IEdmSchemaElement derivedType in derivedTypes)
             {
-                var derivedTypeSchema = new OpenApiSchemaReference(derivedType.FullName(), document);
+                var derivedTypeSchema = new OpenApiSchemaReference(derivedType.FullName());
                 schema.OneOf.Add(derivedTypeSchema);
             };
 

src/Microsoft.OpenApi.OData.Reader/Common/OpenApiOperationExtensions.cs

@@ -23,12 +23,10 @@ internal static class OpenApiOperationExtensions
     /// <param name="settings">The settings.</param>
     /// <param name="addNoContent">Optional: Whether to add a 204 no content response.</param>
     /// <param name="schema">Optional: The OpenAPI schema of the response.</param>
-    /// <param name="document">The OpenAPI document to lookup references.</param>
-    public static void AddErrorResponses(this OpenApiOperation operation, OpenApiConvertSettings settings, OpenApiDocument document, bool addNoContent = false, IOpenApiSchema schema = null)
+    public static void AddErrorResponses(this OpenApiOperation operation, OpenApiConvertSettings settings, bool addNoContent = false, IOpenApiSchema schema = null)
     {
         Utils.CheckArgumentNull(operation, nameof(operation));
         Utils.CheckArgumentNull(settings, nameof(settings));
-        Utils.CheckArgumentNull(document, nameof(document));
 
 		if (operation.Responses == null)
 		{
@@ -57,22 +55,22 @@ public static void AddErrorResponses(this OpenApiOperation operation, OpenApiCon
                         }
                     };
                 }
-                operation.Responses.Add(Constants.StatusCodeClass2XX, response ?? Constants.StatusCodeClass2XX.GetResponse(document));
+                operation.Responses.Add(Constants.StatusCodeClass2XX, response ?? Constants.StatusCodeClass2XX.GetResponse());
             }
             else
             {
-                operation.Responses.Add(Constants.StatusCode204, Constants.StatusCode204.GetResponse(document));
+                operation.Responses.Add(Constants.StatusCode204, Constants.StatusCode204.GetResponse());
             }
         }
 
         if (settings.ErrorResponsesAsDefault)
         {
-            operation.Responses.Add(Constants.StatusCodeDefault, Constants.StatusCodeDefault.GetResponse(document));
+            operation.Responses.Add(Constants.StatusCodeDefault, Constants.StatusCodeDefault.GetResponse());
         }
         else
         {
-			operation.Responses.Add(Constants.StatusCodeClass4XX, Constants.StatusCodeClass4XX.GetResponse(document));
-			operation.Responses.Add(Constants.StatusCodeClass5XX, Constants.StatusCodeClass5XX.GetResponse(document));
+			operation.Responses.Add(Constants.StatusCodeClass4XX, Constants.StatusCodeClass4XX.GetResponse());
+			operation.Responses.Add(Constants.StatusCodeClass5XX, Constants.StatusCodeClass5XX.GetResponse());
         }
     }
 }

src/Microsoft.OpenApi.OData.Reader/Edm/ODataContext.cs

@@ -50,8 +50,8 @@ public ODataContext(IEdmModel model, OpenApiConvertSettings settings)
             visitor.Visit(model);
             IsSpatialTypeUsed = visitor.IsSpatialTypeUsed;
 
-            OperationHandlerProvider = new OperationHandlerProvider();
-            PathItemHandlerProvider = new PathItemHandlerProvider();
+            OperationHandlerProvider = new CachedOperationHandlerProvider(new OperationHandlerProvider());
+            PathItemHandlerProvider = new CachedPathItemHandlerProvider(new PathItemHandlerProvider());
 
             // If no path provider, use the default path provider.
             _pathProvider = settings.PathProvider ?? new ODataPathProvider();

src/Microsoft.OpenApi.OData.Reader/Generator/OpenApiDocumentGenerator.cs

@@ -46,6 +46,8 @@ public static OpenApiDocument CreateDocument(this ODataContext context)
             context.AddComponentsToDocument(doc);
             context.AddPathsToDocument(doc);
             doc.Tags = context.CreateTags(); // order matters so the operation generators have populated the tags
+            doc.RegisterComponents();
+            doc.SetReferenceHostDocument();
 
 
             return doc;