Skip to content

Commit 8545343

Browse files
committed
small changes
1 parent 5383a72 commit 8545343

File tree

5 files changed

+17
-18
lines changed

5 files changed

+17
-18
lines changed

_run-druid.sh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ source "$SOURCE_DIR/env-druid.sh"
77
source "$SOURCE_DIR/common.sh"
88

99
kill-existing ${CONTAINER_NAME}
10+
1011
docker run \
1112
-p ${WEB_PORT}:8081 \
1213
-p ${HOST_PORT}:8082 \

_run-postgres.sh

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -6,35 +6,35 @@ source "$SOURCE_DIR/env-postgres.sh"
66

77
source "$SOURCE_DIR/common.sh"
88

9-
DATA_DIR=$HOME/metabase-pgsql-${PG_VERSION}-data
9+
DATA_DIR=${HOME}/metabase-pgsql-${PG_VERSION}-data
1010
DOCKER_NETWORK=psql-metabase-network
1111

1212
kill-existing ${CONTAINER_NAME}
13-
create-network-if-needed $DOCKER_NETWORK
13+
create-network-if-needed ${DOCKER_NETWORK}
1414

1515
docker run \
1616
--rm \
1717
-d \
18-
-p $HOST_PORT:5432 \
19-
--network $DOCKER_NETWORK \
20-
-e POSTGRES_USER=$DB_USER \
21-
-e POSTGRES_DB=$DB_NAME \
22-
-e POSTGRES_PASSWORD=$DB_PASSWORD \
18+
-p ${HOST_PORT}:5432 \
19+
--network ${DOCKER_NETWORK} \
20+
-e POSTGRES_USER=${DB_USER} \
21+
-e POSTGRES_DB=${DB_NAME} \
22+
-e POSTGRES_PASSWORD=${DB_PASSWORD} \
2323
-e PGDATA=/var/lib/postgresql/data \
24-
-v $DATA_DIR:/var/lib/postgresql/data:Z \
25-
--name $CONTAINER_NAME \
24+
-v ${DATA_DIR}:/var/lib/postgresql/data:Z \
25+
--name ${CONTAINER_NAME} \
2626
postgres:${PG_VERSION}
2727

2828
cat << EOF
2929
30-
Started PostgreSQL ${PG_VERSION} on port $HOST_PORT via Docker (container name: $CONTAINER_NAME).
31-
Data will be persisted in $DATA_DIR on the host machine (delete it to reset).
30+
Started PostgreSQL ${PG_VERSION} on port ${HOST_PORT} via Docker (container name: ${CONTAINER_NAME}).
31+
Data will be persisted in ${DATA_DIR} on the host machine (delete it to reset).
3232
3333
To open a SQL client session:
34-
docker run -it --rm --network $DOCKER_NETWORK postgres:${PG_VERSION} psql -h $CONTAINER_NAME -U $DB_USER
35-
And enter the DB user password for $DB_USER: $DB_PASSWORD
34+
docker run -it --rm --network ${DOCKER_NETWORK} postgres:${PG_VERSION} psql -h ${CONTAINER_NAME} -U ${DB_USER}
35+
And enter the DB user password for ${DB_USER}: ${DB_PASSWORD}
3636
37-
JDBC URL: jdbc:postgres://localhost:$HOST_PORT/$DB_NAME?user=$DB_USER
37+
JDBC URL: jdbc:postgres://localhost:${HOST_PORT}/${DB_NAME}?user=${DB_USER}
3838
3939
EOF
4040

_run-presto.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ also have the JAVA_HOME env var set for this all to work.
4343
Finally, this can be made available to Metabase by adding the following JVM args when starting:
4444
4545
-Djavax.net.ssl.trustStore=$MODIFIED_CACERTS_FILE -Djavax.net.ssl.trustStorePassword=changeit
46-
46+
4747
EOF
4848

4949
print-presto-vars

_run-sparksql.sh

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,5 @@
11
#! /usr/bin/env bash
22

3-
set -euo pipefail
4-
53
SOURCE_DIR=`dirname "${BASH_SOURCE[0]}"`
64

75
source "$SOURCE_DIR/env-sparksql.sh"

_run-vertica.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ cat <<EOF
2424
2525
Started Vertica ${VERTICA_VERSION} on port ${HOST_PORT}.
2626
27-
JDBC URL: "jdbc:vertica://localhost:${HOST_PORT}/${DB_NAME}?user=${DB_USER}"
27+
JDBC URL: jdbc:vertica://localhost:${HOST_PORT}/${DB_NAME}?user=${DB_USER}
2828
2929
EOF
3030

0 commit comments

Comments
 (0)