Better assert when TestDelayedEvents/delayed_state_events_are_kept_on_server_restart take too long to run for our assumptions to be correct (#829)

Author: MadLittleMods

tests/msc4140/delayed_event_test.go

@@ -453,6 +453,7 @@ func TestDelayedEvents(t *testing.T) {
 			client.WithJSONBody(t, map[string]interface{}{}),
 			getDelayQueryParam("900"),
 		)
+		beforeScheduleStateTimestamp2 := time.Now()
 		user.MustDo(
 			t,
 			"PUT",
@@ -466,6 +467,15 @@ func TestDelayedEvents(t *testing.T) {
 		time.Sleep(1 * time.Second)
 		deployment.StartServer(t, hsName)
 
+		// The rest of the test assumes the second delayed event (10 second delay) still
+		// hasn't been sent yet.
+		if time.Now().Sub(beforeScheduleStateTimestamp2) > 10*time.Second {
+			t.Fatalf(
+				"Test took too long to run, cannot guarantee delayed event timings. " +
+					"More than 10 seconds elapsed between scheduling the delayed event and now when we're about to check for it.",
+			)
+		}
+
 		matchDelayedEvents(t, user, 1)
 		user.MustDo(t, "GET", getPathForState(roomID, eventType, stateKey1))