From eb5cd290aa93aa64f8e2ea8a50ee582cd7153c79 Mon Sep 17 00:00:00 2001 From: Johan Larsson Date: Tue, 29 Apr 2025 11:15:07 +0200 Subject: [PATCH 1/3] fix: wrap `data_home` in `Path()` Closes #39 --- libsvmdata/abstraction.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libsvmdata/abstraction.py b/libsvmdata/abstraction.py index cefc30d..a760057 100644 --- a/libsvmdata/abstraction.py +++ b/libsvmdata/abstraction.py @@ -18,7 +18,9 @@ def _get_data_home(subdir_name=""): data_home = os.environ.get("XDG_DATA_HOME", None) if data_home is None: data_home = Path.home() / "data" - return data_home / subdir_name + else: + data_home = Path(data_home) + return data_home / subdir_name if subdir_name else data_home class AbstractDataset(ABC): From d55984faf990d0381406e413e87197aa77824434 Mon Sep 17 00:00:00 2001 From: Johan Larsson Date: Tue, 29 Apr 2025 11:55:28 +0200 Subject: [PATCH 2/3] fixup! fix: wrap `data_home` in `Path()` --- libsvmdata/abstraction.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libsvmdata/abstraction.py b/libsvmdata/abstraction.py index a760057..25a0201 100644 --- a/libsvmdata/abstraction.py +++ b/libsvmdata/abstraction.py @@ -14,12 +14,14 @@ def _get_data_home(subdir_name=""): seek for the variable $XDG_DATA_HOME. Finally, the fallback is $HOME/data. """ data_home = os.environ.get("LIBSVMDATA_HOME", None) + if data_home is None: data_home = os.environ.get("XDG_DATA_HOME", None) if data_home is None: data_home = Path.home() / "data" else: data_home = Path(data_home) + return data_home / subdir_name if subdir_name else data_home From 1597be75919dc6d18d9cb787ec15cc802a8c06e5 Mon Sep 17 00:00:00 2001 From: Johan Larsson Date: Tue, 29 Apr 2025 11:59:29 +0200 Subject: [PATCH 3/3] fixup! fix: wrap `data_home` in `Path()` --- libsvmdata/abstraction.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libsvmdata/abstraction.py b/libsvmdata/abstraction.py index 25a0201..467df5f 100644 --- a/libsvmdata/abstraction.py +++ b/libsvmdata/abstraction.py @@ -22,7 +22,7 @@ def _get_data_home(subdir_name=""): else: data_home = Path(data_home) - return data_home / subdir_name if subdir_name else data_home + return data_home / subdir_name class AbstractDataset(ABC):