From bbfd7b2cb40c83023f084e1f17cc5af6ac3314f4 Mon Sep 17 00:00:00 2001 From: Ron Ilan Date: Wed, 4 May 2022 12:18:54 -0700 Subject: [PATCH 01/22] Fixing issue 647 - Updated abi_crosswalk.json to include node 18 (current). - Added test coverage for cases of unsupported/unknown targets. --- lib/util/abi_crosswalk.json | 116 ++++++++++++++++++++++++++++++++++++ test/versioning.test.js | 20 +++++++ 2 files changed, 136 insertions(+) diff --git a/lib/util/abi_crosswalk.json b/lib/util/abi_crosswalk.json index 7f5297276..503e9d23a 100644 --- a/lib/util/abi_crosswalk.json +++ b/lib/util/abi_crosswalk.json @@ -2231,6 +2231,26 @@ "node_abi": 72, "v8": "7.8" }, + "12.22.8": { + "node_abi": 72, + "v8": "7.8" + }, + "12.22.9": { + "node_abi": 72, + "v8": "7.8" + }, + "12.22.10": { + "node_abi": 72, + "v8": "7.8" + }, + "12.22.11": { + "node_abi": 72, + "v8": "7.8" + }, + "12.22.12": { + "node_abi": 72, + "v8": "7.8" + }, "13.0.0": { "node_abi": 79, "v8": "7.8" @@ -2435,6 +2455,26 @@ "node_abi": 83, "v8": "8.4" }, + "14.18.2": { + "node_abi": 83, + "v8": "8.4" + }, + "14.18.3": { + "node_abi": 83, + "v8": "8.4" + }, + "14.19.0": { + "node_abi": 83, + "v8": "8.4" + }, + "14.19.1": { + "node_abi": 83, + "v8": "8.4" + }, + "14.19.2": { + "node_abi": 83, + "v8": "8.4" + }, "15.0.0": { "node_abi": 88, "v8": "8.6" @@ -2587,6 +2627,30 @@ "node_abi": 93, "v8": "9.4" }, + "16.13.1": { + "node_abi": 93, + "v8": "9.4" + }, + "16.13.2": { + "node_abi": 93, + "v8": "9.4" + }, + "16.14.0": { + "node_abi": 93, + "v8": "9.4" + }, + "16.14.1": { + "node_abi": 93, + "v8": "9.4" + }, + "16.14.2": { + "node_abi": 93, + "v8": "9.4" + }, + "16.15.0": { + "node_abi": 93, + "v8": "9.4" + }, "17.0.0": { "node_abi": 102, "v8": "9.5" @@ -2598,5 +2662,57 @@ "17.1.0": { "node_abi": 102, "v8": "9.5" + }, + "17.2.0": { + "node_abi": 102, + "v8": "9.6" + }, + "17.3.0": { + "node_abi": 102, + "v8": "9.6" + }, + "17.3.1": { + "node_abi": 102, + "v8": "9.6" + }, + "17.4.0": { + "node_abi": 102, + "v8": "9.6" + }, + "17.5.0": { + "node_abi": 102, + "v8": "9.6" + }, + "17.6.0": { + "node_abi": 102, + "v8": "9.6" + }, + "17.7.0": { + "node_abi": 102, + "v8": "9.6" + }, + "17.7.1": { + "node_abi": 102, + "v8": "9.6" + }, + "17.7.2": { + "node_abi": 102, + "v8": "9.6" + }, + "17.8.0": { + "node_abi": 102, + "v8": "9.6" + }, + "17.9.0": { + "node_abi": 102, + "v8": "9.6" + }, + "18.0.0": { + "node_abi": 108, + "v8": "10.1" + }, + "18.1.0": { + "node_abi": 108, + "v8": "10.1" } } \ No newline at end of file diff --git a/test/versioning.test.js b/test/versioning.test.js index 5dcb78a69..3de9ac9ca 100644 --- a/test/versioning.test.js +++ b/test/versioning.test.js @@ -90,6 +90,26 @@ test('should detect abi for node-webkit runtime', (t) => { t.end(); }); +test('should throw when custom node target is not found in abi_crosswalk file', (t) => { + try { + versioning.get_runtime_abi('node', '123456789.0.0'); + } catch (e) { + const expectedMessage = 'Unsupported target version: 123456789.0.0'; + t.equal(e.message, expectedMessage); + t.end(); + } +}); + +test('should throw when custom node target is not semver', (t) => { + try { + versioning.get_runtime_abi('node', '1.2.3.4'); + } catch (e) { + const expectedMessage = 'Unknown target version: 1.2.3.4'; + t.equal(e.message, expectedMessage); + t.end(); + } +}); + test('should detect custom binary host from env', (t) => { const mock_package_json = { 'name': 'test', From e26d438147e668ddfb20e89c61c892c8a8b31c72 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Thu, 11 Apr 2024 09:42:26 +0200 Subject: [PATCH 02/22] run.util.js: Test building with msvs 2022 --- test/run.util.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/test/run.util.js b/test/run.util.js index ea567ade2..55e50b139 100644 --- a/test/run.util.js +++ b/test/run.util.js @@ -58,9 +58,9 @@ function run(prog, command, args, app, opts, cb) { opts.cwd = path.join(__dirname, app.name); } - // Test building with msvs 2015 since that is more edge case than 2013 + // Test building with msvs 2022 if (process.platform === 'win32') { - final_cmd += ' --msvs_version=2015 '; + final_cmd += ' --msvs_version=2022 '; } // finish appending all arguments From d175f4827a8d288cb788b91e596493172fac1bfa Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Thu, 11 Apr 2024 10:24:48 +0200 Subject: [PATCH 03/22] Update appveyor.yml --- appveyor.yml | 27 ++++++++++++++++++--------- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index 4244237a5..d1a32f9a2 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -1,10 +1,16 @@ -os: Visual Studio 2015 +# http://www.appveyor.com/docs/appveyor-yml + +image: + - Visual Studio 2022 environment: matrix: - - nodejs_version: 10 - - nodejs_version: 12 - - nodejs_version: 14 + - nodejs_version: 16 + - nodejs_version: 18 + - nodejs_version: 20 + allow_failures: # TODO: Fix these tests and remove these three lines. + - nodejs_version: 18 + - nodejs_version: 20 platform: - x64 @@ -13,17 +19,20 @@ platform: shallow_clone: true install: - - ps: Install-Product node $env:nodejs_version $env:Platform + - ps: Install-Product node $env:nodejs_version $env:platform - ps: Set-ExecutionPolicy Unrestricted -Scope CurrentUser -Force - npm config get - node --version - npm --version - node -e "console.log(process.arch);" - - IF /I "%PLATFORM%" == "x64" set PATH=C:\Python27-x64;%PATH% - - IF /I "%PLATFORM%" == "x86" SET PATH=C:\python27;%PATH% - - IF /I "%PLATFORM%" == "x64" CALL "C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\vcvarsall.bat" amd64 - - IF /I "%PLATFORM%" == "x86" CALL "C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\vcvarsall.bat" x86 + # Python >= v3.12 requires node-gyp >= v10 + - IF /I "%PLATFORM%" == "x64" set PATH=C:\Python311-x64;%PATH% + - IF /I "%PLATFORM%" == "x86" SET PATH=C:\python311;%PATH% + # - IF /I "%PLATFORM%" == "x64" CALL "C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\vcvarsall.bat" amd64 + # - IF /I "%PLATFORM%" == "x86" CALL "C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\vcvarsall.bat" x86 + - npm config list - npm ci + # - npm audit # TODO: Fix mapbox/node-pre-gyp#705 and enable this line - npm test build: off From cae1f89a6380e47c76b65aa80144269986fccbe1 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Thu, 11 Apr 2024 10:29:33 +0200 Subject: [PATCH 04/22] Update appveyor.yml --- appveyor.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/appveyor.yml b/appveyor.yml index d1a32f9a2..bb2ce0def 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -8,9 +8,15 @@ environment: - nodejs_version: 16 - nodejs_version: 18 - nodejs_version: 20 - allow_failures: # TODO: Fix these tests and remove these three lines. + allow_failures: # TODO: Fix these tests and remove these nine lines. - nodejs_version: 18 + platform: x64 + - nodejs_version: 18 + platform: x86 + - nodejs_version: 20 + platform: x64 - nodejs_version: 20 + platform: x86 platform: - x64 From 73050e40b9d7bc180acb97c3a6353bd38d8d981a Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Thu, 11 Apr 2024 10:31:05 +0200 Subject: [PATCH 05/22] Update appveyor.yml --- appveyor.yml | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index bb2ce0def..39f3498ac 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -8,15 +8,9 @@ environment: - nodejs_version: 16 - nodejs_version: 18 - nodejs_version: 20 - allow_failures: # TODO: Fix these tests and remove these nine lines. - - nodejs_version: 18 - platform: x64 - - nodejs_version: 18 - platform: x86 - - nodejs_version: 20 - platform: x64 - - nodejs_version: 20 - platform: x86 + # allow_failures: # TODO: Fix these tests and remove these three lines. + # - nodejs_version: 18 + # - nodejs_version: 20 platform: - x64 From b33fee566bc9adc19c313ab2a4feacb6f4cd2184 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Thu, 11 Apr 2024 10:39:52 +0200 Subject: [PATCH 06/22] Update appveyor.yml --- appveyor.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index 39f3498ac..fb41901c1 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -6,11 +6,11 @@ image: environment: matrix: - nodejs_version: 16 - - nodejs_version: 18 - - nodejs_version: 20 - # allow_failures: # TODO: Fix these tests and remove these three lines. - # - nodejs_version: 18 - # - nodejs_version: 20 + # - nodejs_version: 18 + # - nodejs_version: 20 + allow_failures: # TODO: Fix these tests and remove this line. + - nodejs_version: 18 + - nodejs_version: 20 platform: - x64 From aad20cd05383c616a2488a6d48b22d33e4ca4047 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Thu, 11 Apr 2024 10:41:49 +0200 Subject: [PATCH 07/22] Update appveyor.yml --- appveyor.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index fb41901c1..d1a32f9a2 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -6,9 +6,9 @@ image: environment: matrix: - nodejs_version: 16 - # - nodejs_version: 18 - # - nodejs_version: 20 - allow_failures: # TODO: Fix these tests and remove this line. + - nodejs_version: 18 + - nodejs_version: 20 + allow_failures: # TODO: Fix these tests and remove these three lines. - nodejs_version: 18 - nodejs_version: 20 From d866f515fd3b9e1e9857a9cc0121a94953273586 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Thu, 11 Apr 2024 10:43:06 +0200 Subject: [PATCH 08/22] Update appveyor.yml --- appveyor.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index d1a32f9a2..8f0fb1425 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -8,9 +8,9 @@ environment: - nodejs_version: 16 - nodejs_version: 18 - nodejs_version: 20 - allow_failures: # TODO: Fix these tests and remove these three lines. - - nodejs_version: 18 - - nodejs_version: 20 + - allow_failures: # TODO: Fix these tests and remove these three lines. + - nodejs_version: 18 + - nodejs_version: 20 platform: - x64 From 97e46703470b01a19fec68dfc3cb90fb23829a90 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Thu, 11 Apr 2024 10:47:42 +0200 Subject: [PATCH 09/22] Update appveyor.yml --- appveyor.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index 8f0fb1425..47bfe7f3a 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -8,9 +8,11 @@ environment: - nodejs_version: 16 - nodejs_version: 18 - nodejs_version: 20 - - allow_failures: # TODO: Fix these tests and remove these three lines. - - nodejs_version: 18 - - nodejs_version: 20 + +matrix: # TODO: Fix these tests and remove these four lines. + allow_failures: + - nodejs_version: 18 + - nodejs_version: 20 platform: - x64 From 70c1dcacbd36b8956e1575e97cc0faeff93bab55 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Thu, 11 Apr 2024 10:58:56 +0200 Subject: [PATCH 10/22] Update appveyor.yml --- appveyor.yml | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index 47bfe7f3a..bbcb716b2 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -1,18 +1,16 @@ -# http://www.appveyor.com/docs/appveyor-yml - -image: +image: # http://www.appveyor.com/docs/appveyor-yml - Visual Studio 2022 environment: - matrix: + matrix: # https://github.com/nodejs/release#release-schedule - nodejs_version: 16 - nodejs_version: 18 - nodejs_version: 20 -matrix: # TODO: Fix these tests and remove these four lines. +matrix: # TODO: Fix these tests and remove this allow_failures matrix. allow_failures: - - nodejs_version: 18 - - nodejs_version: 20 + - nodejs_version: 18 # Error: Unsupported target version: 18.x.x + - nodejs_version: 20 # Error: Unsupported target version: 20.x.x platform: - x64 @@ -26,12 +24,10 @@ install: - npm config get - node --version - npm --version - - node -e "console.log(process.arch);" + - node -e "console.log(process.arch);" # 'x64' or 'ia32' # Python >= v3.12 requires node-gyp >= v10 - IF /I "%PLATFORM%" == "x64" set PATH=C:\Python311-x64;%PATH% - - IF /I "%PLATFORM%" == "x86" SET PATH=C:\python311;%PATH% - # - IF /I "%PLATFORM%" == "x64" CALL "C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\vcvarsall.bat" amd64 - # - IF /I "%PLATFORM%" == "x86" CALL "C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\vcvarsall.bat" x86 + - IF /I "%PLATFORM%" != "x64" SET PATH=C:\python311;%PATH% - npm config list - npm ci # - npm audit # TODO: Fix mapbox/node-pre-gyp#705 and enable this line From 13a51d82f5f96a6467d5ee3b6cd76f0e814422d9 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Thu, 11 Apr 2024 11:08:17 +0200 Subject: [PATCH 11/22] Update appveyor.yml --- appveyor.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/appveyor.yml b/appveyor.yml index bbcb716b2..15e51978e 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -27,7 +27,7 @@ install: - node -e "console.log(process.arch);" # 'x64' or 'ia32' # Python >= v3.12 requires node-gyp >= v10 - IF /I "%PLATFORM%" == "x64" set PATH=C:\Python311-x64;%PATH% - - IF /I "%PLATFORM%" != "x64" SET PATH=C:\python311;%PATH% + - IF /I "%PLATFORM%" == "x86" SET PATH=C:\python311;%PATH% - npm config list - npm ci # - npm audit # TODO: Fix mapbox/node-pre-gyp#705 and enable this line From fbd3cce959a6868db74df82ee643ea591b42f378 Mon Sep 17 00:00:00 2001 From: Christian Clauss Date: Thu, 11 Apr 2024 11:28:11 +0200 Subject: [PATCH 12/22] mapbox/node-pre-gyp#710 --- appveyor.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/appveyor.yml b/appveyor.yml index 15e51978e..bd15c2e1c 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -7,7 +7,7 @@ environment: - nodejs_version: 18 - nodejs_version: 20 -matrix: # TODO: Fix these tests and remove this allow_failures matrix. +matrix: # TODO: Fix mapbox/node-pre-gyp#710 and remove this allow_failures matrix. allow_failures: - nodejs_version: 18 # Error: Unsupported target version: 18.x.x - nodejs_version: 20 # Error: Unsupported target version: 20.x.x From 2ef00965cd22e490a3c44093be2a30fd5a1f086d Mon Sep 17 00:00:00 2001 From: Andrew Calcutt Date: Thu, 11 Apr 2024 16:44:02 -0400 Subject: [PATCH 13/22] update abi_crosswalk.json --- lib/util/abi_crosswalk.json | 496 ++++++++++++++++++++++++++++++++++++ 1 file changed, 496 insertions(+) diff --git a/lib/util/abi_crosswalk.json b/lib/util/abi_crosswalk.json index 7f5297276..a078a5d05 100644 --- a/lib/util/abi_crosswalk.json +++ b/lib/util/abi_crosswalk.json @@ -2231,6 +2231,26 @@ "node_abi": 72, "v8": "7.8" }, + "12.22.8": { + "node_abi": 72, + "v8": "7.8" + }, + "12.22.9": { + "node_abi": 72, + "v8": "7.8" + }, + "12.22.10": { + "node_abi": 72, + "v8": "7.8" + }, + "12.22.11": { + "node_abi": 72, + "v8": "7.8" + }, + "12.22.12": { + "node_abi": 72, + "v8": "7.8" + }, "13.0.0": { "node_abi": 79, "v8": "7.8" @@ -2435,6 +2455,54 @@ "node_abi": 83, "v8": "8.4" }, + "14.18.2": { + "node_abi": 83, + "v8": "8.4" + }, + "14.18.3": { + "node_abi": 83, + "v8": "8.4" + }, + "14.19.0": { + "node_abi": 83, + "v8": "8.4" + }, + "14.19.1": { + "node_abi": 83, + "v8": "8.4" + }, + "14.19.2": { + "node_abi": 83, + "v8": "8.4" + }, + "14.19.3": { + "node_abi": 83, + "v8": "8.4" + }, + "14.20.0": { + "node_abi": 83, + "v8": "8.4" + }, + "14.20.1": { + "node_abi": 83, + "v8": "8.4" + }, + "14.21.0": { + "node_abi": 83, + "v8": "8.4" + }, + "14.21.1": { + "node_abi": 83, + "v8": "8.4" + }, + "14.21.2": { + "node_abi": 83, + "v8": "8.4" + }, + "14.21.3": { + "node_abi": 83, + "v8": "8.4" + }, "15.0.0": { "node_abi": 88, "v8": "8.6" @@ -2587,6 +2655,74 @@ "node_abi": 93, "v8": "9.4" }, + "16.13.1": { + "node_abi": 93, + "v8": "9.4" + }, + "16.13.2": { + "node_abi": 93, + "v8": "9.4" + }, + "16.14.0": { + "node_abi": 93, + "v8": "9.4" + }, + "16.14.1": { + "node_abi": 93, + "v8": "9.4" + }, + "16.14.2": { + "node_abi": 93, + "v8": "9.4" + }, + "16.15.0": { + "node_abi": 93, + "v8": "9.4" + }, + "16.15.1": { + "node_abi": 93, + "v8": "9.4" + }, + "16.16.0": { + "node_abi": 93, + "v8": "9.4" + }, + "16.17.0": { + "node_abi": 93, + "v8": "9.4" + }, + "16.17.1": { + "node_abi": 93, + "v8": "9.4" + }, + "16.18.0": { + "node_abi": 93, + "v8": "9.4" + }, + "16.18.1": { + "node_abi": 93, + "v8": "9.4" + }, + "16.19.0": { + "node_abi": 93, + "v8": "9.4" + }, + "16.19.1": { + "node_abi": 93, + "v8": "9.4" + }, + "16.20.0": { + "node_abi": 93, + "v8": "9.4" + }, + "16.20.1": { + "node_abi": 93, + "v8": "9.4" + }, + "16.20.2": { + "node_abi": 93, + "v8": "9.4" + }, "17.0.0": { "node_abi": 102, "v8": "9.5" @@ -2598,5 +2734,365 @@ "17.1.0": { "node_abi": 102, "v8": "9.5" + }, + "17.2.0": { + "node_abi": 102, + "v8": "9.6" + }, + "17.3.0": { + "node_abi": 102, + "v8": "9.6" + }, + "17.3.1": { + "node_abi": 102, + "v8": "9.6" + }, + "17.4.0": { + "node_abi": 102, + "v8": "9.6" + }, + "17.5.0": { + "node_abi": 102, + "v8": "9.6" + }, + "17.6.0": { + "node_abi": 102, + "v8": "9.6" + }, + "17.7.0": { + "node_abi": 102, + "v8": "9.6" + }, + "17.7.1": { + "node_abi": 102, + "v8": "9.6" + }, + "17.7.2": { + "node_abi": 102, + "v8": "9.6" + }, + "17.8.0": { + "node_abi": 102, + "v8": "9.6" + }, + "17.9.0": { + "node_abi": 102, + "v8": "9.6" + }, + "17.9.1": { + "node_abi": 102, + "v8": "9.6" + }, + "18.0.0": { + "node_abi": 108, + "v8": "10.1" + }, + "18.1.0": { + "node_abi": 108, + "v8": "10.1" + }, + "18.2.0": { + "node_abi": 108, + "v8": "10.1" + }, + "18.3.0": { + "node_abi": 108, + "v8": "10.2" + }, + "18.4.0": { + "node_abi": 108, + "v8": "10.2" + }, + "18.5.0": { + "node_abi": 108, + "v8": "10.2" + }, + "18.6.0": { + "node_abi": 108, + "v8": "10.2" + }, + "18.7.0": { + "node_abi": 108, + "v8": "10.2" + }, + "18.8.0": { + "node_abi": 108, + "v8": "10.2" + }, + "18.9.0": { + "node_abi": 108, + "v8": "10.2" + }, + "18.9.1": { + "node_abi": 108, + "v8": "10.2" + }, + "18.10.0": { + "node_abi": 108, + "v8": "10.2" + }, + "18.11.0": { + "node_abi": 108, + "v8": "10.2" + }, + "18.12.0": { + "node_abi": 108, + "v8": "10.2" + }, + "18.12.1": { + "node_abi": 108, + "v8": "10.2" + }, + "18.13.0": { + "node_abi": 108, + "v8": "10.2" + }, + "18.14.0": { + "node_abi": 108, + "v8": "10.2" + }, + "18.14.1": { + "node_abi": 108, + "v8": "10.2" + }, + "18.14.2": { + "node_abi": 108, + "v8": "10.2" + }, + "18.15.0": { + "node_abi": 108, + "v8": "10.2" + }, + "18.16.0": { + "node_abi": 108, + "v8": "10.2" + }, + "18.16.1": { + "node_abi": 108, + "v8": "10.2" + }, + "18.17.0": { + "node_abi": 108, + "v8": "10.2" + }, + "18.17.1": { + "node_abi": 108, + "v8": "10.2" + }, + "18.18.0": { + "node_abi": 108, + "v8": "10.2" + }, + "18.18.1": { + "node_abi": 108, + "v8": "10.2" + }, + "18.18.2": { + "node_abi": 108, + "v8": "10.2" + }, + "18.19.0": { + "node_abi": 108, + "v8": "10.2" + }, + "18.19.1": { + "node_abi": 108, + "v8": "10.2" + }, + "18.20.0": { + "node_abi": 108, + "v8": "10.2" + }, + "18.20.1": { + "node_abi": 108, + "v8": "10.2" + }, + "18.20.2": { + "node_abi": 108, + "v8": "10.2" + }, + "19.0.0": { + "node_abi": 111, + "v8": "10.7" + }, + "19.0.1": { + "node_abi": 111, + "v8": "10.7" + }, + "19.1.0": { + "node_abi": 111, + "v8": "10.7" + }, + "19.2.0": { + "node_abi": 111, + "v8": "10.8" + }, + "19.3.0": { + "node_abi": 111, + "v8": "10.8" + }, + "19.4.0": { + "node_abi": 111, + "v8": "10.8" + }, + "19.5.0": { + "node_abi": 111, + "v8": "10.8" + }, + "19.6.0": { + "node_abi": 111, + "v8": "10.8" + }, + "19.6.1": { + "node_abi": 111, + "v8": "10.8" + }, + "19.7.0": { + "node_abi": 111, + "v8": "10.8" + }, + "19.8.0": { + "node_abi": 111, + "v8": "10.8" + }, + "19.8.1": { + "node_abi": 111, + "v8": "10.8" + }, + "19.9.0": { + "node_abi": 111, + "v8": "10.8" + }, + "20.0.0": { + "node_abi": 115, + "v8": "11.3" + }, + "20.1.0": { + "node_abi": 115, + "v8": "11.3" + }, + "20.2.0": { + "node_abi": 115, + "v8": "11.3" + }, + "20.3.0": { + "node_abi": 115, + "v8": "11.3" + }, + "20.3.1": { + "node_abi": 115, + "v8": "11.3" + }, + "20.4.0": { + "node_abi": 115, + "v8": "11.3" + }, + "20.5.0": { + "node_abi": 115, + "v8": "11.3" + }, + "20.5.1": { + "node_abi": 115, + "v8": "11.3" + }, + "20.6.0": { + "node_abi": 115, + "v8": "11.3" + }, + "20.6.1": { + "node_abi": 115, + "v8": "11.3" + }, + "20.7.0": { + "node_abi": 115, + "v8": "11.3" + }, + "20.8.0": { + "node_abi": 115, + "v8": "11.3" + }, + "20.8.1": { + "node_abi": 115, + "v8": "11.3" + }, + "20.9.0": { + "node_abi": 115, + "v8": "11.3" + }, + "20.10.0": { + "node_abi": 115, + "v8": "11.3" + }, + "20.11.0": { + "node_abi": 115, + "v8": "11.3" + }, + "20.11.1": { + "node_abi": 115, + "v8": "11.3" + }, + "20.12.0": { + "node_abi": 115, + "v8": "11.3" + }, + "20.12.1": { + "node_abi": 115, + "v8": "11.3" + }, + "20.12.2": { + "node_abi": 115, + "v8": "11.3" + }, + "21.0.0": { + "node_abi": 120, + "v8": "11.8" + }, + "21.1.0": { + "node_abi": 120, + "v8": "11.8" + }, + "21.2.0": { + "node_abi": 120, + "v8": "11.8" + }, + "21.3.0": { + "node_abi": 120, + "v8": "11.8" + }, + "21.4.0": { + "node_abi": 120, + "v8": "11.8" + }, + "21.5.0": { + "node_abi": 120, + "v8": "11.8" + }, + "21.6.0": { + "node_abi": 120, + "v8": "11.8" + }, + "21.6.1": { + "node_abi": 120, + "v8": "11.8" + }, + "21.6.2": { + "node_abi": 120, + "v8": "11.8" + }, + "21.7.0": { + "node_abi": 120, + "v8": "11.8" + }, + "21.7.1": { + "node_abi": 120, + "v8": "11.8" + }, + "21.7.2": { + "node_abi": 120, + "v8": "11.8" + }, + "21.7.3": { + "node_abi": 120, + "v8": "11.8" } } \ No newline at end of file From 56334ee7601cae43346e7b6babfdb461c40bd51c Mon Sep 17 00:00:00 2001 From: Andrew Calcutt Date: Thu, 11 Apr 2024 17:56:50 -0400 Subject: [PATCH 14/22] Update appveyor.yml for node 20 support --- appveyor.yml | 5 ----- 1 file changed, 5 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index bd15c2e1c..5b5d3e9d7 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -7,11 +7,6 @@ environment: - nodejs_version: 18 - nodejs_version: 20 -matrix: # TODO: Fix mapbox/node-pre-gyp#710 and remove this allow_failures matrix. - allow_failures: - - nodejs_version: 18 # Error: Unsupported target version: 18.x.x - - nodejs_version: 20 # Error: Unsupported target version: 20.x.x - platform: - x64 - x86 From 7804f5c559c4a52d49874a84a91d8edbb5d2c8ae Mon Sep 17 00:00:00 2001 From: Andrew Calcutt Date: Thu, 11 Apr 2024 19:02:02 -0400 Subject: [PATCH 15/22] test: show command --- test/run.util.js | 1 + 1 file changed, 1 insertion(+) diff --git a/test/run.util.js b/test/run.util.js index 55e50b139..d8bdeacdb 100644 --- a/test/run.util.js +++ b/test/run.util.js @@ -88,6 +88,7 @@ function run(prog, command, args, app, opts, cb) { // Finally, execute the command cp.exec(final_cmd, opts, (err, stdout, stderr) => { + console.log("Command '" + final_cmd + "'"); if (err) { const error = new Error("Command failed '" + final_cmd + "'"); error.stack = stderr; From 17ee1cc7f3f9e393b153b3e1690a4d74343cd83c Mon Sep 17 00:00:00 2001 From: Andrew Calcutt Date: Thu, 11 Apr 2024 19:10:15 -0400 Subject: [PATCH 16/22] Revert "test: show command" This reverts commit 7804f5c559c4a52d49874a84a91d8edbb5d2c8ae. --- test/run.util.js | 1 - 1 file changed, 1 deletion(-) diff --git a/test/run.util.js b/test/run.util.js index d8bdeacdb..55e50b139 100644 --- a/test/run.util.js +++ b/test/run.util.js @@ -88,7 +88,6 @@ function run(prog, command, args, app, opts, cb) { // Finally, execute the command cp.exec(final_cmd, opts, (err, stdout, stderr) => { - console.log("Command '" + final_cmd + "'"); if (err) { const error = new Error("Command failed '" + final_cmd + "'"); error.stack = stderr; From e5a9524426533624e4b8eb18724ead6de99686f1 Mon Sep 17 00:00:00 2001 From: Andrew Calcutt Date: Thu, 11 Apr 2024 19:18:58 -0400 Subject: [PATCH 17/22] add line ending to abi_crosswalk.json fix github warning error --- lib/util/abi_crosswalk.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/util/abi_crosswalk.json b/lib/util/abi_crosswalk.json index a078a5d05..ddc8213ff 100644 --- a/lib/util/abi_crosswalk.json +++ b/lib/util/abi_crosswalk.json @@ -3095,4 +3095,4 @@ "node_abi": 120, "v8": "11.8" } -} \ No newline at end of file +} From 9dec1f1e5d75a6645f88e6af23c439a67ba0a136 Mon Sep 17 00:00:00 2001 From: Andrew Calcutt Date: Thu, 11 Apr 2024 19:57:12 -0400 Subject: [PATCH 18/22] add node 21 to appveyor.yml Co-authored-by: Christian Clauss --- appveyor.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/appveyor.yml b/appveyor.yml index 5b5d3e9d7..8f480fe92 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -6,6 +6,7 @@ environment: - nodejs_version: 16 - nodejs_version: 18 - nodejs_version: 20 + - nodejs_version: 21 platform: - x64 From e33ff0ca49e9c6132acabc2337ba495ba95b1491 Mon Sep 17 00:00:00 2001 From: Andrew Calcutt Date: Thu, 11 Apr 2024 21:00:12 -0400 Subject: [PATCH 19/22] Update appveyor.yml Co-authored-by: Christian Clauss --- appveyor.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/appveyor.yml b/appveyor.yml index 8f480fe92..fa6d3de23 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -8,6 +8,11 @@ environment: - nodejs_version: 20 - nodejs_version: 21 +matrix: # TODO: Fix the `configures with unparsed options` tests and remove this allow_failures matrix. + allow_failures: + - nodejs_version: 20 + - nodejs_version: 21 + platform: - x64 - x86 From aaabb800e432dc6d705a4a092c992f6b944dda40 Mon Sep 17 00:00:00 2001 From: Andrew Calcutt Date: Thu, 18 Apr 2024 23:33:48 -0400 Subject: [PATCH 20/22] npm run update-crosswalk Co-authored-by: Christian Clauss --- appveyor.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/appveyor.yml b/appveyor.yml index fa6d3de23..b75863749 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -31,6 +31,7 @@ install: - IF /I "%PLATFORM%" == "x86" SET PATH=C:\python311;%PATH% - npm config list - npm ci + - npm run update-crosswalk # To support newer versions of Node.js # - npm audit # TODO: Fix mapbox/node-pre-gyp#705 and enable this line - npm test From a8aa8688a27ac3c7295af33c668f824959f331c2 Mon Sep 17 00:00:00 2001 From: acalcutt Date: Thu, 27 Jun 2024 14:31:38 -0400 Subject: [PATCH 21/22] npm run update-crosswalk for node 22 --- lib/util/abi_crosswalk.json | 38 ++++++++++++++++++++++++++++++++++++- 1 file changed, 37 insertions(+), 1 deletion(-) diff --git a/lib/util/abi_crosswalk.json b/lib/util/abi_crosswalk.json index ddc8213ff..15fe044f2 100644 --- a/lib/util/abi_crosswalk.json +++ b/lib/util/abi_crosswalk.json @@ -2911,6 +2911,10 @@ "node_abi": 108, "v8": "10.2" }, + "18.20.3": { + "node_abi": 108, + "v8": "10.2" + }, "19.0.0": { "node_abi": 111, "v8": "10.7" @@ -3043,6 +3047,22 @@ "node_abi": 115, "v8": "11.3" }, + "20.13.0": { + "node_abi": 115, + "v8": "11.3" + }, + "20.13.1": { + "node_abi": 115, + "v8": "11.3" + }, + "20.14.0": { + "node_abi": 115, + "v8": "11.3" + }, + "20.15.0": { + "node_abi": 115, + "v8": "11.3" + }, "21.0.0": { "node_abi": 120, "v8": "11.8" @@ -3094,5 +3114,21 @@ "21.7.3": { "node_abi": 120, "v8": "11.8" + }, + "22.0.0": { + "node_abi": 127, + "v8": "12.4" + }, + "22.1.0": { + "node_abi": 127, + "v8": "12.4" + }, + "22.2.0": { + "node_abi": 127, + "v8": "12.4" + }, + "22.3.0": { + "node_abi": 127, + "v8": "12.4" } -} +} \ No newline at end of file From 9acee69fc2034886706081141d5515b2a33e3211 Mon Sep 17 00:00:00 2001 From: acalcutt Date: Thu, 27 Jun 2024 14:33:14 -0400 Subject: [PATCH 22/22] change node 21 to node 22 in appveyor.yml --- appveyor.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/appveyor.yml b/appveyor.yml index b75863749..ce94cdbc9 100644 --- a/appveyor.yml +++ b/appveyor.yml @@ -6,12 +6,12 @@ environment: - nodejs_version: 16 - nodejs_version: 18 - nodejs_version: 20 - - nodejs_version: 21 + - nodejs_version: 22 matrix: # TODO: Fix the `configures with unparsed options` tests and remove this allow_failures matrix. allow_failures: - nodejs_version: 20 - - nodejs_version: 21 + - nodejs_version: 22 platform: - x64