fix: set tool.error span attribute in catch block

mattpodwysocki · claude · mattpodwysocki · commit 708d3b499d85 · 2026-04-15T11:13:50.000-04:00
The catch path was returning isError: true without marking the span,
causing validation failures and unexpected exceptions to appear as
successful spans in tracing backends.

Co-Authored-By: Claude Sonnet 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/src/tools/BaseTool.ts b/src/tools/BaseTool.ts
@@ -50,6 +50,7 @@ export abstract class BaseTool<
         }
         return result;
       } catch (error) {
+        span.setAttribute('tool.error', true);
         return {
           isError: true,
           content: [{ type: 'text', text: (error as Error).message }]

Original file line number	Diff line number	Diff line change
`@@ -50,6 +50,7 @@ export abstract class BaseTool<`
`50`	`50`	`}`
`51`	`51`	`return result;`
`52`	`52`	`} catch (error) {`
	`53`	`+ span.setAttribute('tool.error', true);`
`53`	`54`	`return {`
`54`	`55`	`isError: true,`
`55`	`56`	`content: [{ type: 'text', text: (error as Error).message }]`