fix tests

Author: KSemenenko

ManagedCode.Communication.Tests/Results/CollectionResultTests.cs

@@ -153,7 +153,7 @@ public void Empty_ShouldCreateEmptyResult()
             .BeEmpty();
         result.PageNumber
             .Should()
-            .Be(1);
+            .Be(0);
         result.PageSize
             .Should()
             .Be(0);
@@ -171,33 +171,6 @@ public void Empty_ShouldCreateEmptyResult()
             .BeTrue();
     }
 
-    [Fact]
-    public void Empty_WithPaging_ShouldCreateEmptyResultWithPaging()
-    {
-        // Act
-        var result = CollectionResult<string>.Empty(pageNumber: 2, pageSize: 10);
-
-        // Assert
-        result.IsSuccess
-            .Should()
-            .BeTrue();
-        result.Collection
-            .Should()
-            .BeEmpty();
-        result.PageNumber
-            .Should()
-            .Be(2);
-        result.PageSize
-            .Should()
-            .Be(10);
-        result.TotalItems
-            .Should()
-            .Be(0);
-        result.TotalPages
-            .Should()
-            .Be(0);
-    }
-
     [Fact]
     public void Fail_WithMessage_ShouldCreateFailedResult()
     {
@@ -477,10 +450,10 @@ public void ThrowIfFail_WithValidationFailure_ShouldThrowWithValidationDetails()
 
         exception.Problem.Title.Should().Be("Validation Failed");
         exception.Problem.StatusCode.Should().Be(400);
-        
+
         var validationErrors = exception.Problem.GetValidationErrors();
         validationErrors.Should().NotBeNull();
         validationErrors!["filter"].Should().Contain("Invalid filter format");
         validationErrors!["pageSize"].Should().Contain("Page size must be between 1 and 100");
     }
-}
+}

ManagedCode.Communication.Tests/Serialization/SerializationTests.cs

@@ -60,7 +60,7 @@ public void Problem_WithValidationErrors_ShouldSerializeAndDeserialize()
         deserialized!.Type.Should().Be(ProblemConstants.Types.ValidationFailed);
         deserialized.Title.Should().Be(ProblemConstants.Titles.ValidationFailed);
         deserialized.StatusCode.Should().Be(400);
-        
+
         var errors = deserialized.GetValidationErrors();
         errors.Should().NotBeNull();
         errors!["email"].Should().Contain("Invalid format");
@@ -220,7 +220,7 @@ public void CollectionResult_Empty_ShouldSerializeAndDeserialize()
         // Assert
         deserialized.IsSuccess.Should().BeTrue();
         deserialized.Collection.Should().BeEmpty();
-        deserialized.PageNumber.Should().Be(1);
+        deserialized.PageNumber.Should().Be(0);
         deserialized.PageSize.Should().Be(0);
         deserialized.TotalItems.Should().Be(0);
     }
@@ -437,4 +437,4 @@ private class TestModel
         public string? Name { get; set; }
         public string[]? Tags { get; set; }
     }
-}
+}

ManagedCode.Communication/CollectionResultT/CollectionResult.cs

@@ -173,13 +173,5 @@ public static CollectionResult<T> Empty()
         return Create(true, [], 0, 0, 0);
     }
 
-    /// <summary>
-    ///     Creates an empty collection result with paging information.
-    /// </summary>
-    public static CollectionResult<T> Empty()
-    {
-        return Create(true, [], 0, 0, 0);
-    }
-
     #endregion
 }