Fix auth handling for empty login token responses#489
Open
dannolan wants to merge 1 commit into
Open
Conversation
|
Current response with these changes: 1:14PM DBG error="request failed: request failed: Post "": failed to make round trip: unsupported protocol scheme """ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
go generate ./... && go test ./...Summary by cubic
Improves App Store login handling by treating empty 200 OK responses as an auth-code requirement, and returns a clear error if session fields are still missing after 2FA. Also removes raw password logging in verbose mode.
passwordProvidedboolean incmd/auth.go.pkg/appstore, returnErrAuthCodeRequiredwhen a 200 OK lacks session tokens before 2FA; after 2FA, return a clear “login response did not include an App Store session token” error.Written for commit 074d246. Summary will update on new commits.