AC-15170:Add official support for Symfony 7.4 LTS in Adobe Commerce 2.4.9

glo71317 · glo71317 · commit 67b7b5478041 · 2025-12-08T12:42:09.000+05:30
diff --git a/app/code/Magento/Catalog/Test/Unit/Pricing/Price/RegularPriceTest.php b/app/code/Magento/Catalog/Test/Unit/Pricing/Price/RegularPriceTest.php
@@ -71,7 +71,7 @@ protected function setUp(): void
      * Test method testGetValue
      *
      * @param float|bool $price
-     * @dataProvider testGetValueDataProvider
+     * @dataProvider getValueDataProvider
      */
     public function testGetValue($price)
     {
@@ -93,7 +93,7 @@ public function testGetValue($price)
      *
      * @return array
      */
-    public static function testGetValueDataProvider()
+    public static function getValueDataProvider()
     {
         return [
             'With price' => [100.00],
diff --git a/app/code/Magento/Customer/Test/Unit/Ui/Component/Listing/Column/AccountLockTest.php b/app/code/Magento/Customer/Test/Unit/Ui/Component/Listing/Column/AccountLockTest.php
@@ -43,7 +43,7 @@ protected function setup(): void
     /**
      * @param string $lockExpirationDate
      * @param Phrase $expectedResult
-     * @dataProvider testPrepareDataSourceDataProvider
+     * @dataProvider prepareDataSourceDataProvider
      */
     public function testPrepareDataSource($lockExpirationDate, $expectedResult)
     {
@@ -55,7 +55,7 @@ public function testPrepareDataSource($lockExpirationDate, $expectedResult)
     /**
      * @return array
      */
-    public static function testPrepareDataSourceDataProvider()
+    public static function prepareDataSourceDataProvider()
     {
         return [
             [
diff --git a/app/code/Magento/Fedex/Test/Unit/Plugin/Block/DataProviders/Tracking/ChangeTitleTest.php b/app/code/Magento/Fedex/Test/Unit/Plugin/Block/DataProviders/Tracking/ChangeTitleTest.php
@@ -42,7 +42,7 @@ protected function setUp(): void
      * @param string $carrierCode
      * @param string $originalResult
      * @param Phrase|string $finalResult
-     * @dataProvider testAfterGetTitleDataProvider
+     * @dataProvider afterGetTitleDataProvider
      */
     public function testAfterGetTitle(string $carrierCode, string $originalResult, $finalResult)
     {
@@ -70,7 +70,7 @@ public function testAfterGetTitle(string $carrierCode, string $originalResult, $
      *
      * @return array
      */
-    public static function testAfterGetTitleDataProvider(): array
+    public static function afterGetTitleDataProvider(): array
     {
         return [
             [Carrier::CODE, 'Original Title', __('Expected Delivery:')],
diff --git a/app/code/Magento/GraphQl/Test/Unit/Plugin/DisableSessionTest.php b/app/code/Magento/GraphQl/Test/Unit/Plugin/DisableSessionTest.php
@@ -63,7 +63,7 @@ public function setUp(): void
      * @param bool $methodResult
      * @param bool $expectedResult
      * @return void
-     * @dataProvider testAfterCheckDataProvider
+     * @dataProvider afterCheckDataProvider
      */
     public function testAfterCheck(string $area, bool $config, bool $methodResult, bool $expectedResult)
     {
@@ -77,7 +77,7 @@ public function testAfterCheck(string $area, bool $config, bool $methodResult, b
      *
      * @return array[]
      */
-    public static function testAfterCheckDataProvider()
+    public static function afterCheckDataProvider()
     {
         return [
             ['area' => 'graphql', 'config' => true, 'methodResult' =>  false, 'expectedResult' => false],
@@ -98,7 +98,7 @@ public static function testAfterCheckDataProvider()
      * @param bool $methodResult
      * @param bool $expectedResult
      * @return void
-     * @dataProvider testAfterCheckDataProviderNoAreaCode
+     * @dataProvider afterCheckDataProviderNoAreaCode
      */
     public function testAfterCheckNoArea(bool $config, bool $methodResult, bool $expectedResult)
     {
@@ -114,7 +114,7 @@ public function testAfterCheckNoArea(bool $config, bool $methodResult, bool $exp
      *
      * @return array[]
      */
-    public static function testAfterCheckDataProviderNoAreaCode()
+    public static function afterCheckDataProviderNoAreaCode()
     {
         return [
             ['config' => true, 'methodResult' =>  true, 'expectedResult' => true],
diff --git a/app/code/Magento/Indexer/Test/Unit/Model/ProcessManagerTest.php b/app/code/Magento/Indexer/Test/Unit/Model/ProcessManagerTest.php
@@ -208,7 +208,7 @@ function () {
     }
 
     /**
-     * @dataProvider testIsMultiThreadsExecuteDataProvider
+     * @dataProvider isMultiThreadsExecuteDataProvider
      * @param $threadsCount
      * @param $expectedResult
      * @return void
@@ -230,7 +230,7 @@ public function testIsMultiThreadsExecute($threadsCount, $expectedResult): void
         $this->assertEquals($expectedResult, $processManager->isMultiThreadsExecute());
     }
 
-    public static function testIsMultiThreadsExecuteDataProvider(): array
+    public static function isMultiThreadsExecuteDataProvider(): array
     {
         return [
             'threadsCount is null' => [null, false],
diff --git a/app/code/Magento/Sales/Test/Unit/Controller/Adminhtml/Order/Creditmemo/SaveTest.php b/app/code/Magento/Sales/Test/Unit/Controller/Adminhtml/Order/Creditmemo/SaveTest.php
@@ -318,7 +318,7 @@ protected function _setSaveActionExpectationForMageCoreException($data, $errorMe
     /**
      * @return array
      */
-    public static function testExecuteEmailsDataProvider()
+    public static function executeEmailsDataProvider()
     {
         /**
         * string $sendEmail
@@ -337,7 +337,7 @@ public static function testExecuteEmailsDataProvider()
      * @param string $sendEmail
      * @param bool $emailEnabled
      * @param bool $shouldEmailBeSent
-     * @dataProvider testExecuteEmailsDataProvider
+     * @dataProvider executeEmailsDataProvider
      */
     public function testExecuteEmails(
         $sendEmail,
diff --git a/app/code/Magento/Sales/Test/Unit/Controller/Adminhtml/Order/Invoice/SaveTest.php b/app/code/Magento/Sales/Test/Unit/Controller/Adminhtml/Order/Invoice/SaveTest.php
@@ -196,7 +196,7 @@ public function testExecuteNotValidPost(): void
     /**
      * @return array
      */
-    public static function testExecuteEmailsDataProvider(): array
+    public static function executeEmailsDataProvider(): array
     {
         /**
         * string $sendEmail
@@ -218,7 +218,7 @@ public static function testExecuteEmailsDataProvider(): array
      *
      * @return void
      * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
-     * @dataProvider testExecuteEmailsDataProvider
+     * @dataProvider executeEmailsDataProvider
      */
     public function testExecuteEmails(
         string $sendEmail,
diff --git a/app/code/Magento/Sales/Test/Unit/Ui/Component/Listing/Column/PriceTest.php b/app/code/Magento/Sales/Test/Unit/Ui/Component/Listing/Column/PriceTest.php
@@ -69,7 +69,7 @@ protected function setUp(): void
      * @param array $dataSource
      * @param string $currencyCode
      * @param int|null $expectedStoreId
-     * @dataProvider testPrepareDataSourceDataProvider
+     * @dataProvider prepareDataSourceDataProvider
      */
     public function testPrepareDataSource(
         bool $hasCurrency,
@@ -117,7 +117,7 @@ public function testPrepareDataSource(
      *
      * @return array
      */
-    public static function testPrepareDataSourceDataProvider(): array
+    public static function prepareDataSourceDataProvider(): array
     {
         $dataSource1 = [
             'data' => [
diff --git a/app/code/Magento/Store/Test/Unit/Model/ScopeResolverTest.php b/app/code/Magento/Store/Test/Unit/Model/ScopeResolverTest.php
@@ -47,7 +47,7 @@ protected function setUp(): void
      * @param string $requestedScope
      * @param int $requestedScopeId
      * @param bool $isBelong
-     * @dataProvider testIsBelongsToScopeDataProvider
+     * @dataProvider isBelongsToScopeDataProvider
      */
     public function testIsBelongsToScope(
         string $baseScope,
@@ -72,7 +72,7 @@ public function testIsBelongsToScope(
      *
      * @return array[]
      */
-    public static function testIsBelongsToScopeDataProvider()
+    public static function isBelongsToScopeDataProvider()
     {
         return [
             'All scopes belongs to Default' => [
diff --git a/app/code/Magento/Ups/Test/Unit/Plugin/Block/DataProviders/Tracking/ChangeTitleTest.php b/app/code/Magento/Ups/Test/Unit/Plugin/Block/DataProviders/Tracking/ChangeTitleTest.php
@@ -43,7 +43,7 @@ protected function setUp(): void
      * @param string $carrierCode
      * @param string $originalResult
      * @param Phrase|string $finalResult
-     * @dataProvider testAfterGetTitleDataProvider
+     * @dataProvider afterGetTitleDataProvider
      */
     public function testAfterGetTitle(string $carrierCode, string $originalResult, $finalResult)
     {
@@ -71,7 +71,7 @@ public function testAfterGetTitle(string $carrierCode, string $originalResult, $
      *
      * @return array
      */
-    public static function testAfterGetTitleDataProvider(): array
+    public static function afterGetTitleDataProvider(): array
     {
         return [
             [Carrier::CODE, 'Original Title', __('Status Updated On:')],
diff --git a/lib/internal/Magento/Framework/App/Test/Unit/BootstrapTest.php b/lib/internal/Magento/Framework/App/Test/Unit/BootstrapTest.php
@@ -189,7 +189,7 @@ public function testGetObjectManager()
      * @param $modeFromDeployment
      * @param $isDeveloper
      *
-     * @dataProvider testIsDeveloperModeDataProvider
+     * @dataProvider isDeveloperModeDataProvider
      */
     public function testIsDeveloperMode($modeFromEnvironment, $modeFromDeployment, $isDeveloper)
     {
@@ -207,7 +207,7 @@ public function testIsDeveloperMode($modeFromEnvironment, $modeFromDeployment, $
     /**
      * @return array
      */
-    public static function testIsDeveloperModeDataProvider()
+    public static function isDeveloperModeDataProvider()
     {
         return [
             [null, null, false],
diff --git a/lib/internal/Magento/Framework/App/Test/Unit/PageCache/KernelTest.php b/lib/internal/Magento/Framework/App/Test/Unit/PageCache/KernelTest.php
@@ -253,7 +253,7 @@ public static function dataProviderForResultWithoutCachedData(): array
      * @param $httpCode
      *
      * @return void
-     * @dataProvider testProcessSaveCacheDataProvider
+     * @dataProvider processSaveCacheDataProvider
      */
     public function testProcessSaveCache($httpCode): void
     {
@@ -303,7 +303,7 @@ function ($value) {
     /**
      * @return array
      */
-    public static function testProcessSaveCacheDataProvider(): array
+    public static function processSaveCacheDataProvider(): array
     {
         return [
             [200],
diff --git a/lib/internal/Magento/Framework/App/Test/Unit/ProductMetadataTest.php b/lib/internal/Magento/Framework/App/Test/Unit/ProductMetadataTest.php
@@ -50,7 +50,7 @@ protected function setUp(): void
     /**
      * @param array $packageList
      * @param string $expectedVersion
-     * @dataProvider testGetVersionGitInstallationDataProvider
+     * @dataProvider getVersionGitInstallationDataProvider
      */
     public function testGetVersion($packageList, $expectedVersion)
     {
@@ -74,7 +74,7 @@ public function testGetVersionCached()
     /**
      * @return array
      */
-    public static function testGetVersionGitInstallationDataProvider()
+    public static function getVersionGitInstallationDataProvider()
     {
         return [
             [
diff --git a/lib/internal/Magento/Framework/App/Test/Unit/ScopeResolverPoolTest.php b/lib/internal/Magento/Framework/App/Test/Unit/ScopeResolverPoolTest.php
@@ -41,7 +41,7 @@ public function testGet()
      * @param string $scope
      *
      * @covers \Magento\Framework\App\ScopeResolverPool::get()
-     * @dataProvider testGetExceptionDataProvider
+     * @dataProvider getExceptionDataProvider
      */
     public function testGetException($scope)
     {
@@ -59,7 +59,7 @@ public function testGetException($scope)
     /**
      * @return array
      */
-    public static function testGetExceptionDataProvider()
+    public static function getExceptionDataProvider()
     {
         return [
             ['undefined'],
diff --git a/lib/internal/Magento/Framework/Code/Test/Unit/Generator/IoTest.php b/lib/internal/Magento/Framework/Code/Test/Unit/Generator/IoTest.php
@@ -80,7 +80,7 @@ public function testGetResultFileName()
     }
 
     /**
-     * @dataProvider testWriteResultFileAlreadyExistsDataProvider
+     * @dataProvider writeResultFileAlreadyExistsDataProvider
      */
     public function testWriteResultFileAlreadyExists($resultFileName, $fileExists, $exceptionDuringRename, $success)
     {
@@ -119,7 +119,7 @@ public function testWriteResultFileAlreadyExists($resultFileName, $fileExists, $
     /**
      * @return array
      */
-    public static function testWriteResultFileAlreadyExistsDataProvider()
+    public static function writeResultFileAlreadyExistsDataProvider()
     {
         return [
             'Writing file succeeds: writeResultFile succeeds' => [
diff --git a/lib/internal/Magento/Framework/Code/Test/Unit/Reader/ArgumentsReaderTest.php b/lib/internal/Magento/Framework/Code/Test/Unit/Reader/ArgumentsReaderTest.php
@@ -397,7 +397,7 @@ public function testGetParentCallWithMixedArguments()
      * @param string $requiredType
      * @param string $actualType
      * @param bool $expectedResult
-     * @dataProvider testIsCompatibleTypeDataProvider
+     * @dataProvider isCompatibleTypeDataProvider
      */
     public function testIsCompatibleType($requiredType, $actualType, $expectedResult)
     {
@@ -408,7 +408,7 @@ public function testIsCompatibleType($requiredType, $actualType, $expectedResult
     /**
      * @return array
      */
-    public static function testIsCompatibleTypeDataProvider()
+    public static function isCompatibleTypeDataProvider()
     {
         return [
             ['array', 10, false],
diff --git a/lib/internal/Magento/Framework/Data/Test/Unit/Collection/FilesystemTest.php b/lib/internal/Magento/Framework/Data/Test/Unit/Collection/FilesystemTest.php
@@ -28,7 +28,7 @@ protected function setUp(): void
      * @param $row
      * @param $expected
      *
-     * @dataProvider testFilterCallbackLikeDataProvider
+     * @dataProvider filterCallbackLikeDataProvider
      */
     public function testFilterCallbackLike($field, $filterValue, $row, $expected)
     {
@@ -40,7 +40,7 @@ public function testFilterCallbackLike($field, $filterValue, $row, $expected)
     /**
      * @return array
      */
-    public static function testFilterCallbackLikeDataProvider()
+    public static function filterCallbackLikeDataProvider()
     {
         $field     = 'field';
         $testValue = '\'\'\'test\'\'\'Filter\'\'\'Value\'\'\'';
diff --git a/lib/internal/Magento/Framework/Data/Test/Unit/Form/Element/AbstractElementTest.php b/lib/internal/Magento/Framework/Data/Test/Unit/Form/Element/AbstractElementTest.php
@@ -328,7 +328,7 @@ public function testGetLabelHtml(array $initialData, $expectedValue)
     /**
      * @param array $initialData
      * @param string $expectedValue
-     * @dataProvider testGetDefaultHtmlDataProvider
+     * @dataProvider getDefaultHtmlDataProvider
      * @covers \Magento\Framework\Data\Form\Element\AbstractElement::getDefaultHtml()
      */
     public function testGetDefaultHtml(array $initialData, $expectedValue)
@@ -547,7 +547,7 @@ public static function serializeDataProvider()
     /**
      * @return array
      */
-    public static function testGetDefaultHtmlDataProvider()
+    public static function getDefaultHtmlDataProvider()
     {
         return [
             [
diff --git a/lib/internal/Magento/Framework/Math/Test/Unit/RandomTest.php b/lib/internal/Magento/Framework/Math/Test/Unit/RandomTest.php
@@ -74,7 +74,7 @@ protected function _assertContainsOnlyChars($string, $chars)
      * @param $min
      * @param $max
      *
-     * @dataProvider testGetRandomNumberProvider
+     * @dataProvider getRandomNumberProvider
      */
     public function testGetRandomNumber($min, $max)
     {
@@ -86,7 +86,7 @@ public function testGetRandomNumber($min, $max)
     /**
      * @return array
      */
-    public static function testGetRandomNumberProvider()
+    public static function getRandomNumberProvider()
     {
         return [
             [0, 100],
diff --git a/lib/internal/Magento/Framework/Module/Test/Unit/ModuleList/LoaderTest.php b/lib/internal/Magento/Framework/Module/Test/Unit/ModuleList/LoaderTest.php
@@ -88,7 +88,7 @@ protected function setUp(): void
      * @param $paths
      *
      * @return void
-     * @dataProvider testLoadDataProvider
+     * @dataProvider loadDataProvider
      */
     public function testLoad($paths): void
     {
@@ -134,7 +134,7 @@ public function testLoad($paths): void
     /**
      * @return array
      */
-    public static function testLoadDataProvider(): array
+    public static function loadDataProvider(): array
     {
         return [
             'Ordered modules list returned by registrar' => [
diff --git a/lib/internal/Magento/Framework/ObjectManager/Test/Unit/Factory/FactoryTest.php b/lib/internal/Magento/Framework/ObjectManager/Test/Unit/Factory/FactoryTest.php
diff --git a/lib/internal/Magento/Framework/View/Test/Unit/Model/Layout/Update/ValidatorTest.php b/lib/internal/Magento/Framework/View/Test/Unit/Model/Layout/Update/ValidatorTest.php
diff --git a/setup/src/Magento/Setup/Test/Unit/Module/I18n/Parser/Adapter/Php/Tokenizer/PhraseCollectorTest.php b/setup/src/Magento/Setup/Test/Unit/Module/I18n/Parser/Adapter/Php/Tokenizer/PhraseCollectorTest.php
diff --git a/setup/src/Magento/Setup/Test/Unit/Module/I18n/Parser/Adapter/Php/Tokenizer/TokenTest.php b/setup/src/Magento/Setup/Test/Unit/Module/I18n/Parser/Adapter/Php/Tokenizer/TokenTest.php

Original file line number	Diff line number	Diff line change
`@@ -71,7 +71,7 @@ protected function setUp(): void`
`71`	`71`	`* Test method testGetValue`
`72`	`72`	`*`
`73`	`73`	`* @param float\|bool $price`
`74`		`- * @dataProvider testGetValueDataProvider`
	`74`	`+ * @dataProvider getValueDataProvider`
`75`	`75`	`*/`
`76`	`76`	`public function testGetValue($price)`
`77`	`77`	`{`
`@@ -93,7 +93,7 @@ public function testGetValue($price)`
`93`	`93`	`*`
`94`	`94`	`* @return array`
`95`	`95`	`*/`
`96`		`- public static function testGetValueDataProvider()`
	`96`	`+ public static function getValueDataProvider()`
`97`	`97`	`{`
`98`	`98`	`return [`
`99`	`99`	`'With price' => [100.00],`
Original file line number	Diff line number	Diff line change
`@@ -43,7 +43,7 @@ protected function setup(): void`
`43`	`43`	`/**`
`44`	`44`	`* @param string $lockExpirationDate`
`45`	`45`	`* @param Phrase $expectedResult`
`46`		`- * @dataProvider testPrepareDataSourceDataProvider`
	`46`	`+ * @dataProvider prepareDataSourceDataProvider`
`47`	`47`	`*/`
`48`	`48`	`public function testPrepareDataSource($lockExpirationDate, $expectedResult)`
`49`	`49`	`{`
`@@ -55,7 +55,7 @@ public function testPrepareDataSource($lockExpirationDate, $expectedResult)`
`55`	`55`	`/**`
`56`	`56`	`* @return array`
`57`	`57`	`*/`
`58`		`- public static function testPrepareDataSourceDataProvider()`
	`58`	`+ public static function prepareDataSourceDataProvider()`
`59`	`59`	`{`
`60`	`60`	`return [`
`61`	`61`	`[`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ protected function setUp(): void`
`42`	`42`	`* @param string $carrierCode`
`43`	`43`	`* @param string $originalResult`
`44`	`44`	`* @param Phrase\|string $finalResult`
`45`		`- * @dataProvider testAfterGetTitleDataProvider`
	`45`	`+ * @dataProvider afterGetTitleDataProvider`
`46`	`46`	`*/`
`47`	`47`	`public function testAfterGetTitle(string $carrierCode, string $originalResult, $finalResult)`
`48`	`48`	`{`
`@@ -70,7 +70,7 @@ public function testAfterGetTitle(string $carrierCode, string $originalResult, $`
`70`	`70`	`*`
`71`	`71`	`* @return array`
`72`	`72`	`*/`
`73`		`- public static function testAfterGetTitleDataProvider(): array`
	`73`	`+ public static function afterGetTitleDataProvider(): array`
`74`	`74`	`{`
`75`	`75`	`return [`
`76`	`76`	`[Carrier::CODE, 'Original Title', __('Expected Delivery:')],`
Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ public function setUp(): void`
`63`	`63`	`* @param bool $methodResult`
`64`	`64`	`* @param bool $expectedResult`
`65`	`65`	`* @return void`
`66`		`- * @dataProvider testAfterCheckDataProvider`
	`66`	`+ * @dataProvider afterCheckDataProvider`
`67`	`67`	`*/`
`68`	`68`	`public function testAfterCheck(string $area, bool $config, bool $methodResult, bool $expectedResult)`
`69`	`69`	`{`
`@@ -77,7 +77,7 @@ public function testAfterCheck(string $area, bool $config, bool $methodResult, b`
`77`	`77`	`*`
`78`	`78`	`* @return array[]`
`79`	`79`	`*/`
`80`		`- public static function testAfterCheckDataProvider()`
	`80`	`+ public static function afterCheckDataProvider()`
`81`	`81`	`{`
`82`	`82`	`return [`
`83`	`83`	`['area' => 'graphql', 'config' => true, 'methodResult' => false, 'expectedResult' => false],`
`@@ -98,7 +98,7 @@ public static function testAfterCheckDataProvider()`
`98`	`98`	`* @param bool $methodResult`
`99`	`99`	`* @param bool $expectedResult`
`100`	`100`	`* @return void`
`101`		`- * @dataProvider testAfterCheckDataProviderNoAreaCode`
	`101`	`+ * @dataProvider afterCheckDataProviderNoAreaCode`
`102`	`102`	`*/`
`103`	`103`	`public function testAfterCheckNoArea(bool $config, bool $methodResult, bool $expectedResult)`
`104`	`104`	`{`
`@@ -114,7 +114,7 @@ public function testAfterCheckNoArea(bool $config, bool $methodResult, bool $exp`
`114`	`114`	`*`
`115`	`115`	`* @return array[]`
`116`	`116`	`*/`
`117`		`- public static function testAfterCheckDataProviderNoAreaCode()`
	`117`	`+ public static function afterCheckDataProviderNoAreaCode()`
`118`	`118`	`{`
`119`	`119`	`return [`
`120`	`120`	`['config' => true, 'methodResult' => true, 'expectedResult' => true],`
Original file line number	Diff line number	Diff line change
`@@ -208,7 +208,7 @@ function () {`
`208`	`208`	`}`
`209`	`209`
`210`	`210`	`/**`
`211`		`- * @dataProvider testIsMultiThreadsExecuteDataProvider`
	`211`	`+ * @dataProvider isMultiThreadsExecuteDataProvider`
`212`	`212`	`* @param $threadsCount`
`213`	`213`	`* @param $expectedResult`
`214`	`214`	`* @return void`
`@@ -230,7 +230,7 @@ public function testIsMultiThreadsExecute($threadsCount, $expectedResult): void`
`230`	`230`	`$this->assertEquals($expectedResult, $processManager->isMultiThreadsExecute());`
`231`	`231`	`}`
`232`	`232`
`233`		`- public static function testIsMultiThreadsExecuteDataProvider(): array`
	`233`	`+ public static function isMultiThreadsExecuteDataProvider(): array`
`234`	`234`	`{`
`235`	`235`	`return [`
`236`	`236`	`'threadsCount is null' => [null, false],`