ACQE-8831: [MFTF TESTS] StorefrontMultishippingCheckoutWithOnlineShippingMethodTest

- Refactor selectors and async checks by moving selectors to Section files and replacing seeElement with waitForElementVisible for improved MFTF compliance.

Author: mohit-adobe

app/code/Magento/Multishipping/Test/Mftf/Section/ShippingMethodSection.xml

@@ -14,5 +14,7 @@
         <element name="shippingMethod" type="radio" selector="//div[@class='block block-shipping'][position()={{shippingBlockPosition}}]//dd[position()={{shippingMethodPosition}}]" parameterized="true" timeout="5"/>
         <element name="goToBillingInfo" type="button" selector=".action.primary.continue"/>
         <element name="productDetails" type="text" selector="//a[text()='{{var1}}']/../../..//td[@class='col qty' and text()='{{var2}}']" parameterized="true"/>
+        <element name="firstShippingMethodForCity" type="radio" selector="//form[contains(@id, 'shipping_method_form')]//address[contains(., '{{city}}')]/ancestor::div[contains(@class, 'block-content')]//div[contains(@class, 'box-shipping-method')]//input[@type='radio'][1]" parameterized="true" timeout="30"/>
+        <element name="shippingMethodBoxForCity" type="block" selector="//form[contains(@id, 'shipping_method_form')]//address[contains(., '{{city}}')]/ancestor::div[contains(@class, 'block-content')]//div[contains(@class, 'box-shipping-method')]" parameterized="true" timeout="30"/>
     </section>
 </sections>

app/code/Magento/Multishipping/Test/Mftf/Section/StorefrontMultishippingCheckoutOverviewReviewSection.xml

@@ -10,5 +10,6 @@
           xsi:noNamespaceSchemaLocation="urn:magento:mftf:Page/etc/SectionObject.xsd">
     <section name="StorefrontMultishippingCheckoutOverviewReviewSection">
         <element name="placeOrder" type="button" selector="button.action.primary.submit"/>
+        <element name="shippingMethodForCity" type="block" selector="//form[contains(@id, 'review-order-form')]//address[contains(., '{{city}}')]/ancestor::div[contains(@class, 'block-content')]//div[contains(@class, 'box-shipping-method')]" parameterized="true" timeout="30"/>
     </section>
 </sections>

app/code/Magento/Sales/Test/Mftf/Section/AdminOrderShippingInformationSection.xml

@@ -10,6 +10,7 @@
         xsi:noNamespaceSchemaLocation="urn:magento:mftf:Page/etc/SectionObject.xsd">
     <section name="AdminOrderShippingInformationSection">
         <element name="shippingMethod" type="text" selector=".order-shipping-method .admin__page-section-item-content"/>
+        <element name="shippingMethodBlock" type="block" selector=".order-shipping-method"/>
         <element name="shippingPrice" type="text" selector=".order-shipping-method .admin__page-section-item-content .price"/>
     </section>
 </sections>

app/code/Magento/Sales/Test/Mftf/Section/StorefrontOrderDetailsSection.xml

@@ -19,6 +19,7 @@
         <element name="grandTotalPrice" type="text" selector="tr.grand_total span.price"/>
         <element name="paymentMethod" type="text" selector=".box-order-billing-method dt.title"/>
         <element name="shippingMethod" type="text" selector=".box-order-shipping-method div.box-content"/>
+        <element name="shippingMethodBlock" type="block" selector=".box-order-shipping-method"/>
         <element name="productNameCell" type="text" selector="//*[contains(@class, 'product-item-name')]"/>
         <element name="bundleOptionPrice" type="text" selector=".item-options-container td.col.value span.price"/>
         <element name="shippingAddressBlock" type="block" selector=".block-order-details-view .box-order-shipping-address .box-content"/>

app/code/Magento/Shipping/Test/Mftf/ActionGroup/StorefrontSelectShippingMethodBasedOnAddressActionGroup.xml

@@ -13,13 +13,13 @@
             <description>Select first available shipping method for each address to handle dynamic carrier API responses.</description>
         </annotations>
         <!-- Select first available shipping method for Germany/Berlin address -->
-        <waitForElementClickable selector="//form[contains(@id, 'shipping_method_form')]//address[contains(., 'Berlin')]/ancestor::div[contains(@class, 'block-content')]//div[contains(@class, 'box-shipping-method')]//input[@type='radio'][1]" stepKey="waitForBerlinShippingMethod"/>
-        <click selector="//form[contains(@id, 'shipping_method_form')]//address[contains(., 'Berlin')]/ancestor::div[contains(@class, 'block-content')]//div[contains(@class, 'box-shipping-method')]//input[@type='radio'][1]" stepKey="clickToSelectBerlinMethod"/>
+        <waitForElementClickable selector="{{ShippingMethodSection.firstShippingMethodForCity('Berlin')}}" stepKey="waitForBerlinShippingMethod"/>
+        <click selector="{{ShippingMethodSection.firstShippingMethodForCity('Berlin')}}" stepKey="clickToSelectBerlinMethod"/>
         <!-- Select first available shipping method for London address -->
-        <click selector="//form[contains(@id, 'shipping_method_form')]//address[contains(., 'London')]/ancestor::div[contains(@class, 'block-content')]//div[contains(@class, 'box-shipping-method')]//input[@type='radio'][1]" stepKey="clickToSelectLondonMethod"/>
+        <click selector="{{ShippingMethodSection.firstShippingMethodForCity('London')}}" stepKey="clickToSelectLondonMethod"/>
         <!-- Select first available shipping method for New York address -->
-        <click selector="//form[contains(@id, 'shipping_method_form')]//address[contains(., 'New York')]/ancestor::div[contains(@class, 'block-content')]//div[contains(@class, 'box-shipping-method')]//input[@type='radio'][1]" stepKey="clickToSelectNewYorkMethod"/>
+        <click selector="{{ShippingMethodSection.firstShippingMethodForCity('New York')}}" stepKey="clickToSelectNewYorkMethod"/>
         <!-- Select first available shipping method for Culver City address -->
-        <click selector="//form[contains(@id, 'shipping_method_form')]//address[contains(., 'Culver City')]/ancestor::div[contains(@class, 'block-content')]//div[contains(@class, 'box-shipping-method')]//input[@type='radio'][1]" stepKey="clickToSelectCulverCityMethod"/>
+        <click selector="{{ShippingMethodSection.firstShippingMethodForCity('Culver City')}}" stepKey="clickToSelectCulverCityMethod"/>
     </actionGroup>
 </actionGroups>

app/code/Magento/Shipping/Test/Mftf/ActionGroup/StorefrontVerifyOrderInformationBeforePlacingOrderActionGroup.xml

@@ -13,13 +13,13 @@
             <description>Before placing order verifying the shipping method is selected for each address.</description>
         </annotations>
         <!-- Verify shipping method is present for Berlin address -->
-        <waitForElementVisible selector="//form[contains(@id, 'review-order-form')]//address[contains(., 'Berlin')]/ancestor::div[contains(@class, 'block-content')]//div[contains(@class, 'box-shipping-method')]" stepKey="waitForBerlinReviewOrderInformation"/>
+        <waitForElementVisible selector="{{StorefrontMultishippingCheckoutOverviewReviewSection.shippingMethodForCity('Berlin')}}" stepKey="waitForBerlinReviewOrderInformation"/>
         <!-- Verify shipping method is present for London address -->
-        <waitForElementVisible selector="//form[contains(@id, 'review-order-form')]//address[contains(., 'London')]/ancestor::div[contains(@class, 'block-content')]//div[contains(@class, 'box-shipping-method')]" stepKey="waitForLondonReviewOrderInformation"/>
+        <waitForElementVisible selector="{{StorefrontMultishippingCheckoutOverviewReviewSection.shippingMethodForCity('London')}}" stepKey="waitForLondonReviewOrderInformation"/>
         <!-- Verify shipping method is present for New York address -->
-        <waitForElementVisible selector="//form[contains(@id, 'review-order-form')]//address[contains(., 'New York')]/ancestor::div[contains(@class, 'block-content')]//div[contains(@class, 'box-shipping-method')]" stepKey="waitForNewYorkReviewOrderInformation"/>
+        <waitForElementVisible selector="{{StorefrontMultishippingCheckoutOverviewReviewSection.shippingMethodForCity('New York')}}" stepKey="waitForNewYorkReviewOrderInformation"/>
         <!-- Verify shipping method is present for Culver City address -->
-        <waitForElementVisible selector="//form[contains(@id, 'review-order-form')]//address[contains(., 'Culver City')]/ancestor::div[contains(@class, 'block-content')]//div[contains(@class, 'box-shipping-method')]" stepKey="waitForCulverCityReviewOrderInformation"/>
+        <waitForElementVisible selector="{{StorefrontMultishippingCheckoutOverviewReviewSection.shippingMethodForCity('Culver City')}}" stepKey="waitForCulverCityReviewOrderInformation"/>
         <waitForElementClickable selector="{{AdminShipmentAddressInformationSection.placeOrder}}" stepKey="waitForPlaceOrder"/>
     </actionGroup>
 </actionGroups>

app/code/Magento/Shipping/Test/Mftf/Test/StorefrontMultishippingCheckoutWithOnlineShippingMethodTest.xml

@@ -111,7 +111,7 @@
             </actionGroup>
             <waitForElementVisible selector="{{AdminShipmentAddressInformationSection.orderInformationAddress('Berlin')}}" stepKey="waitForOrderInformationForBerlin"/>
             <!-- Verify shipping method section exists without checking specific method name -->
-            <seeElement selector=".box-order-shipping-method" stepKey="seeShippingMethodForFirstOrder"/>
+            <waitForElementVisible selector="{{StorefrontOrderDetailsSection.shippingMethodBlock}}" stepKey="waitForShippingMethodForFirstOrder"/>
             <actionGroup ref="StorefrontOpenMyOrdersPageActionGroup" stepKey="goToMyOrdersForSecondOrder"/>
             <actionGroup ref="StorefrontOpenOrderLinkOnMyOrdersPageActionGroup" stepKey="openSecondOrder">
                 <argument name="orderID" value="{$secondOrderID}"/>
@@ -121,7 +121,7 @@
             </actionGroup>
             <waitForElementVisible selector="{{AdminShipmentAddressInformationSection.orderInformationAddress('London')}}" stepKey="waitForOrderInformationForLondon"/>
             <!-- Verify shipping method section exists without checking specific method name -->
-            <seeElement selector=".box-order-shipping-method" stepKey="seeShippingMethodForSecondOrder"/>
+            <waitForElementVisible selector="{{StorefrontOrderDetailsSection.shippingMethodBlock}}" stepKey="waitForShippingMethodForSecondOrder"/>
             <actionGroup ref="StorefrontOpenMyOrdersPageActionGroup" stepKey="goToMyOrdersForThirdOrder"/>
             <actionGroup ref="StorefrontOpenOrderLinkOnMyOrdersPageActionGroup" stepKey="openThirdOrder">
                 <argument name="orderID" value="{$thirdOrderID}"/>
@@ -131,7 +131,7 @@
             </actionGroup>
             <waitForElementVisible selector="{{AdminShipmentAddressInformationSection.orderInformationAddress('New York')}}" stepKey="waitForOrderInformationForNY"/>
             <!-- Verify shipping method section exists without checking specific method name -->
-            <seeElement selector=".box-order-shipping-method" stepKey="seeShippingMethodForThirdOrder"/>
+            <waitForElementVisible selector="{{StorefrontOrderDetailsSection.shippingMethodBlock}}" stepKey="waitForShippingMethodForThirdOrder"/>
             <actionGroup ref="StorefrontOpenMyOrdersPageActionGroup" stepKey="goToMyOrdersForFourthOrder"/>
             <actionGroup ref="StorefrontOpenOrderLinkOnMyOrdersPageActionGroup" stepKey="openFourthOrder">
                 <argument name="orderID" value="{$fourthOrderID}"/>
@@ -141,36 +141,36 @@
             </actionGroup>
             <waitForElementVisible selector="{{AdminShipmentAddressInformationSection.orderInformationAddress('Culver City')}}" stepKey="waitForOrderInformationForCulverCity"/>
             <!-- Verify shipping method section exists without checking specific method name -->
-            <seeElement selector=".box-order-shipping-method" stepKey="seeShippingMethodForFourthOrder"/>
+            <waitForElementVisible selector="{{StorefrontOrderDetailsSection.shippingMethodBlock}}" stepKey="waitForShippingMethodForFourthOrder"/>
             <!-- Go to Admin and check order information -->
             <actionGroup ref="FilterOrderGridByIdActionGroup" stepKey="filterFirstOrderGrid">
                 <argument name="orderId" value="{$grabOrderIdForFirstOrder}"/>
             </actionGroup>
             <actionGroup ref="AdminOrderGridClickFirstRowActionGroup" stepKey="clickFirstOrderRow"/>
             <waitForElementVisible selector="{{AdminShipmentAddressInformationSection.adminOrderShippingAddress('Berlin')}}" stepKey="waitForAdminOrderInformationForBerlin"/>
             <!-- Verify shipping method section exists without checking specific method name -->
-            <seeElement selector=".order-shipping-method" stepKey="seeAdminShippingMethodForFirstOrder"/>
+            <waitForElementVisible selector="{{AdminOrderShippingInformationSection.shippingMethodBlock}}" stepKey="waitForAdminShippingMethodForFirstOrder"/>
             <actionGroup ref="FilterOrderGridByIdActionGroup" stepKey="filterSecondOrderGrid">
                 <argument name="orderId" value="{$grabOrderIdForSecondOrder}"/>
             </actionGroup>
             <actionGroup ref="AdminOrderGridClickFirstRowActionGroup" stepKey="clickSecondOrderRow"/>
             <waitForElementVisible selector="{{AdminShipmentAddressInformationSection.adminOrderShippingAddress('London')}}" stepKey="waitForAdminOrderInformationForLondon"/>
             <!-- Verify shipping method section exists without checking specific method name -->
-            <seeElement selector=".order-shipping-method" stepKey="seeAdminShippingMethodForSecondOrder"/>
+            <waitForElementVisible selector="{{AdminOrderShippingInformationSection.shippingMethodBlock}}" stepKey="waitForAdminShippingMethodForSecondOrder"/>
             <actionGroup ref="FilterOrderGridByIdActionGroup" stepKey="filterThirdOrderGrid">
                 <argument name="orderId" value="{$grabOrderIdForThirdOrder}"/>
             </actionGroup>
             <actionGroup ref="AdminOrderGridClickFirstRowActionGroup" stepKey="clickThirdOrderRow"/>
             <waitForElementVisible selector="{{AdminShipmentAddressInformationSection.adminOrderShippingAddress('New York')}}" stepKey="waitForAdminOrderInformationForNY"/>
             <!-- Verify shipping method section exists without checking specific method name -->
-            <seeElement selector=".order-shipping-method" stepKey="seeAdminShippingMethodForThirdOrder"/>
+            <waitForElementVisible selector="{{AdminOrderShippingInformationSection.shippingMethodBlock}}" stepKey="waitForAdminShippingMethodForThirdOrder"/>
             <actionGroup ref="FilterOrderGridByIdActionGroup" stepKey="filterFourthOrderGrid">
                 <argument name="orderId" value="{$grabOrderIdForFourthOrder}"/>
             </actionGroup>
             <actionGroup ref="AdminOrderGridClickFirstRowActionGroup" stepKey="clickFourthOrderRow"/>
             <waitForElementVisible selector="{{AdminShipmentAddressInformationSection.adminOrderShippingAddress('Culver City')}}" stepKey="waitForAdminOrderInformationForCulver"/>
             <!-- Verify shipping method section exists without checking specific method name -->
-            <seeElement selector=".order-shipping-method" stepKey="seeAdminShippingMethodForFourthOrder"/>
+            <waitForElementVisible selector="{{AdminOrderShippingInformationSection.shippingMethodBlock}}" stepKey="waitForAdminShippingMethodForFourthOrder"/>
             <actionGroup ref="AdminOrdersGridClearFiltersActionGroup" stepKey="clearOrderFilters"/>
         <after>
             <actionGroup ref="AdminDisableUSPSActionGroup" stepKey="disableUSPS"/>