From 571a0ede9aa38087e831d715e1422931263f887a Mon Sep 17 00:00:00 2001 From: YuriyRyabikov <22548029+kurok@users.noreply.github.com> Date: Fri, 13 Mar 2026 09:20:15 +0000 Subject: [PATCH] fix: follow autoconf conventions for --enable/--disable help output Use --disable-liblsof (default=yes feature) instead of --enable-liblsof and remove redundant [default=...] annotations from --enable-security and --enable-no-sock-security (default=no features). This follows the GNU convention: advertise only the option that changes behavior away from the default. Closes #325 --- configure.ac | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/configure.ac b/configure.ac index 2b437fb9..bf052401 100644 --- a/configure.ac +++ b/configure.ac @@ -256,20 +256,20 @@ AC_DEFINE([API_EXPORT], [__attribute__ ((visibility ("default")))], [Set visibility to default for exported API functions.]) # --enable-liblsof to install liblsof -AC_ARG_ENABLE(liblsof, AS_HELP_STRING([--enable-liblsof], - [build and install liblsof @<:@default=yes@:>@]), [], [enable_liblsof=yes]) +AC_ARG_ENABLE(liblsof, AS_HELP_STRING([--disable-liblsof], + [do not build and install liblsof]), [], [enable_liblsof=yes]) AM_CONDITIONAL([INSTALL_LIBLSOF], [test "x$enable_liblsof" = xyes]) # --enable-security to define HASSECURITY AC_ARG_ENABLE(security, AS_HELP_STRING([--enable-security], - [allow only the root user to list all open files @<:@default=no@:>@]), [], [enable_security=no]) + [allow only the root user to list all open files]), [], [enable_security=no]) AS_IF([test "x$enable_security" = xyes], [ CFLAGS="$CFLAGS -DHASSECURITY" ]) # --enable-no-sock-security to define HASNOSOCKSECURITY AC_ARG_ENABLE(no_sock_security, AS_HELP_STRING([--enable-no-sock-security], - [combined with --enable-security, allow anyone to list anyone else's socket files @<:@default=no@:>@]), [], [enable_no_sock_security=no]) + [combined with --enable-security, allow anyone to list anyone else's socket files]), [], [enable_no_sock_security=no]) AS_IF([test "x$enable_no_sock_security" = xyes], [ AS_IF([test "x$enable_security" = xyes], [ CFLAGS="$CFLAGS -DHASNOSOCKSECURITY"