Skip to content

Commit 830af33

Browse files
committed
Settings: promote Live Activity to top-level menu under Alert Management
Moved the 'Live activity' NavigationLink out of AlertManagementView and into SettingsView's alertManagementSection, directly below the Alert Management row. Both now share a Section using the LargeButton style. The new Live Activity row uses 'rectangle.on.rectangle' as the icon and the descriptive text 'Lock Screen, Dynamic Island, and CarPlay display'. Rationale: Live Activity is an output/display concern, not an alert permission concern, so users were unlikely to look for it inside Alert Management. Surfacing it at the top level makes it discoverable.
1 parent 72dc623 commit 830af33

2 files changed

Lines changed: 13 additions & 5 deletions

File tree

Loop/Views/AlertManagementView.swift

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -98,11 +98,6 @@ struct AlertManagementView: View {
9898
}
9999
}
100100
}
101-
102-
NavigationLink(destination: LiveActivityManagementView())
103-
{
104-
Text(NSLocalizedString("Live activity", comment: "Alert Permissions live activity"))
105-
}
106101
}
107102
}
108103

Loop/Views/SettingsView.swift

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -317,6 +317,19 @@ extension SettingsView {
317317
)
318318
.accessibilityIdentifier("settingsViewAlertManagement")
319319
}
320+
NavigationLink(destination: LiveActivityManagementView()) {
321+
LargeButton(
322+
action: {},
323+
includeArrow: false,
324+
imageView: Image(systemName: "rectangle.on.rectangle")
325+
.resizable()
326+
.aspectRatio(contentMode: .fit)
327+
.frame(width: 30),
328+
label: NSLocalizedString("Live Activity", comment: "Live Activity settings button text"),
329+
descriptiveText: NSLocalizedString("Lock Screen, Dynamic Island, and CarPlay display", comment: "Live Activity settings descriptive text")
330+
)
331+
.accessibilityIdentifier("settingsViewLiveActivity")
332+
}
320333
}
321334
}
322335

0 commit comments

Comments
 (0)