From 5ac4ee6c1c5a1a1a2054e2e25effaaa332d41be6 Mon Sep 17 00:00:00 2001 From: Ruben Nogueira Date: Wed, 26 Mar 2025 16:27:02 +0000 Subject: [PATCH 1/2] fix: invalid filter --- lib/sql.js | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/lib/sql.js b/lib/sql.js index e4479c19..3469c376 100644 --- a/lib/sql.js +++ b/lib/sql.js @@ -1125,17 +1125,19 @@ SQLConnector.prototype._buildWhere = function(model, where) { if (Array.isArray(clauses)) { for (let i = 0, n = clauses.length; i < n; i++) { const stmtForClause = self._buildWhere(model, clauses[i]); - if (stmtForClause.sql) { + if (stmtForClause.sql) { // first case, getting into () stmtForClause.sql = '(' + stmtForClause.sql + ')'; branchParams = branchParams.concat(stmtForClause.params); branches.push(stmtForClause.sql); } } - stmt.merge({ - sql: '(' + branches.join(' ' + key.toUpperCase() + ' ') + ')', - params: branchParams, - }); - whereStmts.push(stmt); + if (branches.length > 0) { + stmt.merge({ + sql: '(' + branches.join(' ' + key.toUpperCase() + ' ') + ')', + params: branchParams, + }); + whereStmts.push(stmt); + } continue; } // The value is not an array, fall back to regular fields From d1ea01edfa29dea533704571bd30fff0f66c342b Mon Sep 17 00:00:00 2001 From: Ruben Nogueira Date: Wed, 26 Mar 2025 17:56:56 +0000 Subject: [PATCH 2/2] fix: invalid filter --- lib/sql.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/sql.js b/lib/sql.js index 3469c376..65a0b098 100644 --- a/lib/sql.js +++ b/lib/sql.js @@ -1125,7 +1125,7 @@ SQLConnector.prototype._buildWhere = function(model, where) { if (Array.isArray(clauses)) { for (let i = 0, n = clauses.length; i < n; i++) { const stmtForClause = self._buildWhere(model, clauses[i]); - if (stmtForClause.sql) { // first case, getting into () + if (stmtForClause.sql) { stmtForClause.sql = '(' + stmtForClause.sql + ')'; branchParams = branchParams.concat(stmtForClause.params); branches.push(stmtForClause.sql);