fix: Make flush thread a daemon thread to prevent shutdown hang (#102)

Co-authored-by: Stephen Hawkins <stephen.hawkins@Stephen-Hawkins.local>

Author: shawkinsmezmo

logdna/logdna.py

@@ -78,8 +78,8 @@ def __init__(self, key, options={}):
 
         # Start the flusher
         self.flusher_stopped = threading.Event()
-        self.flusher = threading.Timer(
-            self.flush_interval_secs, self.flush_timer_worker)
+        self.flusher = threading.Thread(
+            target=self.flush_timer_worker, daemon=True)
         self.flusher.start()
 
     def flush_timer_worker(self):
@@ -93,7 +93,7 @@ def flush_timer_worker(self):
     def close_flusher(self):
         if self.flusher:
             self.flusher_stopped.set()
-            self.flusher.cancel()
+            self.flusher.join()
             self.flusher = None
 
     def buffer_log(self, message):

tests/test_logger.py

@@ -320,6 +320,11 @@ def get_sample_record(id):
         self.assertEqual(len(received), num_logs)
         self.assertEquals(set(received), set(range(num_logs)))
 
+    def test_when_handlerShutDown_then_handlerDoesNotHang(self):
+        handler = LogDNAHandler(LOGDNA_API_KEY, sample_options)
+        self.assertIsNotNone(handler)
+        # Do nothing. This test should pass by virtue of not hanging.
+
 
 if __name__ == '__main__':
     unittest.main()