Skip to content

Commit e6eed8b

Browse files
committed
Make OPT_fmatrix_memory_layout_EQ a ForwardedArguments in RenderHLSLOptions. Then set it via HLSLToolChain::TranslateArgs.
1 parent 754f83c commit e6eed8b

File tree

2 files changed

+15
-4
lines changed

2 files changed

+15
-4
lines changed

clang/lib/Driver/ToolChains/Clang.cpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3709,6 +3709,7 @@ static void RenderHLSLOptions(const ArgList &Args, ArgStringList &CmdArgs,
37093709
options::OPT_disable_llvm_passes,
37103710
options::OPT_fnative_half_type,
37113711
options::OPT_fnative_int16_type,
3712+
options::OPT_fmatrix_memory_layout_EQ,
37123713
options::OPT_hlsl_entrypoint,
37133714
options::OPT_fdx_rootsignature_define,
37143715
options::OPT_fdx_rootsignature_version,
@@ -3723,10 +3724,6 @@ static void RenderHLSLOptions(const ArgList &Args, ArgStringList &CmdArgs,
37233724
if (!Args.hasArg(options::OPT_dxc_no_stdinc) &&
37243725
!Args.hasArg(options::OPT_nostdinc))
37253726
CmdArgs.push_back("-finclude-default-header");
3726-
if (Args.hasArg(options::OPT_dxc_col_major))
3727-
CmdArgs.push_back("-fmatrix-memory-layout=column-major");
3728-
if (Args.hasArg(options::OPT_dxc_row_major))
3729-
CmdArgs.push_back("-fmatrix-memory-layout=row-major");
37303727
}
37313728

37323729
static void RenderOpenACCOptions(const Driver &D, const ArgList &Args,

clang/lib/Driver/ToolChains/HLSL.cpp

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -510,6 +510,20 @@ HLSLToolChain::TranslateArgs(const DerivedArgList &Args, StringRef BoundArch,
510510
A->claim();
511511
continue;
512512
}
513+
if (A->getOption().getID() == options::OPT_dxc_col_major) {
514+
DAL->AddSeparateArg(nullptr,
515+
Opts.getOption(options::OPT_fmatrix_memory_layout_EQ),
516+
"column-major");
517+
A->claim();
518+
continue;
519+
}
520+
if (A->getOption().getID() == options::OPT_dxc_row_major) {
521+
DAL->AddSeparateArg(nullptr,
522+
Opts.getOption(options::OPT_fmatrix_memory_layout_EQ),
523+
"row-major");
524+
A->claim();
525+
continue;
526+
}
513527

514528
DAL->append(A);
515529
}

0 commit comments

Comments
 (0)