Hotfix: getJoinedDomains and getInstalledPrinters not working

Author: dorianim

debian/changelog

@@ -1,3 +1,9 @@
+linuxmuster-linuxclient7 (1.1.2) lmn73; urgency=high
+
+  * Hotfix: getJoinedDomains and getInstalledPrinters not working
+
+ -- Dorian Zedler <dorian@itsblue.de>  Sun, 16 Nov 2025 19:09:06 +0200
+
 linuxmuster-linuxclient7 (1.1.1) lmn73; urgency=medium
 
   * Fix onLogin hook on Debian 13 (#90)

usr/lib/python3/dist-packages/linuxmusterLinuxclient7/printers.py

@@ -91,7 +91,7 @@ def _getInstalledPrintersOfUser(username):
     command = ["lpstat", "-U", username, "-p"]
     #logging.debug(f"running '{command}'")
 
-    result = subprocess.run(command, stdout=subprocess.PIPE, stderr=subprocess.PIPE, universal_newlines=True, shell=True)
+    result = subprocess.run(command, stdout=subprocess.PIPE, stderr=subprocess.PIPE, universal_newlines=True)
 
     if not result.returncode == 0:
         logging.info("No Printers installed.")

usr/lib/python3/dist-packages/linuxmusterLinuxclient7/realm.py

@@ -115,7 +115,7 @@ def getJoinedDomains():
     :return: Tuple (success, list of joined domians)
     :rtype: tuple
     """
-    result = subprocess.run(["realm", "list", "--name-only"], stdout=subprocess.PIPE, stderr=subprocess.PIPE, universal_newlines=True, shell=True)
+    result = subprocess.run(["realm", "list", "--name-only"], stdout=subprocess.PIPE, stderr=subprocess.PIPE, universal_newlines=True)
 
     if result.returncode != 0:
         logging.error("Failed to read domain joins!")
@@ -155,7 +155,7 @@ def getDomainConfig(domain):
     :return: Tuple (success, dict with domain config)
     :rtype: tuple
     """
-    result = subprocess.run(["adcli", "info", domain], stdout=subprocess.PIPE, stderr=subprocess.PIPE, universal_newlines=True, shell=True)
+    result = subprocess.run(["adcli", "info", domain], stdout=subprocess.PIPE, stderr=subprocess.PIPE, universal_newlines=True)
 
     if result.returncode != 0:
         logging.error(f"Failed to get details of domain {domain}!")