Skip to content

Commit b7639f1

Browse files
committed
st-entry.c: Disable cursor blink.
There is an issue with ClutterText not receiving the correct text direction, and creating an invalid layout, which results in a crash if the user types in a RTL language while the cursor is hidden. Muffin currently relies on gtk3 translations to get the correct direction. These may not even be installed if the user is only using a RTL keyboard layout, and not the actual language on their system. Also, gtk3 translations rely on language-pack-gnome* in Mint/Ubuntu: const char *e = g_dgettext ("gtk30", "default:LTR"); For now, disable blinking entirely for StEntry actors until this source of confusion can be eliminated. ref: #13086, #12248, #12949, #11220, #12816, #12753.
1 parent 20ecec7 commit b7639f1

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/st/st-entry.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -533,6 +533,8 @@ cursor_blinks (StEntry *entry)
533533
{
534534
StEntryPrivate *priv = entry->priv;
535535

536+
return FALSE;
537+
536538
if (clutter_actor_has_key_focus (CLUTTER_ACTOR (priv->entry)) &&
537539
clutter_text_get_editable (CLUTTER_TEXT (priv->entry)) &&
538540
clutter_text_get_selection_bound (CLUTTER_TEXT (priv->entry)) == clutter_text_get_cursor_position (CLUTTER_TEXT (priv->entry)))

0 commit comments

Comments
 (0)