From 9ecc04588294b0994ab5b38e753d433dfd9b09f3 Mon Sep 17 00:00:00 2001 From: Cyril Hrubis Date: Tue, 26 Aug 2025 14:12:20 +0200 Subject: [PATCH] Make KILL properly terminate all forked processes If the process we executed with ltx_handle_exec() forks children these did escape the attempt to kill these with ltx_handle_kill() because we only killed the parent, the children were reparented to init and may continue to run happily ever after. Since the parent process was killed we wait() on it and we got stuck in the read() that gets rest of the log from the pipe the stderr and stdout of the executed process is redirected to. That is because the pipe stil has writers active as long as any child process is active. If the main shell on the system was from busybox this happend for any executed command since busybox forks and executes in each case. To fix it, we move the top process in the slot into a seprate process group and the kill command kills a process group rather than a single process. In order to make sure that the process is moved into right process group right after the fork we move it both in the parent and in the child. We need it to move there in the parent in a case that subsequent command is kill and terminate the process before it has a chance to run. We need to make the move in the child because in case it runs before the parent (ltx process) we need the process group right before we may possibly fork any children. Signed-off-by: Cyril Hrubis --- ltx.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/ltx.c b/ltx.c index 68a93c9..0d46c46 100644 --- a/ltx.c +++ b/ltx.c @@ -735,11 +735,14 @@ static void ltx_handle_exec(struct ltx_session *session) /* setup parent */ if (pid) { + setpgid(pid, pid); close(pipefd[1]); exec_slot->pid = pid; return; } + setpgid(0, 0); + /* redirect stdout to pipe */ if (dup2(pipefd[1], STDOUT_FILENO) == -1) { LTX_HANDLE_ERROR(session, "dup2() stdout", 1); @@ -915,7 +918,7 @@ static void ltx_handle_kill(struct ltx_session *session) if (exec_slot->pid == -1) return; - int ret = kill(exec_slot->pid, SIGKILL); + int ret = kill(-exec_slot->pid, SIGKILL); if (ret == -1 && errno != ESRCH) { LTX_HANDLE_ERROR(session, "kill() error", 1); return;