buffer_head: fail fast on repeated reads after I/O errors#804
Open
blktests-ci[bot] wants to merge 1 commit into
Open
buffer_head: fail fast on repeated reads after I/O errors#804blktests-ci[bot] wants to merge 1 commit into
blktests-ci[bot] wants to merge 1 commit into
Conversation
Author
|
Upstream branch: 6d35786 |
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
1f0d33a to
b1870f6
Compare
Author
|
Upstream branch: aa54b1d |
blktests-ci
Bot
force-pushed
the
series/1090493=>linus-master
branch
from
0ea9500 to
7b5211f
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
b1870f6 to
ca57796
Compare
Author
|
Upstream branch: 70eda68 |
blktests-ci
Bot
force-pushed
the
series/1090493=>linus-master
branch
from
7b5211f to
2a21698
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
ca57796 to
c1feb59
Compare
Author
|
Upstream branch: 8bc67e4 |
blktests-ci
Bot
force-pushed
the
series/1090493=>linus-master
branch
from
2a21698 to
5cd5116
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
c1feb59 to
ea833a1
Compare
Author
|
Upstream branch: 6779b50 |
blktests-ci
Bot
force-pushed
the
series/1090493=>linus-master
branch
from
5cd5116 to
77b1273
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
ea833a1 to
7af85d1
Compare
Author
|
Upstream branch: 79bd2dd |
blktests-ci
Bot
force-pushed
the
series/1090493=>linus-master
branch
from
77b1273 to
f29666e
Compare
blktests-ci
Bot
force-pushed
the
linus-master_base
branch
from
7af85d1 to
de94ac7
Compare
Author
|
Upstream branch: eed108e |
A failed buffer_head read leaves the buffer !Uptodate. If multiple threads hit that same buffer_head, they serialize on BH_Lock and each one re-submits the same read after the previous owner drops the lock. If the device is slow to return the error, this can turn one bad block into long stalls and repeated slow I/O. Trying to remember bad LBAs in block or drivers would need a generic per-device table with lookup, eviction, and lifetime rules. For buffer_head users, keep the failure state with the cached buffer_head instead. Track non-readahead read I/O errors in buffer_head with a dedicated bit and a failure timestamp. Update this state from the bio completion path. Add an optional per-bdev retry window: within the window, non-readahead submit_bh() reads complete immediately with failure for a buffer_head that recently saw a non-readahead read error. A successful read or rewrite clears the state. The timestamp is recorded on the first error only, so repeated failures do not extend the window. Once the window expires, the next read is submitted normally and can discover that the device or media has recovered. Configure per block device via sysfs: /sys/block/<disk>/read_err_retry_sec /sys/block/<disk>/<part>/read_err_retry_sec Default is 0, preserving existing behavior. Disk and partition values are independent, and values larger than MAX_JIFFY_OFFSET / HZ are rejected to avoid jiffies overflow. Link: https://lore.kernel.org/linux-ext4/20260325093349.630193-1-diangangli@gmail.com/ Signed-off-by: Diangang Li <lidiangang@bytedance.com>
blktests-ci
Bot
force-pushed
the
series/1090493=>linus-master
branch
from
f29666e to
8338515
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: buffer_head: fail fast on repeated reads after I/O errors
version: 1
url: https://patchwork.kernel.org/project/linux-block/list/?series=1090493