f rename

Author: TheBlueMatt

lightning/src/chain/channelmonitor.rs

@@ -4579,7 +4579,7 @@ impl<Signer: EcdsaChannelSigner> ChannelMonitorImpl<Signer> {
 		nondust_htlcs: Vec<HTLCOutputInCommitment>,
 	) -> CommitmentTransaction {
 		let channel_parameters = &channel_parameters.as_counterparty_broadcastable();
-		CommitmentTransaction::new_without_broadcaster_value(
+		CommitmentTransaction::new_without_broadcaster_offchain_value(
 			commitment_number,
 			their_per_commitment_point,
 			to_broadcaster_value,

lightning/src/ln/chan_utils.rs

@@ -1375,7 +1375,7 @@ impl HolderCommitmentTransaction {
 		for _ in 0..nondust_htlcs.len() {
 			counterparty_htlc_sigs.push(dummy_sig);
 		}
-		let inner = CommitmentTransaction::new_without_broadcaster_value(
+		let inner = CommitmentTransaction::new_without_broadcaster_offchain_value(
 			0, &dummy_key, 0, 0, 0, nondust_htlcs, &channel_parameters.as_counterparty_broadcastable(), &secp_ctx
 		);
 		HolderCommitmentTransaction {
@@ -1728,7 +1728,7 @@ impl CommitmentTransaction {
 		)
 	}
 
-	pub(crate) fn new_without_broadcaster_value(
+	pub(crate) fn new_without_broadcaster_offchain_value(
 		commitment_number: u64, per_commitment_point: &PublicKey, to_broadcaster_value_sat: u64,
 		to_countersignatory_value_sat: u64, feerate_per_kw: u32,
 		nondust_htlcs: Vec<HTLCOutputInCommitment>,
@@ -2385,7 +2385,7 @@ mod tests {
 
 		#[rustfmt::skip]
 		fn build(&self, to_broadcaster_sats: u64, to_countersignatory_sats: u64, nondust_htlcs: Vec<HTLCOutputInCommitment>) -> CommitmentTransaction {
-			CommitmentTransaction::new_without_broadcaster_value(
+			CommitmentTransaction::new_without_broadcaster_offchain_value(
 				self.commitment_number, &self.per_commitment_point, to_broadcaster_sats, to_countersignatory_sats, self.feerate_per_kw,
 				nondust_htlcs, &self.channel_parameters.as_holder_broadcastable(), &self.secp_ctx
 			)

lightning/src/ln/htlc_reserve_unit_tests.rs

@@ -2346,7 +2346,7 @@ pub fn do_test_dust_limit_fee_accounting(can_afford: bool) {
 				get_channel_ref!(nodes[0], nodes[1], per_peer_lock, peer_state_lock, chan_id);
 			let chan_signer = channel.as_funded().unwrap().get_signer();
 
-			let commitment_tx = CommitmentTransaction::new_without_broadcaster_value(
+			let commitment_tx = CommitmentTransaction::new_without_broadcaster_offchain_value(
 				commitment_number,
 				&remote_point,
 				node_1_balance_sat,

lightning/src/ln/update_fee_tests.rs

@@ -489,7 +489,7 @@ pub fn do_test_update_fee_that_funder_cannot_afford(channel_type_features: Chann
 		let local_chan_signer = local_chan.as_funded().unwrap().get_signer();
 
 		let nondust_htlcs: Vec<HTLCOutputInCommitment> = vec![];
-		let commitment_tx = CommitmentTransaction::new_without_broadcaster_value(
+		let commitment_tx = CommitmentTransaction::new_without_broadcaster_offchain_value(
 			INITIAL_COMMITMENT_NUMBER - 1,
 			&remote_point,
 			push_sats,
@@ -590,7 +590,7 @@ pub fn test_update_fee_that_saturates_subs() {
 			get_channel_ref!(nodes[0], nodes[1], per_peer_lock, peer_state_lock, chan_id);
 		let local_chan_signer = local_chan.as_funded().unwrap().get_signer();
 		let nondust_htlcs: Vec<HTLCOutputInCommitment> = vec![];
-		let commitment_tx = CommitmentTransaction::new_without_broadcaster_value(
+		let commitment_tx = CommitmentTransaction::new_without_broadcaster_offchain_value(
 			INITIAL_COMMITMENT_NUMBER,
 			&remote_point,
 			8500,