fixup! Expose per-channel features in ChannelDetails

Make `outbound_htlc_minimum_msat` an `Option<u64>`

This field is `None` before receiving `OpenChannel`/`AcceptChannel`,
so expecting it could panic when `list_channels` is called during
early channel negotiation. Pass through the `Option` directly
instead.

Also re-export `ChannelCounterparty` in `lib.rs` so Rust consumers
can name the type.

Author: enigbe

src/lib.rs

@@ -179,7 +179,9 @@ use types::{
 	HRNResolver, KeysManager, OnionMessenger, PaymentStore, PeerManager, Router, Scorer, Sweeper,
 	Wallet,
 };
-pub use types::{ChannelDetails, CustomTlvRecord, PeerDetails, ReserveType, UserChannelId};
+pub use types::{
+	ChannelCounterparty, ChannelDetails, CustomTlvRecord, PeerDetails, ReserveType, UserChannelId,
+};
 pub use vss_client;
 
 use crate::ffi::maybe_wrap;

src/types.rs

@@ -372,7 +372,10 @@ pub struct ChannelCounterparty {
 	/// payments to us through this channel.
 	pub forwarding_info: Option<CounterpartyForwardingInfo>,
 	/// The smallest value HTLC (in msat) the remote peer will accept, for this channel.
-	pub outbound_htlc_minimum_msat: u64,
+	///
+	/// Will be `None` before we have received the `OpenChannel` or `AcceptChannel` message
+	/// from the remote peer.
+	pub outbound_htlc_minimum_msat: Option<u64>,
 	/// The largest value HTLC (in msat) the remote peer currently will accept, for this channel.
 	pub outbound_htlc_maximum_msat: Option<u64>,
 }
@@ -622,12 +625,7 @@ impl ChannelDetails {
 				features: maybe_wrap(value.counterparty.features),
 				unspendable_punishment_reserve: value.counterparty.unspendable_punishment_reserve,
 				forwarding_info: value.counterparty.forwarding_info,
-				// unwrap safety: This value will be `None` for objects serialized with LDK versions
-				// prior to 0.0.115.
-				outbound_htlc_minimum_msat: value
-					.counterparty
-					.outbound_htlc_minimum_msat
-					.expect("value is set for objects serialized with LDK v0.0.107+"),
+				outbound_htlc_minimum_msat: value.counterparty.outbound_htlc_minimum_msat,
 				outbound_htlc_maximum_msat: value.counterparty.outbound_htlc_maximum_msat,
 			},
 			funding_txo: value.funding_txo.map(|o| o.into_bitcoin_outpoint()),