fix: address PR review feedback

Make Config::min_funding_sats a plain u64 with an explicit default and cover the behavior with a unit test.

AI-assisted-by: Codex

Author: vincenzopalazzo

src/config.rs

@@ -28,6 +28,7 @@ const DEFAULT_LDK_WALLET_SYNC_INTERVAL_SECS: u64 = 30;
 const DEFAULT_FEE_RATE_CACHE_UPDATE_INTERVAL_SECS: u64 = 60 * 10;
 const DEFAULT_PROBING_LIQUIDITY_LIMIT_MULTIPLIER: u64 = 3;
 const DEFAULT_ANCHOR_PER_CHANNEL_RESERVE_SATS: u64 = 25_000;
+const DEFAULT_MIN_FUNDING_SATS: u64 = 1_000;
 
 // The default timeout after which we abort a wallet syncing operation.
 const DEFAULT_BDK_WALLET_SYNC_TIMEOUT_SECS: u64 = 60;
@@ -125,7 +126,7 @@ pub(crate) const LNURL_AUTH_TIMEOUT_SECS: u64 = 15;
 /// | `node_alias`                           | None               |
 /// | `trusted_peers_0conf`                  | []                 |
 /// | `probing_liquidity_limit_multiplier`   | 3                  |
-/// | `min_funding_sats`                     | None               |
+/// | `min_funding_sats`                     | 1000               |
 /// | `anchor_channels_config`               | Some(..)           |
 /// | `route_parameters`                     | None               |
 /// | `tor_config`                           | None               |
@@ -173,12 +174,10 @@ pub struct Config {
 	///
 	/// Channels with funding below this value will be rejected.
 	///
-	/// If unset, the `rust-lightning` default of `1000` sats will be used.
-	///
 	/// Please refer to [`ChannelHandshakeLimits::min_funding_satoshis`] for further details.
 	///
 	/// [`ChannelHandshakeLimits::min_funding_satoshis`]: lightning::util::config::ChannelHandshakeLimits::min_funding_satoshis
-	pub min_funding_sats: Option<u64>,
+	pub min_funding_sats: u64,
 	/// Configuration options pertaining to Anchor channels, i.e., channels for which the
 	/// `option_anchors_zero_fee_htlc_tx` channel type is negotiated.
 	///
@@ -222,7 +221,7 @@ impl Default for Config {
 			announcement_addresses: None,
 			trusted_peers_0conf: Vec::new(),
 			probing_liquidity_limit_multiplier: DEFAULT_PROBING_LIQUIDITY_LIMIT_MULTIPLIER,
-			min_funding_sats: None,
+			min_funding_sats: DEFAULT_MIN_FUNDING_SATS,
 			anchor_channels_config: Some(AnchorChannelsConfig::default()),
 			tor_config: None,
 			route_parameters: None,
@@ -352,9 +351,7 @@ pub(crate) fn default_user_config(config: &Config) -> UserConfig {
 	// will mostly be relevant for inbound channels.
 	let mut user_config = UserConfig::default();
 	user_config.channel_handshake_limits.force_announced_channel_preference = false;
-	if let Some(min_funding_sats) = config.min_funding_sats {
-		user_config.channel_handshake_limits.min_funding_satoshis = min_funding_sats;
-	}
+	user_config.channel_handshake_limits.min_funding_satoshis = config.min_funding_sats;
 	user_config.channel_handshake_config.negotiate_anchors_zero_fee_htlc_tx =
 		config.anchor_channels_config.is_some();
 	user_config.reject_inbound_splices = false;
@@ -653,7 +650,9 @@ pub enum AsyncPaymentsRole {
 mod tests {
 	use std::str::FromStr;
 
-	use super::{may_announce_channel, AnnounceError, Config, NodeAlias, SocketAddress};
+	use super::{
+		default_user_config, may_announce_channel, AnnounceError, Config, NodeAlias, SocketAddress,
+	};
 
 	#[test]
 	fn node_announce_channel() {
@@ -700,4 +699,18 @@ mod tests {
 		}
 		assert!(may_announce_channel(&node_config).is_ok());
 	}
+
+	#[test]
+	fn min_funding_sats_configures_user_config() {
+		let mut node_config = Config::default();
+		let user_config = default_user_config(&node_config);
+		assert_eq!(
+			user_config.channel_handshake_limits.min_funding_satoshis,
+			node_config.min_funding_sats
+		);
+
+		node_config.min_funding_sats = 42_000;
+		let user_config = default_user_config(&node_config);
+		assert_eq!(user_config.channel_handshake_limits.min_funding_satoshis, 42_000);
+	}
 }