From bd14d5cded9294511e1dde2e136621e483c54363 Mon Sep 17 00:00:00 2001 From: timyhac Date: Sun, 26 Jan 2025 10:40:32 +1100 Subject: [PATCH] Adds `Status` as a strongly-typed proeprty of `LibPlcTagException`. --- src/libplctag.Tests/AsyncTests.cs | 2 +- src/libplctag.Tests/DisposeTests.cs | 2 +- src/libplctag/LibPlcTagException.cs | 3 +++ 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/libplctag.Tests/AsyncTests.cs b/src/libplctag.Tests/AsyncTests.cs index 67a198b9..028f6a15 100644 --- a/src/libplctag.Tests/AsyncTests.cs +++ b/src/libplctag.Tests/AsyncTests.cs @@ -70,7 +70,7 @@ public async Task Timeout_throws_a_LibPlcTagException() }); // Assert - Assert.Equal(Status.ErrorTimeout.ToString(), ex.Message); + Assert.Equal(Status.ErrorTimeout, ex.Status); } [Fact] diff --git a/src/libplctag.Tests/DisposeTests.cs b/src/libplctag.Tests/DisposeTests.cs index 40a497f1..ea2f2451 100644 --- a/src/libplctag.Tests/DisposeTests.cs +++ b/src/libplctag.Tests/DisposeTests.cs @@ -64,7 +64,7 @@ public async Task GithubIssue418() { await tag.InitializeAsync(); } - catch (Exception e) when (e.Message == "ErrorNotFound") // we are expecting this exception + catch (LibPlcTagException e) when (e.Status == Status.ErrorNotFound) // we are expecting this exception { } } diff --git a/src/libplctag/LibPlcTagException.cs b/src/libplctag/LibPlcTagException.cs index 57d8dae6..8c430168 100644 --- a/src/libplctag/LibPlcTagException.cs +++ b/src/libplctag/LibPlcTagException.cs @@ -15,6 +15,8 @@ namespace libplctag /// public class LibPlcTagException : Exception { + public Status Status { get; } + public LibPlcTagException() { } @@ -32,6 +34,7 @@ public LibPlcTagException(string message, Exception inner) public LibPlcTagException(Status status) : base(status.ToString()) { + Status = status; } } }