Memory review filter_register with Kimi's help

Also define PyMethodDef as static to avoid possible build failures,
and add .vimrc

Author: jdavid

.vimrc

@@ -0,0 +1,16 @@
+" pygit2 local vimrc - C extension configuration
+
+" Get Python include path dynamically
+let s:python_include = system('python3 -c "import sysconfig; print(sysconfig.get_path(''include''))"')[:-2]
+
+" Configure ALE C linters with proper includes
+let g:ale_c_cc_options = '-std=c11 -Wall -I' . s:python_include . ' -I/usr/local/include'
+let g:ale_c_gcc_options = '-std=c11 -Wall -I' . s:python_include . ' -I/usr/local/include'
+let g:ale_c_clang_options = '-std=c11 -Wall -I' . s:python_include . ' -I/usr/local/include'
+
+" If you have libgit2 in a non-standard location, add it:
+" let g:ale_c_cc_options .= ' -I/usr/local/include/git2'
+
+" Optional: Explicitly set which linters to use for C
+let g:ale_linters = get(g:, 'ale_linters', {})
+let g:ale_linters.c = ['cc', 'clangtidy']  " or ['gcc'] if you prefer

src/branch.c

@@ -275,7 +275,7 @@ Branch_upstream_name__get__(Branch *self)
 }
 
 
-PyMethodDef Branch_methods[] = {
+static PyMethodDef Branch_methods[] = {
     METHOD(Branch, delete, METH_NOARGS),
     METHOD(Branch, is_head, METH_NOARGS),
     METHOD(Branch, is_checked_out, METH_NOARGS),

src/diff.c

@@ -236,7 +236,7 @@ PyMemberDef DiffFile_members[] = {
     {NULL}
 };
 
-PyMethodDef DiffFile_methods[] = {
+static PyMethodDef DiffFile_methods[] = {
     METHOD(DiffFile, from_c, METH_STATIC | METH_O),
     {NULL},
 };
@@ -914,7 +914,7 @@ DiffStats_dealloc(DiffStats *self)
     PyObject_Del(self);
 }
 
-PyMethodDef DiffStats_methods[] = {
+static PyMethodDef DiffStats_methods[] = {
     METHOD(DiffStats, format, METH_VARARGS | METH_KEYWORDS),
     {NULL}
 };

src/filter.c

@@ -551,7 +551,9 @@ void pygit2_filter_cleanup(git_filter *self, void *payload)
 void pygit2_filter_shutdown(git_filter *self)
 {
     pygit2_filter *filter = (pygit2_filter *)self;
+
     PyGILState_STATE gil = PyGILState_Ensure();
+    free((void*)filter->filter.attributes);
     Py_DECREF(filter->py_filter_cls);
     free(filter);
     PyGILState_Release(gil);

src/mailmap.c

@@ -188,7 +188,7 @@ Mailmap_dealloc(Mailmap *self)
 }
 
 
-PyMethodDef Mailmap_methods[] = {
+static PyMethodDef Mailmap_methods[] = {
     METHOD(Mailmap, add_entry, METH_VARARGS | METH_KEYWORDS),
     METHOD(Mailmap, resolve, METH_VARARGS),
     METHOD(Mailmap, resolve_signature, METH_VARARGS),

src/note.c

@@ -99,7 +99,7 @@ Note_dealloc(Note *self)
 }
 
 
-PyMethodDef Note_methods[] = {
+static PyMethodDef Note_methods[] = {
     METHOD(Note, remove, METH_VARARGS),
     {NULL}
 };

src/object.c

@@ -302,7 +302,7 @@ PyGetSetDef Object_getseters[] = {
     {NULL}
 };
 
-PyMethodDef Object_methods[] = {
+static PyMethodDef Object_methods[] = {
     METHOD(Object, read_raw, METH_NOARGS),
     METHOD(Object, peel, METH_O),
     {NULL}

src/odb.c

@@ -344,7 +344,7 @@ Odb_add_backend(Odb *self, PyObject *args)
 }
 
 
-PyMethodDef Odb_methods[] = {
+static PyMethodDef Odb_methods[] = {
     METHOD(Odb, add_disk_alternate, METH_O),
     METHOD(Odb, read, METH_O),
     METHOD(Odb, read_header, METH_O),

src/odb_backend.c

@@ -518,7 +518,7 @@ OdbBackend_refresh(OdbBackend *self)
  * - readstream
  * - freshen
  */
-PyMethodDef OdbBackend_methods[] = {
+static PyMethodDef OdbBackend_methods[] = {
     METHOD(OdbBackend, read, METH_O),
     METHOD(OdbBackend, read_prefix, METH_O),
     METHOD(OdbBackend, read_header, METH_O),

src/patch.c

@@ -235,7 +235,7 @@ Patch_hunks__get__(Patch *self)
 }
 
 
-PyMethodDef Patch_methods[] = {
+static PyMethodDef Patch_methods[] = {
     {"create_from", (PyCFunction) Patch_create_from,
       METH_KEYWORDS | METH_VARARGS | METH_STATIC, Patch_create_from__doc__},
     {NULL}