Skip to content

Commit efdb363

Browse files
AArnottethomson
authored andcommitted
Fixed build warnings about System.Net.Http version issues
1 parent 814054b commit efdb363

File tree

2 files changed

+1
-15
lines changed

2 files changed

+1
-15
lines changed

LibGit2Sharp/Core/ManagedHttpSmartSubtransport.cs

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -69,16 +69,9 @@ public ManagedHttpSmartSubtransportStream(ManagedHttpSmartSubtransport parent, s
6969

7070
private HttpClientHandler CreateClientHandler()
7171
{
72-
#if !NETFRAMEWORK
7372
var httpClientHandler = new HttpClientHandler();
7473
httpClientHandler.SslProtocols |= SslProtocols.Tls12;
7574
httpClientHandler.ServerCertificateCustomValidationCallback = CertificateValidationProxy;
76-
#else
77-
var httpClientHandler = new WebRequestHandler();
78-
httpClientHandler.ServerCertificateValidationCallback = CertificateValidationProxy;
79-
80-
ServicePointManager.SecurityProtocol |= SecurityProtocolType.Tls12;
81-
#endif
8275

8376
httpClientHandler.AllowAutoRedirect = false;
8477

LibGit2Sharp/LibGit2Sharp.csproj

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -31,18 +31,11 @@
3131
<Service Include="{508349b6-6b84-4df5-91f0-309beebad82d}" /> <!-- Needed for T4 generation -->
3232
</ItemGroup>
3333

34-
<ItemGroup>
35-
<Reference Include="System.Net.Http" />
36-
<Reference Include="System.Net.Http.WebRequest" />
37-
</ItemGroup>
38-
3934
<ItemGroup>
4035
<PackageReference Include="LibGit2Sharp.NativeBinaries" Version="[2.0.305]" PrivateAssets="none" />
4136
<PackageReference Include="Microsoft.SourceLink.GitHub" Version="1.0.0" PrivateAssets="all" />
4237
<PackageReference Include="Nerdbank.GitVersioning" Version="3.0.50" PrivateAssets="all" />
43-
<PackageReference Include="System.Net.Http" Version="4.3.4">
44-
<ExcludeAssets>All</ExcludeAssets>
45-
</PackageReference>
38+
<PackageReference Include="System.Net.Http" Version="4.3.4" />
4639
</ItemGroup>
4740

4841
<Import Project="..\Targets\CodeGenerator.targets" />

0 commit comments

Comments
 (0)