Support separate push url for remotes

Author: Ryan Roden-Corrent

LibGit2Sharp.Tests/RemoteFixture.cs

@@ -94,6 +94,27 @@ public void CanSetRemoteUrl()
             }
         }
 
+        [Fact]
+        public void CanSetRemotePushUrl()
+        {
+            string path = SandboxBareTestRepo();
+            using (var repo = new Repository(path))
+            {
+                const string name = "upstream";
+                const string url = "https://github.com/libgit2/libgit2sharp.git";
+                const string pushurl = "https://github.com/libgit2/libgit2.git";
+
+                repo.Network.Remotes.Add(name, url);
+                Remote remote = repo.Network.Remotes[name];
+                Assert.NotNull(remote);
+
+                Remote updatedremote = repo.Network.Remotes.Update(remote,
+                    r => r.PushUrl = pushurl);
+
+                Assert.Equal(pushurl, updatedremote.PushUrl);
+            }
+        }
+
         [Fact]
         public void CanCheckEqualityOfRemote()
         {

LibGit2Sharp/Core/NativeMethods.cs

@@ -1075,6 +1075,11 @@ internal static extern int git_remote_set_url(
             RemoteSafeHandle remote,
             [MarshalAs(UnmanagedType.CustomMarshaler, MarshalCookie = UniqueId.UniqueIdentifier, MarshalTypeRef = typeof(StrictUtf8Marshaler))] string url);
 
+        [DllImport(libgit2)]
+        internal static extern int git_remote_set_pushurl(
+            RemoteSafeHandle remote,
+            [MarshalAs(UnmanagedType.CustomMarshaler, MarshalCookie = UniqueId.UniqueIdentifier, MarshalTypeRef = typeof(StrictUtf8Marshaler))] string url);
+
         [DllImport(libgit2)]
         internal static extern int git_remote_is_valid_name(
             [MarshalAs(UnmanagedType.CustomMarshaler, MarshalCookie = UniqueId.UniqueIdentifier, MarshalTypeRef = typeof(StrictUtf8Marshaler))] string remote_name);
@@ -1104,6 +1109,10 @@ internal static extern int git_remote_lookup(
         [return: MarshalAs(UnmanagedType.CustomMarshaler, MarshalCookie = UniqueId.UniqueIdentifier, MarshalTypeRef = typeof(LaxUtf8NoCleanupMarshaler))]
         internal static extern string git_remote_url(RemoteSafeHandle remote);
 
+        [DllImport(libgit2)]
+        [return: MarshalAs(UnmanagedType.CustomMarshaler, MarshalCookie = UniqueId.UniqueIdentifier, MarshalTypeRef = typeof(LaxUtf8NoCleanupMarshaler))]
+        internal static extern string git_remote_pushurl(RemoteSafeHandle remote);
+
         [DllImport(libgit2)]
         internal static extern void git_remote_set_autotag(RemoteSafeHandle remote, TagFetchMode option);
 

LibGit2Sharp/Core/Proxy.cs

@@ -2040,6 +2040,15 @@ public static void git_remote_set_url(RemoteSafeHandle remote, string url)
                 Ensure.ZeroResult(res);
             }
         }
+        
+        public static void git_remote_set_pushurl(RemoteSafeHandle remote, string url)
+        {
+            using (ThreadAffinity())
+            {
+                int res = NativeMethods.git_remote_set_pushurl(remote, url);
+                Ensure.ZeroResult(res);
+            }
+        }
 
         public static void git_remote_fetch(RemoteSafeHandle remote, Signature signature, string logMessage)
         {
@@ -2223,6 +2232,11 @@ public static string git_remote_url(RemoteSafeHandle remote)
             return NativeMethods.git_remote_url(remote);
         }
 
+        public static string git_remote_pushurl(RemoteSafeHandle remote)
+        {
+            return NativeMethods.git_remote_pushurl(remote);
+        }
+
         #endregion
 
         #region git_repository_

LibGit2Sharp/Remote.cs

@@ -15,7 +15,7 @@ namespace LibGit2Sharp
     public class Remote : IEquatable<Remote>, IBelongToARepository
     {
         private static readonly LambdaEqualityHelper<Remote> equalityHelper =
-            new LambdaEqualityHelper<Remote>(x => x.Name, x => x.Url);
+            new LambdaEqualityHelper<Remote>(x => x.Name, x => x.Url, x => x.PushUrl);
 
         internal readonly Repository repository;
 
@@ -32,6 +32,7 @@ private Remote(RemoteSafeHandle handle, Repository repository)
             this.repository = repository;
             Name = Proxy.git_remote_name(handle);
             Url = Proxy.git_remote_url(handle);
+            PushUrl = Proxy.git_remote_pushurl(handle);
             TagFetchMode = Proxy.git_remote_autotag(handle);
             refSpecs = new RefSpecCollection(handle);
         }
@@ -53,6 +54,12 @@ internal static Remote BuildFromPtr(RemoteSafeHandle handle, Repository repo)
         /// </summary>
         public virtual string Url { get; private set; }
 
+        /// <summary>
+        /// Gets the distinct push url for this remote repository, if set.
+        /// If no separate push url is specified, PushUrl is null.
+        /// </summary>
+        public virtual string PushUrl { get; private set; }
+
         /// <summary>
         /// Gets the Tag Fetch Mode of the remote - indicating how tags are fetched.
         /// </summary>

LibGit2Sharp/RemoteUpdater.cs

@@ -76,6 +76,18 @@ public virtual string Url
                 Proxy.git_remote_save(remoteHandle);
             }
         }
+        
+        /// <summary>
+        /// Sets the push url defined for this <see cref="Remote"/>
+        /// </summary>
+        public virtual string PushUrl
+        {
+            set
+            {
+                Proxy.git_remote_set_pushurl(remoteHandle, value);
+                Proxy.git_remote_save(remoteHandle);
+            }
+        }
 
         /// <summary>
         /// Sets the list of <see cref="RefSpec"/>s defined for this <see cref="Remote"/> that are intended to