From 148d985ac06bbc692486bf3de047e79aaa047916 Mon Sep 17 00:00:00 2001 From: evoskuil Date: Thu, 1 Jan 2026 21:35:53 -0500 Subject: [PATCH] Define and use BC_HTTP_SERVER_NAME. --- include/bitcoin/network/settings.hpp | 4 +++- src/net/socket.cpp | 3 ++- test/settings.cpp | 4 ++-- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/include/bitcoin/network/settings.hpp b/include/bitcoin/network/settings.hpp index 7208029e6..61f120abb 100644 --- a/include/bitcoin/network/settings.hpp +++ b/include/bitcoin/network/settings.hpp @@ -25,6 +25,8 @@ #include #include +#define BC_HTTP_SERVER_NAME "libbitcoin/4.0" + namespace libbitcoin { namespace network { @@ -67,7 +69,7 @@ struct BCT_API settings using tcp_server::tcp_server; /// Sent via responses if configured . - std::string server{ "libbitcoin/4.0" }; + std::string server{ BC_HTTP_SERVER_NAME }; /// Validated against hosts/origins if configured. config::endpoints hosts{}; diff --git a/src/net/socket.cpp b/src/net/socket.cpp index f35cbad58..658cee21f 100644 --- a/src/net/socket.cpp +++ b/src/net/socket.cpp @@ -25,6 +25,7 @@ #include #include #include +#include namespace libbitcoin { namespace network { @@ -890,7 +891,7 @@ code socket::set_websocket(const http::request& request) NOEXCEPT [](http::fields& header) NOEXCEPT { // Customize the response header. - header.set(http::field::server, "libbitcoin/4.0"); + header.set(http::field::server, BC_HTTP_SERVER_NAME); } }); diff --git a/test/settings.cpp b/test/settings.cpp index 4e220af8b..7efcb2a81 100644 --- a/test/settings.cpp +++ b/test/settings.cpp @@ -343,7 +343,7 @@ BOOST_AUTO_TEST_CASE(settings__http_server__defaults__expected) BOOST_REQUIRE(instance.expiration() == minutes(60)); // http_server - BOOST_REQUIRE_EQUAL(instance.server, "libbitcoin/4.0"); + BOOST_REQUIRE_EQUAL(instance.server, BC_HTTP_SERVER_NAME); BOOST_REQUIRE(instance.hosts.empty()); BOOST_REQUIRE(instance.origins.empty()); BOOST_REQUIRE(instance.host_names().empty()); @@ -369,7 +369,7 @@ BOOST_AUTO_TEST_CASE(settings__websocket_server__defaults__expected) BOOST_REQUIRE(instance.expiration() == minutes(60)); // http_server - BOOST_REQUIRE_EQUAL(instance.server, "libbitcoin/4.0"); + BOOST_REQUIRE_EQUAL(instance.server, BC_HTTP_SERVER_NAME); BOOST_REQUIRE(instance.hosts.empty()); BOOST_REQUIRE(instance.origins.empty()); BOOST_REQUIRE(instance.host_names().empty());