Apply 'misc-override-with-different-visibility' clang-tidy remarks, align .clang-tidy files in the test directories (#764)

aobolensk · web-flow · commit cdf6a3f806a5 · 2026-03-22T17:25:52.000Z
diff --git a/.clang-tidy b/.clang-tidy
@@ -38,7 +38,6 @@ Checks: >
   -misc-const-correctness,
   -misc-non-private-member-variables-in-classes,
   -modernize-avoid-c-arrays,
-  -misc-override-with-different-visibility,
   -misc-use-internal-linkage,
   -modernize-use-trailing-return-type,
   -portability-avoid-pragma-once,
diff --git a/modules/performance/tests/.clang-tidy b/modules/performance/tests/.clang-tidy
@@ -4,6 +4,7 @@ Checks: >
   -modernize-loop-convert,
   -cppcoreguidelines-avoid-goto,
   -cppcoreguidelines-avoid-non-const-global-variables,
+  -misc-override-with-different-visibility,
   -misc-use-anonymous-namespace,
   -modernize-use-std-print,
   -modernize-type-traits
diff --git a/modules/task/tests/.clang-tidy b/modules/task/tests/.clang-tidy
@@ -4,6 +4,7 @@ Checks: >
   -modernize-loop-convert,
   -cppcoreguidelines-avoid-goto,
   -cppcoreguidelines-avoid-non-const-global-variables,
+  -misc-override-with-different-visibility,
   -misc-use-anonymous-namespace,
   -modernize-use-std-print,
   -modernize-type-traits
diff --git a/modules/task/tests/task_tests.cpp b/modules/task/tests/task_tests.cpp
@@ -45,6 +45,7 @@ class TestTask : public ppc::task::Task<InType, OutType> {
     this->GetInput() = in;
   }
 
+ protected:
   bool ValidationImpl() override {
     return !this->GetInput().empty();
   }
@@ -71,6 +72,7 @@ class FakeSlowTask : public TestTask<InType, OutType> {
  public:
   explicit FakeSlowTask(const InType &in) : TestTask<InType, OutType>(in) {}
 
+ protected:
   bool RunImpl() override {
     std::this_thread::sleep_for(std::chrono::seconds(2));
     return TestTask<InType, OutType>::RunImpl();
@@ -233,9 +235,12 @@ TEST(TaskTest, TaskDestructorThrowsIfStageIncomplete) {
   {
     std::vector<int32_t> in(20, 1);
     struct LocalTask : Task<std::vector<int32_t>, int32_t> {
+     public:
       explicit LocalTask(const std::vector<int32_t> &in) {
         this->GetInput() = in;
       }
+
+     protected:
       bool ValidationImpl() override {
         return true;
       }
@@ -259,9 +264,12 @@ TEST(TaskTest, TaskDestructorThrowsIfEmpty) {
   {
     std::vector<int32_t> in(20, 1);
     struct LocalTask : Task<std::vector<int32_t>, int32_t> {
+     public:
       explicit LocalTask(const std::vector<int32_t> &in) {
         this->GetInput() = in;
       }
+
+     protected:
       bool ValidationImpl() override {
         return true;
       }
@@ -285,9 +293,12 @@ TEST(TaskTest, InternalTimeTestThrowsIfTimeoutExceeded) {
   GTEST_SKIP() << "Skipped on macOS due to time fluctuations.";
 #endif
   struct SlowTask : Task<std::vector<int32_t>, int32_t> {
+   public:
     explicit SlowTask(const std::vector<int32_t> &in) {
       this->GetInput() = in;
     }
+
+   protected:
     bool ValidationImpl() override {
       return true;
     }
@@ -315,6 +326,8 @@ TEST(TaskTest, InternalTimeTestThrowsIfTimeoutExceeded) {
 class DummyTask : public Task<int, int> {
  public:
   using Task::Task;
+
+ protected:
   bool ValidationImpl() override {
     return true;
   }
diff --git a/modules/util/include/func_test_util.hpp b/modules/util/include/func_test_util.hpp
@@ -36,11 +36,6 @@ template <typename InType, typename OutType, typename TestType = void>
 /// @tparam TestType Type of the test case or parameter.
 class BaseRunFuncTests : public ::testing::TestWithParam<FuncTestParam<InType, OutType, TestType>> {
  public:
-  virtual bool CheckTestOutputData(OutType &output_data) = 0;
-  /// @brief Provides input data for the task.
-  /// @return Initialized input data.
-  virtual InType GetTestInputData() = 0;
-
   template <typename Derived>
   static void RequireStaticInterface() {
     static_assert(HasPrintTestParam<Derived, TestType>,
@@ -56,6 +51,11 @@ class BaseRunFuncTests : public ::testing::TestWithParam<FuncTestParam<InType, O
   }
 
  protected:
+  virtual bool CheckTestOutputData(OutType &output_data) = 0;
+  /// @brief Provides input data for the task.
+  /// @return Initialized input data.
+  virtual InType GetTestInputData() = 0;
+
   void ExecuteTest(FuncTestParam<InType, OutType, TestType> test_param) {
     const std::string &test_name = std::get<static_cast<std::size_t>(GTestParamIndex::kNameTest)>(test_param);
 
@@ -95,13 +95,23 @@ class BaseRunFuncTests : public ::testing::TestWithParam<FuncTestParam<InType, O
     ExecuteTaskPipeline();
   }
 
-  /// @brief Executes the full task pipeline with validation.
-  // NOLINTNEXTLINE(readability-function-cognitive-complexity)
   void ExecuteTaskPipeline() {
+    ValidateTask();
+    RunTask();
+    CheckTaskOutput();
+  }
+
+  void ValidateTask() {
     EXPECT_TRUE(task_->Validation());
     EXPECT_TRUE(task_->PreProcessing());
+  }
+
+  void RunTask() {
     EXPECT_TRUE(task_->Run());
     EXPECT_TRUE(task_->PostProcessing());
+  }
+
+  void CheckTaskOutput() {
     EXPECT_TRUE(CheckTestOutputData(task_->GetOutput()));
   }
 
diff --git a/tasks/example_processes/tests/.clang-tidy b/tasks/example_processes/tests/.clang-tidy
@@ -0,0 +1,14 @@
+InheritParentConfig: true
+
+Checks: >
+  -modernize-loop-convert,
+  -cppcoreguidelines-avoid-goto,
+  -cppcoreguidelines-avoid-non-const-global-variables,
+  -misc-override-with-different-visibility,
+  -misc-use-anonymous-namespace,
+  -modernize-use-std-print,
+  -modernize-type-traits
+
+CheckOptions:
+  - key: readability-function-cognitive-complexity.Threshold
+    value: 50  # Relaxed for tests
diff --git a/tasks/example_processes_2/tests/.clang-tidy b/tasks/example_processes_2/tests/.clang-tidy
@@ -0,0 +1,14 @@
+InheritParentConfig: true
+
+Checks: >
+  -modernize-loop-convert,
+  -cppcoreguidelines-avoid-goto,
+  -cppcoreguidelines-avoid-non-const-global-variables,
+  -misc-override-with-different-visibility,
+  -misc-use-anonymous-namespace,
+  -modernize-use-std-print,
+  -modernize-type-traits
+
+CheckOptions:
+  - key: readability-function-cognitive-complexity.Threshold
+    value: 50  # Relaxed for tests
diff --git a/tasks/example_processes_3/tests/.clang-tidy b/tasks/example_processes_3/tests/.clang-tidy
@@ -4,6 +4,7 @@ Checks: >
   -modernize-loop-convert,
   -cppcoreguidelines-avoid-goto,
   -cppcoreguidelines-avoid-non-const-global-variables,
+  -misc-override-with-different-visibility,
   -misc-use-anonymous-namespace,
   -modernize-use-std-print,
   -modernize-type-traits
diff --git a/tasks/example_threads/tests/.clang-tidy b/tasks/example_threads/tests/.clang-tidy
@@ -0,0 +1,14 @@
+InheritParentConfig: true
+
+Checks: >
+  -modernize-loop-convert,
+  -cppcoreguidelines-avoid-goto,
+  -cppcoreguidelines-avoid-non-const-global-variables,
+  -misc-override-with-different-visibility,
+  -misc-use-anonymous-namespace,
+  -modernize-use-std-print,
+  -modernize-type-traits
+
+CheckOptions:
+  - key: readability-function-cognitive-complexity.Threshold
+    value: 50  # Relaxed for tests

Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,7 @@ class TestTask : public ppc::task::Task<InType, OutType> {`
`45`	`45`	`this->GetInput() = in;`
`46`	`46`	`}`
`47`	`47`
	`48`	`+ protected:`
`48`	`49`	`bool ValidationImpl() override {`
`49`	`50`	`return !this->GetInput().empty();`
`50`	`51`	`}`
`@@ -71,6 +72,7 @@ class FakeSlowTask : public TestTask<InType, OutType> {`
`71`	`72`	`public:`
`72`	`73`	`explicit FakeSlowTask(const InType &in) : TestTask<InType, OutType>(in) {}`
`73`	`74`
	`75`	`+ protected:`
`74`	`76`	`bool RunImpl() override {`
`75`	`77`	`std::this_thread::sleep_for(std::chrono::seconds(2));`
`76`	`78`	`return TestTask<InType, OutType>::RunImpl();`
`@@ -233,9 +235,12 @@ TEST(TaskTest, TaskDestructorThrowsIfStageIncomplete) {`
`233`	`235`	`{`
`234`	`236`	`std::vector<int32_t> in(20, 1);`
`235`	`237`	`struct LocalTask : Task<std::vector<int32_t>, int32_t> {`
	`238`	`+ public:`
`236`	`239`	`explicit LocalTask(const std::vector<int32_t> &in) {`
`237`	`240`	`this->GetInput() = in;`
`238`	`241`	`}`
	`242`	`+`
	`243`	`+ protected:`
`239`	`244`	`bool ValidationImpl() override {`
`240`	`245`	`return true;`
`241`	`246`	`}`
`@@ -259,9 +264,12 @@ TEST(TaskTest, TaskDestructorThrowsIfEmpty) {`
`259`	`264`	`{`
`260`	`265`	`std::vector<int32_t> in(20, 1);`
`261`	`266`	`struct LocalTask : Task<std::vector<int32_t>, int32_t> {`
	`267`	`+ public:`
`262`	`268`	`explicit LocalTask(const std::vector<int32_t> &in) {`
`263`	`269`	`this->GetInput() = in;`
`264`	`270`	`}`
	`271`	`+`
	`272`	`+ protected:`
`265`	`273`	`bool ValidationImpl() override {`
`266`	`274`	`return true;`
`267`	`275`	`}`
`@@ -285,9 +293,12 @@ TEST(TaskTest, InternalTimeTestThrowsIfTimeoutExceeded) {`
`285`	`293`	`GTEST_SKIP() << "Skipped on macOS due to time fluctuations.";`
`286`	`294`	`#endif`
`287`	`295`	`struct SlowTask : Task<std::vector<int32_t>, int32_t> {`
	`296`	`+ public:`
`288`	`297`	`explicit SlowTask(const std::vector<int32_t> &in) {`
`289`	`298`	`this->GetInput() = in;`
`290`	`299`	`}`
	`300`	`+`
	`301`	`+ protected:`
`291`	`302`	`bool ValidationImpl() override {`
`292`	`303`	`return true;`
`293`	`304`	`}`
`@@ -315,6 +326,8 @@ TEST(TaskTest, InternalTimeTestThrowsIfTimeoutExceeded) {`
`315`	`326`	`class DummyTask : public Task<int, int> {`
`316`	`327`	`public:`
`317`	`328`	`using Task::Task;`
	`329`	`+`
	`330`	`+ protected:`
`318`	`331`	`bool ValidationImpl() override {`
`319`	`332`	`return true;`
`320`	`333`	`}`