Revert mutable list setting

Author: Avanatiker

common/src/main/kotlin/com/lambda/config/Configurable.kt

@@ -149,7 +149,7 @@ abstract class Configurable(configuration: Configuration) : Jsonable, Nameable {
      * The type parameter [T] must either be a primitive type or a type with a registered type adapter in [Lambda.gson].
      *
      * @param name The unique identifier for the setting.
-     * @param defaultValue The default [MutableList] value of type [T] for the setting.
+     * @param defaultValue The default [List] value of type [T] for the setting.
      * @param description A brief explanation of the setting's purpose and behavior.
      * @param visibility A lambda expression that determines the visibility status of the setting.
      *
@@ -162,7 +162,7 @@ abstract class Configurable(configuration: Configuration) : Jsonable, Nameable {
      */
     inline fun <reified T : Any> setting(
         name: String,
-        defaultValue: MutableList<T>,
+        defaultValue: List<T>,
         description: String = "",
         noinline visibility: () -> Boolean = { true },
     ) = ListSetting(name, defaultValue, description, visibility).also {

common/src/main/kotlin/com/lambda/config/settings/collections/ListSetting.kt

@@ -7,16 +7,16 @@ import com.lambda.config.AbstractSetting
 
 class ListSetting<T>(
     override val name: String,
-    defaultValue: MutableList<T>,
+    defaultValue: List<T>,
     description: String,
     visibility: () -> Boolean,
-) : AbstractSetting<MutableList<T>>(
+) : AbstractSetting<List<T>>(
     defaultValue,
     description,
     visibility
 ) {
     override fun loadFromJson(serialized: JsonElement) {
-        val listType = object : TypeToken<MutableList<T>>() {}.type
+        val listType = object : TypeToken<List<T>>() {}.type
         value = gson.fromJson(serialized, listType)
     }
 }

common/src/main/kotlin/com/lambda/gui/impl/clickgui/GuiConfigurable.kt

@@ -7,5 +7,5 @@ import com.lambda.gui.impl.clickgui.windows.TagWindow
 
 object GuiConfigurable : Configurable(GuiConfig) {
     override val name = "ClickGui"
-    val windows = setting("windows", mutableListOf<WindowComponent<*>>(TagWindow()))
+    val windows = setting("windows", listOf<WindowComponent<*>>(TagWindow()))
 }

common/src/main/kotlin/com/lambda/module/modules/Packetlogger.kt

@@ -37,8 +37,8 @@ object Packetlogger : Module(
     private val networkSide by setting("Network Side", NetworkSide.ANY, "Side of the network to log packets from")
     private val logTicks by setting("Log Ticks", true, "Show game ticks in the log")
     private val scope by setting("Scope", Scope.ANY, "Scope of packets to log")
-    private val whitelist by setting("Whitelist Packets", mutableListOf<String>(), "Packets to whitelist") { scope == Scope.WHITELIST }
-    private val blacklist by setting("Blacklist Packets", mutableListOf<String>(), "Packets to blacklist") { scope == Scope.BLACKLIST }
+    private val whitelist by setting("Whitelist Packets", listOf<String>(), "Packets to whitelist") { scope == Scope.WHITELIST }
+    private val blacklist by setting("Blacklist Packets", listOf<String>(), "Packets to blacklist") { scope == Scope.BLACKLIST }
     private val maxRecursionDepth by setting("Max Recursion Depth", 6, 1..10, 1, "Maximum recursion depth for packet serialization")
     private val logConcurrent by setting("Build Data Concurrent", false, "Whether to serialize packets concurrently. Will not save packets in chronological order but wont lag the game.")