Avoid verbose error handling

onFailure already encapsulate the exception so no need to .recoverCatching unlike .recover which rethrows any error

Author: emyfops

common/src/main/kotlin/com/lambda/config/Configuration.kt

@@ -79,29 +79,20 @@ abstract class Configuration : Jsonable {
     private fun tryLoad() {
         lambdaScope.launch(Dispatchers.IO) {
             runCatching { load(primary) }
-                .onSuccess {
-                    LOG.info("[IO] Config Manager: ${configName.replaceFirstChar(Char::titlecase) }} config loaded.")
-                }
-                .onFailure { LOG.error("Failed to load $configName config, loading backup", it) }
-                .recoverCatching {
+                .onSuccess { LOG.info("[IO] Config Manager: ${configName.replaceFirstChar(Char::titlecase) }} config loaded.") }
+                .onFailure {
+                    LOG.error("Failed to load $configName config, loading backup")
                     runCatching { load(backup) }
                         .onSuccess { LOG.info("$configName config loaded from backup") }
-                        .onFailure {
-                            LOG.error(
-                                "Failed to load $configName config from backup, unrecoverable error",
-                                it
-                            )
-                        }
+                        .onFailure { LOG.error("Failed to load $configName config from backup, unrecoverable error", it) }
                 }
         }
     }
 
     private fun trySave() {
         lambdaScope.launch(Dispatchers.IO) {
             runCatching { save() }
-                .onSuccess {
-                    LOG.info("$configName config saved")
-                }
+                .onSuccess { LOG.info("$configName config saved") }
                 .onFailure { LOG.error("Failed to save $configName config", it) }
         }
     }